[Bug 41468] New: Dont force show checkin column if user hid it previously
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41468 Bug ID: 41468 Summary: Dont force show checkin column if user hid it previously Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: stalkernoid@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle@bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41468 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |stalkernoid@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41468 Peter Vashchuk <stalkernoid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41468 --- Comment #1 from Peter Vashchuk <stalkernoid@gmail.com> --- Created attachment 190589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190589&action=edit Bug 41468: Don't force show checkin column if user wants it hidden If user hides the "Check in" column in the borrower's "Checkouts" table it should stay hidden for the user unless in settings cannot_be_toggled is set to true for the checkin column. Steps to reproduce: 1. Go to the borrower who have some checkouts, and open the checkout's table. 2. Check your admin/columns_settings, you can do that by using the top right Configure button. Check that in issues-table, column checkin has "Cannot be toggled" toggled off. 3. Back at the borrower's page, using the Columns dropdown menu, hide "Check in" column. 4. Refresh the page. The column will be visible anyway. 5. Apply the patch. 6. Force refresh the page, and hide "Check in" column again. 7. Refresh the page. This time it should stay hidden. 8. Go back to admin/columns_settings and toggle on "Cannot be toggled" for checkin column. 9. Refresh borrower's page again, see that "Check in" column is visible again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41468 Slava Shishkin <slavashishkin@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41314 CC| |slavashishkin@gmail.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41314 [Bug 41314] Column visibility broken on the checkouts table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41468 Bug 41468 depends on bug 41314, which changed state. Bug 41314 Summary: Column visibility broken on the checkouts table https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41314 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41468 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Yes, we have this problem on different tables as well. I decided to force the visibility otherwise the column stays hidden when the "config" (here the permission) changes. For instance: Say you have a column that should be shown only if a pref or permission is set If the existing DT's config has it hidden because the config/perm is not set, then it will stay hidden when the config/perm changes. Ideally we should track the two different reasons: "is hidden" because the user decided to explicitly hide the column or because of the configuration. I am not saying that the patch is not correct, but we need to decide what is the correct behaviour, and it's not that trivial IMO. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41468 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=42063 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41468 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- *** This bug has been marked as a duplicate of bug 42063 *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41468 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- *** This bug has been marked as a duplicate of bug 41604 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org