[Bug 33846] New: 'Save' and 'close' buttons confusing on multi-receive
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33846 Bug ID: 33846 Summary: 'Save' and 'close' buttons confusing on multi-receive Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org I'm opening this so we don't forget. Talking with Kyle and Nick, we agreed the 'Save' button is weird, in the sense that it is not saving but updating the underlying table which can then be used to receive. And there's the 'Close' button, that seems to be doing the same thing i.e. closing the modal. Plus, there's no real way of 'resetting' your changes which is the usual thing we have: a confirm button and a cancel. I'm not sure what is the best solution here, but we could have: - Close (which updates the underlying table) - Cancel link (which resets any changes you've made) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33846 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |agustinmoyano@theke.io, | |jonathan.druart+koha@gmail. | |com, | |kyle@bywatersolutions.com, | |martin.renvoize@ptfs-europe | |.com, | |nick@bywatersolutions.com, | |tomascohen@gmail.com Depends on| |8179 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 [Bug 8179] Receiving multiple order lines at once -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33846 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber@kit.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33846 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33846 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Close is not saving, simply closing the modal. Saving is effectively saving the change you made in the modal. At least it is their intended behaviours. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33846 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> ---
From what I found in the code, save mostly just closes the window.
All of the inputs on the form have events attached - when the value is changed we update the row in the background -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33846 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- In my understanding we effectively save the data stored in the "row" data of #order_edit when we click "Save": see onclick event on .modal-save which is calling save_rows -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33846 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- When the modal opens, a copy of the underlying row is stored in the 'row' data element of the #order_edit element which is the modal itself. That data element is kept in sync with the events you mention, Nick. Not the 'real row' on the underlying table. And the 'real row' is synced using the `save_rows_()` function, looping through the 'real rows'. Nick: are you suggesting a more subtle issue? Like the row being stored as a reference to the one in the modal and causing issues? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33846 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I meant `keep_row()` not `save_rows()`. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33846 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Talking about the buttons: I feel like it might be more intuitive to have previous and next buttons next to each other on the left. I want to skip back and forth and now I have to 'move' over the other buttons each time. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org