[Bug 9456] New: Add callnumber column to the cart
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Bug ID: 9456 Summary: Add callnumber column to the cart Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com CC: gmcharlt@gmail.com Adding a separate callnumber column to the cart will allow it to be sorted by callnumber. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 14779 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14779&action=edit Bug 9456 - Add callnumber column to the cart Test Plan: 1) Apply patch 2) Add items to the cart 3) View the cart, note the new column for callnumbers -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14779|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 14780 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14780&action=edit Bug 9456 - Add callnumber column to the cart Test Plan: 1) Apply patch 2) Add items to the cart 3) View the cart, note the new column for callnumbers -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 14782 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14782&action=edit Screenshot of cart with multi-call-number title I question whether this is universally useful, given the fact that call number is item-level and each title can have any number of call numbers. This screenshot shows a made-up example. I don't know how divergent one system's call numbers might be, but if you test with this kind of data it's clear that the sort will be based on the first call number in the list of many. The same is true for location, of course. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 14783 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14783&action=edit Proposed alternate structure What about this instead? I didn't test the nested sorting with DataTables, but I think it is doable. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to comment #4)
Created attachment 14783 [details] Proposed alternate structure
What about this instead? I didn't test the nested sorting with DataTables, but I think it is doable.
If it can do nested sorting that would be perfect! Do you a patch you can upload? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 14861 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14861&action=edit Bug 9456 [Alternate] Add callnumber column to the cart This patch adds call-number sorting to the staff client cart on a title-by-title basis. Item information (library, shelving location, and call number) is moved to a table nested in each row. Location and call number columns in this table are sortable. The patch converts table sorting to DataTables (in a race with Bug 9449). The patch does not attempt to make the larger table of titles sortable by call number. To test, add multiple titles to the staff client cart which have multiple items each. The table of titles should still be sortable by title and item type. The table of items in each row should be sortable by location and call number. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Unfortunately this just doesn't fit the bill. The outer table needs to be sorted by the all inner tables, or it just isn't even useful. I've tried alternate options such as using rowspans so each callnumber has a table row and all the bib level data is rowspan-ed together, but it breaks both datatables and tablesorter. One potential solution is the FakeRowSpan plugin ( http://datatables.net/plug-ins/api#fnFakeRowspan ), however, it requires server side processing apparently. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14780|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 14903 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14903&action=edit Bug 9456 [Alternate] Add callnumber column to the cart - Followup - Sort by callnumbers This patch removes the sub-tables for callnumber/location, and simple surrounds them with a span tag. Sorting is enabled on the 'Items' column which uses a custom sorting routine to sort the callnumbers. If the sort is ascending, each column will be sorted by the highest ordered callnumber for that row. Likewise, if the sort is descending the table will be sorted by the lowest valued callnumber for that row. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14903|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 14904 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14904&action=edit Bug 9456 [Alternate] Add callnumber column to the cart - Followup - Sort by callnumbers This patch removes the sub-tables for callnumber/location, and simply surrounds them with a span tag. Sorting is enabled on the 'Items' column which uses a custom sorting routine to sort the callnumbers. If the sort is ascending, each column will be sorted by the highest ordered callnumber for that row. Likewise, if the sort is descending the table will be sorted by the lowest valued callnumber for that row. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Owen, I think you may find this followup to your patch more acceptable than my original patch. This one looks more like my original patch, but the sorting is actually done using the best suited callnumber for each given row ( by using custom sorting filters for that table column ). When sorting by Items in ascending fashion, the filter uses the highest valued callnumber from each row for sorting. When sorting by Items descending, it uses the lowest valued callnumber from each row. Test plan: 1) Apply all the patches. 2) Create a record with two items, make one a very high callnumber ( e.g. '00000' ) and one a very low callnumber ( e.g. 'ZZZZZ' ). 3) Add this record and a number of other records to the cart. 4) View the cart and sort the Items in both ascending and descending fashion. 5) You should see that the item you created always stays on top because it contains both the highest valued and the lowest valued callnumbers in the list! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paul.poulain@biblibre.com --- Comment #11 from Paul Poulain <paul.poulain@biblibre.com> --- Patch tested with a sandbox, by Delaye Stephane <stephane.delaye@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 --- Comment #12 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 15542 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15542&action=edit Bug 9456 [Alternate] Add callnumber column to the cart - Followup - Sort by callnumbers This patch removes the sub-tables for callnumber/location, and simply surrounds them with a span tag. Sorting is enabled on the 'Items' column which uses a custom sorting routine to sort the callnumbers. If the sort is ascending, each column will be sorted by the highest ordered callnumber for that row. Likewise, if the sort is descending the table will be sorted by the lowest valued callnumber for that row. Signed-off-by: Delaye Stephane <stephane.delaye@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 15544 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15544&action=edit Bug 9043: Syspref improvement: add new type "multiple" This patch adds a new type "multiple" for syspref. This new type allows to select several values for one syspref. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15544|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart <jonathan.druart@biblibre.com> --- Comment on attachment 15544 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15544 Bug 9043: Syspref improvement: add new type "multiple" Sorry, wrong number -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14904|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #15 from Jonathan Druart <jonathan.druart@biblibre.com> --- Please resubmit replacing "/intranet-tmpl/prog/en/" with [% themelang %] (in the first patch) Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14861|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 15727 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15727&action=edit Bug 9456 [Alternate] Add callnumber column to the cart This patch adds call-number sorting to the staff client cart on a title-by-title basis. Item information (library, shelving location, and call number) is moved to a table nested in each row. Location and call number columns in this table are sortable. The patch converts table sorting to DataTables (in a race with Bug 9449). The patch does not attempt to make the larger table of titles sortable by call number. To test, add multiple titles to the staff client cart which have multiple items each. The table of titles should still be sortable by title and item type. The table of items in each row should be sortable by location and call number. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15542|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 15728 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15728&action=edit Bug 9456 [Alternate] Add callnumber column to the cart - Followup - Sort by callnumbers This patch removes the sub-tables for callnumber/location, and simply surrounds them with a span tag. Sorting is enabled on the 'Items' column which uses a custom sorting routine to sort the callnumbers. If the sort is ascending, each column will be sorted by the highest ordered callnumber for that row. Likewise, if the sort is descending the table will be sorted by the lowest valued callnumber for that row. Signed-off-by: Delaye Stephane <stephane.delaye@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|Trivial patch |Small patch QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #18 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: Works great. I don't know if it is relevant to sort on the first value (if there are others one) but I don't have other idea. A followup could be to move javascript code into the datatable.js file. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15727|0 |1 is obsolete| | Attachment #15728|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 15759 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15759&action=edit Bug 9456 [Alternate] Add callnumber column to the cart This patch adds call-number sorting to the staff client cart on a title-by-title basis. Item information (library, shelving location, and call number) is moved to a table nested in each row. Location and call number columns in this table are sortable. The patch converts table sorting to DataTables (in a race with Bug 9449). The patch does not attempt to make the larger table of titles sortable by call number. To test, add multiple titles to the staff client cart which have multiple items each. The table of titles should still be sortable by title and item type. The table of items in each row should be sortable by location and call number. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 --- Comment #20 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 15760 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15760&action=edit Bug 9456 [Alternate] Add callnumber column to the cart - Followup - Sort by callnumbers This patch removes the sub-tables for callnumber/location, and simply surrounds them with a span tag. Sorting is enabled on the 'Items' column which uses a custom sorting routine to sort the callnumbers. If the sort is ascending, each column will be sorted by the highest ordered callnumber for that row. Likewise, if the sort is descending the table will be sorted by the lowest valued callnumber for that row. Signed-off-by: Delaye Stephane <stephane.delaye@biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org --- Comment #21 from Jonathan Druart <jonathan.druart@biblibre.com> --- *** Bug 9449 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #22 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- I am a little bit doubtful about pushing this patch as-is. Although the sorting seems to work, it becomes hard to tell what item belongs to which library, and even where the call numbers begin and end: http://screencast.com/t/meDgCBj3Rwm Is there some way we can group information about each item together so that it's possible to follow? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15759|0 |1 is obsolete| | --- Comment #23 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 15813 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15813&action=edit Bug 9456 [Alternate] Add callnumber column to the cart This patch adds call-number sorting to the staff client cart on a title-by-title basis. Item information (library, shelving location, and call number) is moved to a table nested in each row. Location and call number columns in this table are sortable. The patch converts table sorting to DataTables. The patch does not attempt to make the larger table of titles sortable by call number. To test, add multiple titles to the staff client cart which have multiple items each. The table of titles should still be sortable by title and item type. The table of items in each row should be sortable by location and call number. Rebased on current master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 --- Comment #24 from Owen Leonard <oleonard@myacpl.org> --- I have attached a rebased copy of my patch because I think git was breaking something in it's auto-merge with the Bootstrap changes. Kyle I'm not sure why you created your patch as a follow-up to mine, since our approaches are so different. I think yours should be constructed as a separate patch and presented as an alternative rather than a follow-up to mine. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 --- Comment #25 from Kyle M Hall <kyle@bywatersolutions.com> --- Owen, the entire point of having the callnumber as a column in the cart is to be able to sort all the results by callnumber. Your patch does not accomplish this. This is the reason I created and submitted this bug. (In reply to comment #24)
I have attached a rebased copy of my patch because I think git was breaking something in it's auto-merge with the Bootstrap changes. Kyle I'm not sure why you created your patch as a follow-up to mine, since our approaches are so different. I think yours should be constructed as a separate patch and presented as an alternative rather than a follow-up to mine.
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15759|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 --- Comment #26 from Owen Leonard <oleonard@myacpl.org> --- (In reply to comment #25)
Owen, the entire point of having the callnumber as a column in the cart is to be able to sort all the results by callnumber. Your patch does not accomplish this.
I realize this. My point was simply that submitting your patch as a follow-up to mine, rather than as a separate patch, doesn't make sense because your solution and my solution are completely different. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 --- Comment #27 from Kyle M Hall <kyle@bywatersolutions.com> --- That's true. I'll make mine a standalone patch. Thanks for the clarification! (In reply to comment #26)
(In reply to comment #25)
Owen, the entire point of having the callnumber as a column in the cart is to be able to sort all the results by callnumber. Your patch does not accomplish this.
I realize this. My point was simply that submitting your patch as a follow-up to mine, rather than as a separate patch, doesn't make sense because your solution and my solution are completely different.
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15759|0 |1 is obsolete| | Attachment #15760|0 |1 is obsolete| | Attachment #15813|0 |1 is obsolete| | --- Comment #28 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 15844 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15844&action=edit Bug 9456 - Add callnumber column to the cart - Add monospacing and padding for callnumbers -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15844|0 |1 is obsolete| | --- Comment #29 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 15845 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15845&action=edit [SIGNED-OFF] Bug 9456 - Add callnumber column to the cart This patch adds call-number sorting to the staff client cart. Sortining is enabled on the 'Items' column which uses a custom sorting routine to sort the callnumbers. If the sort is ascending, each column will be sorted by the highest ordered callnumber for that row. Likewise, if the sort is descending the table will be sorted by the lowest valued callnumber for that row. Signed-off-by: Delaye Stephane <stephane.delaye@biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 --- Comment #30 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 15846 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15846&action=edit Bug 9456 - Add callnumber column to the cart - Improve individual item presentation in the Items column -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 --- Comment #31 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 15847 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15847&action=edit Bug 9456 - Add callnumber column to the cart - Add monospacing and padding for callnumbers -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15847|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15846|Bug 9456 - Add callnumber |Bug 9456 - Add callnumber description|column to the cart - |column to the cart - QA |Improve individual item |Followup - Improve |presentation in the Items |individual item |column |presentation in the Items | |column -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15846|0 |1 is obsolete| | --- Comment #32 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 15848 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15848&action=edit Bug 9456 - Add callnumber column to the cart - Improve individual item presentation in the Items column -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 --- Comment #33 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to comment #22)
I am a little bit doubtful about pushing this patch as-is. Although the sorting seems to work, it becomes hard to tell what item belongs to which library, and even where the call numbers begin and end: http://screencast.com/t/meDgCBj3Rwm
Is there some way we can group information about each item together so that it's possible to follow?
This presentation-only follow addresses this issue. Each item is on a single line, with the callnumber, library and location given different emphases. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 --- Comment #34 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Kyle, The patch you uploaded is the one from Owen with sign-offs by Stephane and Jonathan. If Owen agrees that we should go with your patch, could you please attach the standalone version (you might as well squash the follow-up) and mark it Needs Signoff so that we can move it through the QA process? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15845|0 |1 is obsolete| | Attachment #15848|0 |1 is obsolete| | --- Comment #35 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 15937 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15937&action=edit Bug 9456 - Add callnumber column to the cart This patch adds call-number sorting to the staff client cart. Sortining is enabled on the 'Items' column which uses a custom sorting routine to sort the callnumbers. If the sort is ascending, each column will be sorted by the highest ordered callnumber for that row. Likewise, if the sort is descending the table will be sorted by the lowest valued callnumber for that row. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 --- Comment #36 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 15938 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15938&action=edit Bug 9456 - Add callnumber column to the cart - add tooltip -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 --- Comment #37 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to comment #34)
Kyle,
The patch you uploaded is the one from Owen with sign-offs by Stephane and Jonathan. If Owen agrees that we should go with your patch, could you please attach the standalone version (you might as well squash the follow-up) and mark it Needs Signoff so that we can move it through the QA process?
Fixed! Seeing as I cannot let well enough alone, I've included another followup that adds a tooltip to the items sorting explaining it's behavior. If everyone thinks this is a good addition, I can squash it into the primary patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15813|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #38 from Owen Leonard <oleonard@myacpl.org> --- (In reply to comment #35)
Created attachment 15937 [details] [review]
This patch doesn't apply. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15938|0 |1 is obsolete| | --- Comment #39 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 15941 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15941&action=edit Bug 9456 - Add callnumber column to the cart - add tooltip -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15937|0 |1 is obsolete| | --- Comment #40 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 15943 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15943&action=edit Bug 9456 - Add callnumber column to the cart This patch adds call-number sorting to the staff client cart. Sortining is enabled on the 'Items' column which uses a custom sorting routine to sort the callnumbers. If the sort is ascending, each column will be sorted by the highest ordered callnumber for that row. Likewise, if the sort is descending the table will be sorted by the lowest valued callnumber for that row. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15941|0 |1 is obsolete| | --- Comment #41 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 15944 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15944&action=edit Bug 9456 - Add callnumber column to the cart - add tooltip -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA --- Comment #42 from Kyle M Hall <kyle@bywatersolutions.com> --- Fixed! I've also switched from using the Bootstrap tooltip to the Bootstrap popover as it is visually more pleasing ( though I suppose we could restyle the tooltip to look more pleasing as well ). (In reply to comment #38)
(In reply to comment #35)
Created attachment 15937 [details] [review] [review]
This patch doesn't apply.
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Needs Signoff --- Comment #43 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- I'm still a bit confused about which patch you've decided to use, but either way it needs to be signed off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 --- Comment #44 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to comment #43)
I'm still a bit confused about which patch you've decided to use, but either way it needs to be signed off.
Sorry, my bad! I still advocate for the patch I submitted as Owen's patch, while visually quite nice, lacks the functionality that is the entire point of this feature ( being able to sort the entire table by callnumber ). Owen, please give my latest patch a try and let me know what you think! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 --- Comment #45 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Kyle,
Sorry, my bad! I still advocate for the patch I submitted as Owen's patch, while visually quite nice, lacks the functionality that is the entire point of this feature ( being able to sort the entire table by callnumber ).
In that case, please attach it to this bug. Owen's patch is the one you have been attaching to the bug. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15943|0 |1 is obsolete| | --- Comment #46 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 15949 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15949&action=edit Bug 9456 - Add callnumber column to the cart This patch adds call-number sorting to the staff client cart. Sortining is enabled on the 'Items' column which uses a custom sorting routine to sort the callnumbers. If the sort is ascending, each column will be sorted by the highest ordered callnumber for that row. Likewise, if the sort is descending the table will be sorted by the lowest valued callnumber for that row. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15944|0 |1 is obsolete| | --- Comment #47 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 15950 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15950&action=edit Bug 9456 - Add callnumber column to the cart - add tooltip -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 cedric.vita@dracenie.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |cedric.vita@dracenie.com --- Comment #48 from cedric.vita@dracenie.com --- second and third patch doesn't apply. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15813|0 |1 is obsolete| | Attachment #15949|0 |1 is obsolete| | Attachment #15950|0 |1 is obsolete| | --- Comment #49 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 16630 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16630&action=edit Bug 9456 - Add callnumber column to the cart This patch adds call-number sorting to the staff client cart. Sortining is enabled on the 'Items' column which uses a custom sorting routine to sort the callnumbers. If the sort is ascending, each column will be sorted by the highest ordered callnumber for that row. Likewise, if the sort is descending the table will be sorted by the lowest valued callnumber for that row. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 --- Comment #50 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 16631 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16631&action=edit Bug 9456 - Add callnumber column to the cart - add tooltip -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14782|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14783|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #51 from Paul Poulain <paul.poulain@biblibre.com> --- Patch tested with a sandbox, by Cedric Vita <cedric.vita@dracenie.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 --- Comment #52 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 16734 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16734&action=edit Bug 9456 - Add callnumber column to the cart - add tooltip Signed-off-by: Cedric Vita <cedric.vita@dracenie.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16631|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #53 from Jonathan Druart <jonathan.druart@biblibre.com> --- Could you export the 2 dataTable sorting functions into the datatables.js file please? Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 --- Comment #54 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 17994 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17994&action=edit Bug 9456 - Add callnumber column to the cart - Followup - Move sort filters to datatables.js Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16630|0 |1 is obsolete| | Attachment #16734|0 |1 is obsolete| | Attachment #17994|0 |1 is obsolete| | --- Comment #55 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 17995 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17995&action=edit Bug 9456 - Add callnumber column to the cart This patch adds call-number sorting to the staff client cart. Sortining is enabled on the 'Items' column which uses a custom sorting routine to sort the callnumbers. If the sort is ascending, each column will be sorted by the highest ordered callnumber for that row. Likewise, if the sort is descending the table will be sorted by the lowest valued callnumber for that row. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 --- Comment #56 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 17996 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17996&action=edit Bug 9456 - Add callnumber column to the cart - add tooltip Signed-off-by: Cedric Vita <cedric.vita@dracenie.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 --- Comment #57 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 17997 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17997&action=edit Bug 9456 - Add callnumber column to the cart - Followup - Move sort filters to datatables.js Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #58 from Jonathan Druart <jonathan.druart@biblibre.com> --- Kyle, Your first patch introduces some css. Since you don't use a table element, I think it is useless. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17995|0 |1 is obsolete| | --- Comment #59 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 19123 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19123&action=edit Bug 9456 - Add callnumber column to the cart This patch adds call-number sorting to the staff client cart. Sortining is enabled on the 'Items' column which uses a custom sorting routine to sort the callnumbers. If the sort is ascending, each column will be sorted by the highest ordered callnumber for that row. Likewise, if the sort is descending the table will be sorted by the lowest valued callnumber for that row. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17996|0 |1 is obsolete| | --- Comment #60 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 19124 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19124&action=edit Bug 9456 - Add callnumber column to the cart - add tooltip Signed-off-by: Cedric Vita <cedric.vita@dracenie.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17997|0 |1 is obsolete| | --- Comment #61 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 19125 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19125&action=edit Bug 9456 - Add callnumber column to the cart - Followup - Move sort filters to datatables.js Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 --- Comment #62 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 19126 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19126&action=edit Bug 9456 - Add callnumber column to the cart - QA Followup - Remove useless CSS -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 --- Comment #63 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 19146 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19146&action=edit Odd sorting Hi Kyle, Could you explain how these 4 notices are sorted? I think there is an issue. On the left, sorting desc ; on the right, sorting asc. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 --- Comment #64 from Kyle M Hall <kyle@bywatersolutions.com> --- I think I understand your confusion. Sorting by the "items" column does not sort the items within the table cell itself. It sorts the rows based on the highest/lowest callnumber within the the table cell. I believe the callnumbers are displayed in the same order the were created in the database. Example: Sorted by callnumber ascending: --- A E Z --- B C G --- D F V --- Sorted by callnumber descending: --- A E Z --- D F V --- B C G --- Note the order of the callnumbers within a cell does not change. Also note the A,E,Z set is always on top for sorting by callnumber is it contains both the highest and lowest callnumbers! (In reply to comment #63)
Created attachment 19146 [details] Odd sorting
Hi Kyle, Could you explain how these 4 notices are sorted? I think there is an issue. On the left, sorting desc ; on the right, sorting asc.
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 --- Comment #65 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #64)
Note the order of the callnumbers within a cell does not change. Also note the A,E,Z set is always on top for sorting by callnumber is it contains both the highest and lowest callnumbers!
Yes, It is what I understood :) But with my example: 1 = the notice with QC*, callnumber, callNUM, iop 2 = AAAA, ZZZZ, SSSS 3 = CALLNUMBER 4 = without callnumber I am expecting, for asc: 2, 1, 3, 4 (or 4, 2, 1, 3 if "without callnumber" is first) and for desc: 2, 1, 3, 4 too -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 --- Comment #66 from Kyle M Hall <kyle@bywatersolutions.com> --- I believe this is because the location is taken into account as part of the callnumber for sorting purposes. (In reply to comment #65)
(In reply to comment #64)
Note the order of the callnumbers within a cell does not change. Also note the A,E,Z set is always on top for sorting by callnumber is it contains both the highest and lowest callnumbers!
Yes, It is what I understood :) But with my example: 1 = the notice with QC*, callnumber, callNUM, iop 2 = AAAA, ZZZZ, SSSS 3 = CALLNUMBER 4 = without callnumber
I am expecting, for asc: 2, 1, 3, 4 (or 4, 2, 1, 3 if "without callnumber" is first) and for desc: 2, 1, 3, 4 too
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 --- Comment #67 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #66)
I believe this is because the location is taken into account as part of the callnumber for sorting purposes.
Do you think it is simple to add a span or something else in order to sort only callnumbers? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |katrin.fischer@bsz-bw.de --- Comment #68 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Kyle - there are some conflicts, can you please rebase and answer Jonathan's question? I wonder if we should offer an option to show only the items of one selected branch in the list of items? But couldn't take a look at how this effects the display of items. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19123|0 |1 is obsolete| | --- Comment #69 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 19844 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19844&action=edit Bug 9456 - Add callnumber column to the cart This patch adds call-number sorting to the staff client cart. Sortining is enabled on the 'Items' column which uses a custom sorting routine to sort the callnumbers. If the sort is ascending, each column will be sorted by the highest ordered callnumber for that row. Likewise, if the sort is descending the table will be sorted by the lowest valued callnumber for that row. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19124|0 |1 is obsolete| | --- Comment #70 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 19845 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19845&action=edit Bug 9456 - Add callnumber column to the cart - add tooltip Signed-off-by: Cedric Vita <cedric.vita@dracenie.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19125|0 |1 is obsolete| | --- Comment #71 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 19846 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19846&action=edit Bug 9456 - Add callnumber column to the cart - Followup - Move sort filters to datatables.js Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19126|0 |1 is obsolete| | --- Comment #72 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 19847 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19847&action=edit Bug 9456 - Add callnumber column to the cart - QA Followup - Remove useless CSS -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 --- Comment #73 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 19848 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19848&action=edit Bug 9456 - Add callnumber column to the cart - QA Followup 2 - Sort on callnumber only -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19848|0 |1 is obsolete| | --- Comment #74 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 19849 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19849&action=edit Bug 9456 - Add callnumber column to the cart - QA Followup 2 - Sort on callnumber only -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 --- Comment #75 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #68)
Hi Kyle - there are some conflicts, can you please rebase and answer Jonathan's question?
Rebased and fixed! This latest followup parses the sorted strings down to callnumbers and only callnumbers.
I wonder if we should offer an option to show only the items of one selected branch in the list of items? But couldn't take a look at how this effects the display of items.
That is an interesting idea, but I think it would belong in it's own separate bug. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #76 from Jonathan Druart <jonathan.druart@biblibre.com> --- I get a really weird js error when I click on the Items header: TypeError: y[(("string" + "-") + m[Q][1])] is not a function Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19849|0 |1 is obsolete| | --- Comment #77 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 20341 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20341&action=edit Bug 9456 - Add callnumber column to the cart - QA Followup 2 - Sort on callnumber only -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 --- Comment #78 from Kyle M Hall <kyle@bywatersolutions.com> --- Please check again to see if this error still occurs. (In reply to Jonathan Druart from comment #76)
I get a really weird js error when I click on the Items header: TypeError: y[(("string" + "-") + m[Q][1])] is not a function
Marked as Failed QA.
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 --- Comment #79 from Owen Leonard <oleonard@myacpl.org> --- I just tested this and got an error at first because I didn't clear my browser cache. After a shift-reload it worked without errors. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #80 from Jonathan Druart <jonathan.druart@biblibre.com> --- Last followup fixes the js error, thanks Kyle. All work great now, marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19844|0 |1 is obsolete| | --- Comment #81 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 20385 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20385&action=edit Bug 9456 - Add callnumber column to the cart This patch adds call-number sorting to the staff client cart. Sortining is enabled on the 'Items' column which uses a custom sorting routine to sort the callnumbers. If the sort is ascending, each column will be sorted by the highest ordered callnumber for that row. Likewise, if the sort is descending the table will be sorted by the lowest valued callnumber for that row. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19845|0 |1 is obsolete| | --- Comment #82 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 20386 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20386&action=edit Bug 9456 - Add callnumber column to the cart - add tooltip Signed-off-by: Cedric Vita <cedric.vita@dracenie.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19846|0 |1 is obsolete| | --- Comment #83 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 20387 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20387&action=edit Bug 9456 - Add callnumber column to the cart - Followup - Move sort filters to datatables.js Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19847|0 |1 is obsolete| | --- Comment #84 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 20388 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20388&action=edit Bug 9456 - Add callnumber column to the cart - QA Followup - Remove useless CSS Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20341|0 |1 is obsolete| | --- Comment #85 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 20389 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20389&action=edit Bug 9456 - Add callnumber column to the cart - QA Followup 2 - Sort on callnumber only Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 --- Comment #86 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 20390 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20390&action=edit Bug 9456: Remove whitespaces and tab Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_14_candidate -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #87 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org