[Bug 20797] New: If an Ill request has an associated bib record, the detail view should contain a link to the record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 Bug ID: 20797 Summary: If an Ill request has an associated bib record, the detail view should contain a link to the record Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com Currently, the ILL request detail view shows a plain biblionumber.. this should be a link through to the bib record view. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 75454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75454&action=edit Bug 20797 - Add link to biblio detail view from ILL detail view -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7317 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |magnus@libriotech.no --- Comment #2 from Magnus Enger <magnus@libriotech.no> --- The "ILL requests" page (with the table of all the requests) also shows the biblionumber, could we not turn that into a link too? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20799 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Totally.. not sure how I missed it.. tunnel vision. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75454|0 |1 is obsolete| | --- Comment #4 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 75485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75485&action=edit Bug 20797 - Add link to biblio detail view from ILL detail view -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew.isherwood@ptfs-europ | |e.com Status|Failed QA |Needs Signoff --- Comment #5 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Hi Magus - Latest attachment addresses this. Thanks for the feedback :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75485|0 |1 is obsolete| | --- Comment #6 from Magnus Enger <magnus@libriotech.no> --- Created attachment 75486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75486&action=edit Bug 20797 - Add link to biblio detail view from ILL detail view Signed-off-by: Magnus Enger <magnus@libriotech.no> Tested thusly: - Make sure there are a couple of ILL requests with biblionumber - Apply the patch - Go to "List requests" page - Biblionumber is now a link, clicking on it leads to the detail view of the biblio - Go to "Manage request" - Biblionumber is a link here too, clicking on it leads to detail view -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Assignee|koha-bugs@lists.koha-commun |andrew.isherwood@ptfs-europ |ity.org |e.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Please surround 'N/A' with tags (to help translators) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75486|0 |1 is obsolete| | --- Comment #8 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 75656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75656&action=edit Bug 20797 - Add link to biblio detail view from ILL detail view -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 --- Comment #9 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- I've now added <span> tags around all "N/A" strings. Thanks for the feedback Jonathan. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- If "Biblio ID" is not filled, the column contains "0" with a link to /catalogue/detail.pl?biblionumber=0 Also, Andrew, I do not know your workflow when you submit a new patch, but you removed the signed-off-by line and the commit message. You should prefer a follow-up patch (which will be squashed if needed by QAer or RM). It also eases the review. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 --- Comment #11 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Thanks for that Jonathan. I've been squashing fix commits into the original commit, then using git-bz to attach it. So, yes, I can see how that would wipe stuff out, apologies for that. I'll submit follow up patches from now on. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 --- Comment #12 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Hi Jonathan Further to your comment: If "Biblio ID" is not filled, the column contains "0" with a link to /catalogue/detail.pl?biblionumber=0 I've done some digging. It appears that, for some reason, the API response contains a biblio_id of 0, even though the value in the database is NULL. I've checked and there's definitely no casting of this value to an integer in my code so I'm wondering if it's happening at a lower level. The schema definition for the column defines it as an integer, but it's also nullable. I'm not sure what to do about this. I can obviously work around it in the template, but that would just be masking the problem. Any ideas? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 --- Comment #13 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Further to this, I think this is the problem: https://github.com/PTFS-Europe/koha/blob/master/Koha/Object.pm#L249 If it's a numeric column, the value is being cast into an integer regardless of whether it's populated or not. Do you agree this is the bug? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Andrew Isherwood from comment #13)
Further to this, I think this is the problem:
https://github.com/PTFS-Europe/koha/blob/master/Koha/Object.pm#L249
If it's a numeric column, the value is being cast into an integer regardless of whether it's populated or not.
Do you agree this is the bug?
That sounds like a bug yes, can you report it and CC Tomas please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 --- Comment #15 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Done: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20886 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20886 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20886 [Bug 20886] Koha::Object::TO_JSON indiscriminately casting to integer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 --- Comment #16 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 75870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75870&action=edit Bug 20797: (follow-up) Conditionally link We don't want to display the link to the biblio if the biblio_id is null -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 --- Comment #17 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Can this be signed off and QA'ed in conjunction with bug 20886. With the fix for 20886 applied, this patch now works as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Setting back to 'Needs Signoff' as it now depends on bug 20886 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 Bug 20797 depends on bug 7317, which changed state. Bug 7317 Summary: Add an Interlibrary Loan Module to Circulation and OPAC https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 --- Comment #19 from Magnus Enger <magnus@libriotech.no> --- Bug 20886 is now both pushed to master and pushed to stable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75656|0 |1 is obsolete| | --- Comment #20 from Magnus Enger <magnus@libriotech.no> --- Created attachment 79495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79495&action=edit Bug 20797 - Add link to biblio detail view from ILL detail view Signed-off-by: Magnus Enger <magnus@enger.priv.no> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79495|0 |1 is obsolete| | --- Comment #21 from Magnus Enger <magnus@libriotech.no> --- Created attachment 79496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79496&action=edit Bug 20797 - Add link to biblio detail view from ILL detail view Signed-off-by: Magnus Enger <magnus@enger.priv.no> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75870|0 |1 is obsolete| | --- Comment #22 from Magnus Enger <magnus@libriotech.no> --- Created attachment 79497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79497&action=edit Bug 20797: (follow-up) Conditionally link We don't want to display the link to the biblio if the biblio_id is null Signed-off-by: Magnus Enger <magnus@enger.priv.no> Works as advertised. The link is only displayed if there is a biblionumber to link to. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18589 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 [Bug 18589] Show ILLs as part of patron profile -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 --- Comment #23 from Magnus Enger <magnus@libriotech.no> --- Created attachment 79578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79578&action=edit Bug 20996: Remove prefix use of borrower category This patch removes the potential use of borrower category as a ILL request ID prefix. It makes no sense. We provide the ability for a site to define a request prefix based on branch, there is no use case for using the borrower category. Add to this that the borrower for every request was being retrieved in order to get the category, it's a huge performance hit also. We also now require the <branch> block in the <interlibrary_loans> block and complain if it's not present. The request prefix should be defined in this block. This patch also improves the performance of the API request that returns all requests, optionally including additional data. It also deprecates the overloaded TO_JSON method and moves the request augmentation code into the API route's controller. It may be that we want to shift it out of there at some point, but it is fine where it is for now. Signed-off-by: Magnus Enger <magnus@enger.priv.no> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 --- Comment #24 from Magnus Enger <magnus@libriotech.no> --- Created attachment 79579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79579&action=edit Bug 20996: Fix unit tests - Remove unit tests relating to TO_JSON - Add tests for new explicit embedding - Modify tests relating to now deprecated brw_cat Signed-off-by: Magnus Enger <magnus@enger.priv.no> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 --- Comment #25 from Magnus Enger <magnus@libriotech.no> --- Created attachment 79580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79580&action=edit Bug 20996: Further enhance performance We were immediately unblessing all request objects after retrieval then, at a later stage, re-instantiating each one so we could call methods on that. This was a very bad idea. We now preserve the objects for as long as we can. Signed-off-by: Magnus Enger <magnus@enger.priv.no> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 --- Comment #26 from Magnus Enger <magnus@libriotech.no> --- Created attachment 79581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79581&action=edit Bug 20996: (follow-up) Add <branch> to conf tpl Since we now require the <branch> block, we should add it to the config templates Signed-off-by: Magnus Enger <magnus@enger.priv.no> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 --- Comment #27 from Magnus Enger <magnus@libriotech.no> --- Created attachment 79582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79582&action=edit Bug 20996: (follow-up) Fix column name expectation This bug changes how request metadata is obtained. Previously the appropriate backend's metadata function would return it. For at least the FreeForm backend, the metadata property names we title cased. The datatable JS was expecting this and breaks with the new metadata getting which is performed in the API controller, which just returns the property names as they appear in the DB. This patch changes the expectation of the JS to match what's coming back from the API Signed-off-by: Magnus Enger <magnus@enger.priv.no> Tested by repeatedly loading the API-call http://intranet/api/v1/illrequests?embed=metadata,patron,capabilities,librar... in Chromium and watching the reported time to load the URL. There is a siginificant decrease in the time with the patches compared to the time it takes without the patches. I had some concerns along the way, but they have all been fixed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79578|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79579|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79580|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79581|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79582|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 --- Comment #28 from Magnus Enger <magnus@libriotech.no> --- Ooops, attached some patches to the wrong bug. Sorry! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com Status|Signed Off |Failed QA QA Contact| |josef.moravec@gmail.com --- Comment #29 from Josef Moravec <josef.moravec@gmail.com> --- Please add the filters: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt FAIL filters missing_filter at line 568 ( [% request.cost %]) missing_filter at line 456 ( [% request.cost %]) missing_filter at line 528 ( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79496|0 |1 is obsolete| | --- Comment #30 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 79946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79946&action=edit Bug 20797 - Add link to biblio detail view from ILL detail view -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79497|0 |1 is obsolete| | --- Comment #31 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 79947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79947&action=edit Bug 20797: (follow-up) Conditionally link We don't want to display the link to the biblio if the biblio_id is null -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 --- Comment #32 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Rebased and fixed problem raised in comment #29 - thanks Josef! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79946|0 |1 is obsolete| | --- Comment #33 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 80018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80018&action=edit Bug 20797 - Add link to biblio detail view from ILL detail view Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79947|0 |1 is obsolete| | --- Comment #34 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 80019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80019&action=edit Bug 20797: (follow-up) Conditionally link We don't want to display the link to the biblio if the biblio_id is null Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80018|0 |1 is obsolete| | --- Comment #35 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 80021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80021&action=edit Bug 20797 - Add link to biblio detail view from ILL detail view Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80019|0 |1 is obsolete| | --- Comment #36 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 80022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80022&action=edit Bug 20797: (follow-up) Conditionally link We don't want to display the link to the biblio if the biblio_id is null Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20772 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20772 [Bug 20772] Bib metadata pertaining to an ILL request should be editable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de QA Contact|josef.moravec@gmail.com |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80021|0 |1 is obsolete| | --- Comment #37 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 80038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80038&action=edit Bug 20797 - Add link to biblio detail view from ILL detail view Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80022|0 |1 is obsolete| | --- Comment #38 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 80040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80040&action=edit Bug 20797: (follow-up) Conditionally link We don't want to display the link to the biblio if the biblio_id is null Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 --- Comment #39 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 80047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80047&action=edit k -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80038|0 |1 is obsolete| | Attachment #80040|0 |1 is obsolete| | Attachment #80047|0 |1 is obsolete| | --- Comment #40 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 80048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80048&action=edit Bug 20797: Add link to biblio detail view from ILL detail view Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 --- Comment #41 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 80049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80049&action=edit Bug 20797: (follow-up) Conditionally link We don't want to display the link to the biblio if the biblio_id is null Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 --- Comment #42 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Retested as we rebased it on top of 20772 - trying to build a path through the jungle here :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|18589 |20995 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 [Bug 18589] Show ILLs as part of patron profile https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20995 [Bug 20995] Add request ID to OPAC ILL requests display table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 --- Comment #43 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 80055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80055&action=edit Bug 20797: (QA follow-up) Fix ill requests table ... by adding a missing comma. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80048|0 |1 is obsolete| | --- Comment #44 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 80071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80071&action=edit Bug 20797: Add link to biblio detail view from ILL detail view Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80049|0 |1 is obsolete| | --- Comment #45 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 80072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80072&action=edit Bug 20797: (follow-up) Conditionally link We don't want to display the link to the biblio if the biblio_id is null Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80055|0 |1 is obsolete| | --- Comment #46 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 80073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80073&action=edit Bug 20797: (QA follow-up) Fix ill requests table ... by adding a missing comma. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80071|0 |1 is obsolete| | Attachment #80072|0 |1 is obsolete| | Attachment #80073|0 |1 is obsolete| | --- Comment #47 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 80120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80120&action=edit Bug 20797: Add link to biblio detail view from ILL detail view Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 --- Comment #48 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 80121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80121&action=edit Bug 20797: (follow-up) Conditionally link We don't want to display the link to the biblio if the biblio_id is null Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 --- Comment #49 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 80122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80122&action=edit Bug 20797: (QA follow-up) Fix ill requests table ... by adding a missing comma. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|7317 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20799 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20799 [Bug 20799] Add a link from biblio detail view to ILL request detail view, if a biblio has an ILL request -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #50 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed for 18.11. Thanks all! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 Bug 20797 depends on bug 20772, which changed state. Bug 20772 Summary: Make request metadata editable and add price_paid field https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20772 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #51 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement, will not be backported to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 Bug 20797 depends on bug 20886, which changed state. Bug 20886 Summary: Koha::Object::TO_JSON indiscriminately casting to integer https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20886 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20797 Andrew Isherwood <bugzilla@warmlight.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|bugzilla@warmlight.co.uk | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org