[Bug 43459] New: Librarian with permission order_manage should be able to see all vendors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43459 Bug ID: 43459 Summary: Librarian with permission order_manage should be able to see all vendors Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: baptiste.wojtkowski@biblibre.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- Bug 40684 added rights for users with erm permission to list vendors, but this should also be given to users that manage orders since they need to list vendors before actiong on orders -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43459 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch Assignee|koha-bugs@lists.koha-commun |baptiste.wojtkowski@biblibr |ity.org |e.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43459 --- Comment #1 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 204902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204902&action=edit Bug 43459: Allow order_manage to see vendors list Test plan: 1 - Give henry acevedo staff access and order_manage 2 - Log in as henry avecedo, go to acquisition, search for vendors -> insufficient rights 3 - Apply patch 4 - Log in as henry avecedo, go to acquisition, search for vendors -> sufficient rights AFAIK these are the rights formerly needed to perform the action -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43459 Anneli Österman <anneli.osterman@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anneli.osterman@koha-suomi. | |fi --- Comment #2 from Anneli Österman <anneli.osterman@koha-suomi.fi> --- I tested this in a sandbox and it kind of worked. With the patch the Vendors search did give results but it also gave this error message above the results: Something went wrong: Error: Authorization failure. Missing required permission(s). I'm not sure was it because I used a sandbox or is there something wrong with the patch. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43459 --- Comment #3 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 207307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207307&action=edit Bug 43459: (follow-up) Allow order_manage to see vendors list Test plan: 1 - Give henry acevedo staff access and order_manage 2 - Log in as henry avecedo, go to acquisition, search for vendors -> insufficient rights 3 - Apply patch 4 - Log in as henry avecedo, go to acquisition, search for vendors -> sufficient rights 5 - Click on a vendor, you can see the baskets AFAIK these are the rights formerly needed to perform the action -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43459 --- Comment #4 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- I added a second patch to fix this, feel free to squash after SO or QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43459 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amitddng135@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43459 --- Comment #5 from Anneli Österman <anneli.osterman@koha-suomi.fi> --- Created attachment 207502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207502&action=edit Error message still visible I tested this again in a sandbox and there is still a yellow box above the vendors table that says Something went wrong: Error: Authorization failure. Missing required permission(s). (see attachment) As far as I know, otherwise everything works as it should be working. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org