http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11543 --- Comment #1 from Roman Amor <romanwilton@gmail.com> --- Created attachment 24252 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24252&action=edit Proposed patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11543 Daniel Barker <daniel.barker.nz@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24252|0 |1 is obsolete| | --- Comment #2 from Daniel Barker <daniel.barker.nz@gmail.com> --- Created attachment 24257 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24257&action=edit Bug 11543: Increasing test coverage for Category.pm To test: 1. Run prove t/Coverage.t 2. Apply patch 3. Run prove t/Coverage.t - Notice 2 tests were run Signed-off-by: daniel <daniel.barker.nz@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11543 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |kyle@bywatersolutions.com --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- This patch assumes that at least one patron category exists, but does not create or mock any. I believe the test would fail without any categories in the database. The best course of action would be to create a dummy category before running the test, then roll back the insert at the end of the test. In addition, it would be good practice to move this file to t/db_dependent since this test is indeed dependent on the database. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11543 Roman Amor <romanwilton@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24258|0 |1 is obsolete| | --- Comment #5 from Roman Amor <romanwilton@gmail.com> --- Created attachment 24318 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24318&action=edit Bug 11543: Increasing test coverage for Category.pm To test: 1. Run prove t/db_dependent/Category.t 2. Apply patch 3. Run prove t/db_dependent/Category.t - Notice 2 tests were run Signed-off-by: daniel <daniel.barker.nz@gmail.com> Made the requested changes. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11543 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24318|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 24419 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24419&action=edit Bug 11543: Increasing test coverage for Category.pm To test: 1. Run prove t/db_dependent/Category.t 2. Apply patch 3. Run prove t/db_dependent/Category.t - Notice 2 tests were run Signed-off-by: daniel <daniel.barker.nz@gmail.com> Made the requested changes. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11543 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11543 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 24423 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24423&action=edit [PASSED QA] Bug 11543: (followup) Increasing test coverage for Category.pm Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.