[Bug 33894] New: Use template wrapper for tabs: OPAC search history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33894 Bug ID: 33894 Summary: Use template wrapper for tabs: OPAC search history Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 33891 Blocks: 32571 Continuing the work of Bug 32571, I would like to update the OPAC search history page use the new WRAPPER for tabs Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32571 [Bug 32571] Use template wrapper to build tabbed components https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33891 [Bug 33891] Use template wrapper for tabs: OPAC advanced search -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33894 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33894 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 152000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152000&action=edit Bug 33894: Restructuring: Use BLOCKs for biblio and authority sections In order to make the conversion to the tab wrapper markup easier I'm putting the biblio search history and authority search history sections into blocks. This will make it easier to include or not include the sections using template logic. To test, apply the patch and, if necessary, perform some searches for bibliographic and authority records. The OPAC search history page should be unchanged, with the correct information showing under each tab and in each section for current and previous searches. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33894 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 152001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152001&action=edit Bug 33894: Use template wrapper for tabs: OPAC search history This patch updates the OPAC search history page so that it uses the new WRAPPER syntax to generate tabs markup. To test, apply the patch and view the OPAC search history page. With the OpacAuthorities system preference enabled you should see two tabs: Catalog and Authority. Confirm that each tab shows the correct information. Deactivate OpacAuthorities and reload the search history page. The bibliographic search history should display without tabs. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33894 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Please note that the qa tool's errors about Font Awesome icons and aria-hidden attributes appears to be a false positive. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33894 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33894 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152000|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 152018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152018&action=edit Bug 33894: Restructuring: Use BLOCKs for biblio and authority sections In order to make the conversion to the tab wrapper markup easier I'm putting the biblio search history and authority search history sections into blocks. This will make it easier to include or not include the sections using template logic. To test, apply the patch and, if necessary, perform some searches for bibliographic and authority records. The OPAC search history page should be unchanged, with the correct information showing under each tab and in each section for current and previous searches. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33894 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152001|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 152019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152019&action=edit Bug 33894: Use template wrapper for tabs: OPAC search history This patch updates the OPAC search history page so that it uses the new WRAPPER syntax to generate tabs markup. To test, apply the patch and view the OPAC search history page. With the OpacAuthorities system preference enabled you should see two tabs: Catalog and Authority. Confirm that each tab shows the correct information. Deactivate OpacAuthorities and reload the search history page. The bibliographic search history should display without tabs. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33894 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- There is a conflict - can you please rebase? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33894 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33894 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152018|0 |1 is obsolete| | Attachment #152019|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 152255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152255&action=edit Bug 33894: Restructuring: Use BLOCKs for biblio and authority sections In order to make the conversion to the tab wrapper markup easier I'm putting the biblio search history and authority search history sections into blocks. This will make it easier to include or not include the sections using template logic. To test, apply the patch and, if necessary, perform some searches for bibliographic and authority records. The OPAC search history page should be unchanged, with the correct information showing under each tab and in each section for current and previous searches. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33894 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 152256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152256&action=edit Bug 33894: Use template wrapper for tabs: OPAC search history This patch updates the OPAC search history page so that it uses the new WRAPPER syntax to generate tabs markup. To test, apply the patch and view the OPAC search history page. With the OpacAuthorities system preference enabled you should see two tabs: Catalog and Authority. Confirm that each tab shows the correct information. Deactivate OpacAuthorities and reload the search history page. The bibliographic search history should display without tabs. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33894 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Owen, could you check on these please? FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-search-history.tt FAIL forbidden patterns forbidden pattern: Font Awesome icons need the aria-hidden attribute for accessibility purpose (see bug 25166) (line 117) forbidden pattern: Font Awesome icons need the aria-hidden attribute for accessibility purpose (see bug 25166) (line 164) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33894 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Owen Leonard from comment #3)
Please note that the qa tool's errors about Font Awesome icons and aria-hidden attributes appears to be a false positive.
(I should have put this in the commit message!) The icons indicated by the QA tool do have aria-hidden attributes, so I'm not sure what's going on there. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33894 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33894 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33894 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152255|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 152598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152598&action=edit Bug 33894: Restructuring: Use BLOCKs for biblio and authority sections In order to make the conversion to the tab wrapper markup easier I'm putting the biblio search history and authority search history sections into blocks. This will make it easier to include or not include the sections using template logic. To test, apply the patch and, if necessary, perform some searches for bibliographic and authority records. The OPAC search history page should be unchanged, with the correct information showing under each tab and in each section for current and previous searches. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33894 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152256|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 152599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152599&action=edit Bug 33894: Use template wrapper for tabs: OPAC search history This patch updates the OPAC search history page so that it uses the new WRAPPER syntax to generate tabs markup. To test, apply the patch and view the OPAC search history page. With the OpacAuthorities system preference enabled you should see two tabs: Catalog and Authority. Confirm that each tab shows the correct information. Deactivate OpacAuthorities and reload the search history page. The bibliographic search history should display without tabs. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33894 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33894 --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33894 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.02 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33894 --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to 23.05.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33894 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00,23.05.02 |23.11.00,23.05.02,22.11.08 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33894 --- Comment #15 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Nice work everyone! Pushed to 22.11.x for next release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org