https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29194 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28153 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28153 [Bug 28153] Add 'Hold reminder' messaging preference -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29194 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29194 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29194 Enica Davis <enica@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |enica@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29194 --- Comment #3 from Sam Lau <samalau@gmail.com> --- Created attachment 169763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169763&action=edit Bug 29194: Create logical ordering of patron messaging preferences This patch introduces a default ordering for patron messaging preferences. The prefs are then sorted by this ordering before being displayed. To test: 1) Visit a patrons detail page. 2) Note the message prefs aren't ordered (or rather sorted by 'message_attribute_id') 3) Apply patch, restart_all 4) Ensure they are now sorted in teh following fashion: 'Hold_Filled' => 1, 'Hold_Reminder' => 2, 'Recall_Requested' => 3, 'Recall_Waiting' => 4, 'Ill_ready' => 5, 'Ill_unavailable' => 6, 'Ill_update' => 7, 'Item_Checkout' => 8, 'Auto_Renewals' => 9, 'Advance_Notice' => 10, 'Item_Due' => 11, 'Item_Check_in' => 12 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29194 --- Comment #4 from Sam Lau <samalau@gmail.com> --- This should probably be configurable also, filed Bug 37498 for that additional feature. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29194 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169763|0 |1 is obsolete| | --- Comment #5 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 169772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169772&action=edit Bug 29194: Create logical ordering of patron messaging preferences This patch introduces a default ordering for patron messaging preferences. The prefs are then sorted by this ordering before being displayed. To test: 1) Visit a patrons detail page. 2) Note the message prefs aren't ordered (or rather sorted by 'message_attribute_id') 3) Apply patch, restart_all 4) Ensure they are now sorted in teh following fashion: 'Hold_Filled' => 1, 'Hold_Reminder' => 2, 'Recall_Requested' => 3, 'Recall_Waiting' => 4, 'Ill_ready' => 5, 'Ill_unavailable' => 6, 'Ill_update' => 7, 'Item_Checkout' => 8, 'Auto_Renewals' => 9, 'Advance_Notice' => 10, 'Item_Due' => 11, 'Item_Check_in' => 12 Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29194 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Nick Clemens (kidclamp) from comment #0)

Bug 28153 comment 3 suggests the preferences should be ordered

Alphabetical could differ in different languages, and I think that would be confusing

Not sure why. A staff user will normally use one particular language, I suppose.

Currently the table is ordered by 'message_attribute_id' and these is not a simple way to sort as desired

True. (In reply to Sam Lau from comment #3)

4) Ensure they are now sorted in teh following fashion: 'Hold_Filled' => 1, 'Hold_Reminder' => 2, 'Recall_Requested' => 3, 'Recall_Waiting' => 4, 'Ill_ready' => 5, 'Ill_unavailable' => 6, 'Ill_update' => 7, 'Item_Checkout' => 8, 'Auto_Renewals' => 9, 'Advance_Notice' => 10, 'Item_Due' => 11, 'Item_Check_in' => 12

This creates maintenance. For each new notice we need to edit this list. While just sorting by name is simple and effective here imo. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29194 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- +1 for logical ordering over alphabetical. Alphabetical really has no meaning in a short list, because you are going to browse it by functional aspects more likely and it's a short list still. Maybe we could add something a grouping and sort alphabetical within? Groups could be ill, holds, circulation, etc. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29194 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- But then we need to sort on translation in the templates... and the sequence will vary for everyone. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29194 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Magnus Enger from comment #11)

(In reply to Katrin Fischer from comment #10)

...

But then we need to sort on translation in the templates... and the sequence will vary for everyone.

That's the same problem as the tabs with the syspref categories. Nice and alphabetical in English, random when translated. :-)

Exactly. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29194 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169772|0 |1 is obsolete| | --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 172529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172529&action=edit Bug 29194: Create logical ordering of patron messaging preferences This patch introduces a default ordering for patron messaging preferences. The prefs are then sorted by this ordering before being displayed. To test: 1) Visit a patrons detail page. 2) Note the message prefs aren't ordered (or rather sorted by 'message_attribute_id') 3) Apply patch, restart_all 4) Ensure they are now sorted in teh following fashion: 'Hold_Filled' => 1, 'Hold_Reminder' => 2, 'Recall_Requested' => 3, 'Recall_Waiting' => 4, 'Ill_ready' => 5, 'Ill_unavailable' => 6, 'Ill_update' => 7, 'Item_Checkout' => 8, 'Auto_Renewals' => 9, 'Advance_Notice' => 10, 'Item_Due' => 11, 'Item_Check_in' => 12 Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Please note discussion on BZ about the preferred order ;) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29194 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29194 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- As this affects behavior and also documentation for users and staff, I feel it should not be backported as a bug fix. If you are used now that certain options are always in a certain page, you don't want to be surprised by them suddenly moving in a minor or security update. Updating to enhancement. I'd also like to give a chance to have some feedback on the ordering. I see that this is a "chronological" ordering now. That is one way to do it. Personally, I was still irritated by the Checkout and Checkin no longer being next to each other. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29194 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29194 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to main |RESOLVED CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29194 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41657 -- You are receiving this mail because: You are watching all bug changes.