[Bug 26803] New: Fix PLUGIN_DIR when plugin_dirs is multivalued
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26803 Bug ID: 26803 Summary: Fix PLUGIN_DIR when plugin_dirs is multivalued Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs@lists.koha-community.org Reporter: frederic@tamil.fr QA Contact: testopia@bugs.koha-community.org When plugin_dir koha-conf.xml parameter contains more than one directory, PLUGIN_DIR parameter sent to templates doesn't contain the proper value, ie the base directory of the current plugin. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26803 --- Comment #1 from Frédéric Demians <frederic@tamil.fr> --- See bug 23237 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26803 --- Comment #2 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 112295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112295&action=edit Bug 26803 - Fix PLUGIN_DIR when plugin_dirs is multivalued When plugin_dir koha-conf.xml parameter contains more than one directory, PLUGIN_DIR parameter sent to templates doesn't contain the proper value, ie the base directory of the current plugin. See bug 23237 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26803 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26803 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26803 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26803 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112295|0 |1 is obsolete| | --- Comment #3 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 112362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112362&action=edit Bug 26803 - Fix PLUGIN_DIR when plugin_dirs is multivalued When plugin_dir koha-conf.xml parameter contains more than one directory, PLUGIN_DIR parameter sent to templates doesn't contain the proper value, ie the base directory of the current plugin. See bug 23237 Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26803 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki@biblibre.com --- Comment #4 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- I propose the following test plan : 1) install a plugin which make use of PLUGIN_DIR in templates and check it works 2) adding a new plugin dir to koha-conf.xml and restart_all 3) plugin doesn't work anymore. 4) apply patch and restart_all 5) the plugin should now work As an example plugin which requires the variable I used this one : https://github.com/fredericd/Koha-Plugin-Tamil-Mirabel -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26803 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26803 --- Comment #5 from Frédéric Demians <frederic@tamil.fr> --- Thanks Arthur for the test plan. The plugin concerned can be directly downloaded using this link: https://www.tamil.fr/download/koha-plugin-tamil-mirabel-1.0.2.kpz -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26803 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |frederic@tamil.fr |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26803 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22834 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22834 [Bug 22834] Add a method for plugins to return the absolute path for bundled files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26803 --- Comment #6 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- I'm ok this works, but I think its much better to keep get_plugin_dir() method. There a chance it is used by some plugins. Just change its content to return bundle_path(). Also this is a bug report more than enhancement no ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26803 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26803 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112362|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 112518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112518&action=edit Bug 26803 - Fix PLUGIN_DIR when plugin_dirs is multivalued When plugin_dir koha-conf.xml parameter contains more than one directory, PLUGIN_DIR parameter sent to templates doesn't contain the proper value, ie the base directory of the current plugin. See bug 23237 Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26803 --- Comment #8 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Fridolin SOMERS from comment #6)
I'm ok this works, but I think its much better to keep get_plugin_dir() method. There a chance it is used by some plugins. Just change its content to return bundle_path().
Also this is a bug report more than enhancement no ?
Ah OK method plugin_dir() is quite new (19.11). So I'd say its OK to remove it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26803 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23237 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23237 [Bug 23237] Add support for [% INCLUDE %] in plugin templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26803 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26803 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26803 --- Comment #10 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- This is a bug report more than enhancement no ? Please backport. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26803 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Fridolin SOMERS from comment #10)
This is a bug report more than enhancement no ? Please backport.
Please change Importance in this case. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26803 --- Comment #12 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Katrin Fischer from comment #11)
(In reply to Fridolin SOMERS from comment #10)
This is a bug report more than enhancement no ? Please backport.
Please change Importance in this case. :)
Ok cool I was waiting the assignee to agree ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26803 --- Comment #13 from Frédéric Demians <frederic@tamil.fr> --- Thks Fridolin. I agree with you. It could be backported down to 19.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org