[Bug 15922] New: Show authorized value description in staff client search results for lost, withdrawn, and waiting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15922 Bug ID: 15922 Summary: Show authorized value description in staff client search results for lost, withdrawn, and waiting Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org The staff client search results table doesn't show actual authorized value descriptions for items with a lost, damaged, or withdrawn status. Instead it shows "Lost," "Damaged," or "Withdrawn" for any values of those statuses. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15922 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15922 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Show authorized value |Show authorized value |description in staff client |description in staff client |search results for lost, |search results for lost, |withdrawn, and waiting |withdrawn, and damaged -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15922 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15922 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 48385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48385&action=edit Bug 15922 - Show authorized value description in staff client search results for lost, withdrawn, and damaged If an item in the staff client search results list is lost, withdrawn, or damaged, the actual authorized value description for each of those statuses should be displayed rather than the generic term. This patch adds use of the AuthorisedValues template plugin to output the correct description. To test, apply the patch and perform a catalog search in the staff client which will return results with various values for lost, damaged, and withdrawn. Confirm that the correct lost, damaged, or withdrawn status appears for each item rather than the generic term. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15922 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15922 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48385|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 48402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48402&action=edit Bug 15922 - Show authorized value description in staff client search results for lost, withdrawn, and damaged If an item in the staff client search results list is lost, withdrawn, or damaged, the actual authorized value description for each of those statuses should be displayed rather than the generic term. This patch adds use of the AuthorisedValues template plugin to output the correct description. To test, apply the patch and perform a catalog search in the staff client which will return results with various values for lost, damaged, and withdrawn. Confirm that the correct lost, damaged, or withdrawn status appears for each item rather than the generic term. Followed test plan, statuses appear as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15922 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15922 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |In Discussion --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I am not sure about this patch: There are some other places where the string is hardcoded, at least: catalogue/moredetail.tt 77 [% IF ( ITEM_DAT.itemlost ) %]Lost[% END %] 78 [% IF ( ITEM_DAT.damaged ) %]Damaged[% END %] 79 [% IF ( ITEM_DAT.withdrawn ) %]Withdrawn[% END %] catalogue/detail.tt 662 [% IF ( item.withdrawn ) %] 663 <span class="wdn">Withdrawn</span> 664 [% END %] And using the AV, the string is no longer translatable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15922 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #3)
There are some other places where the string is hardcoded, at least:
Those sound like issues which could be addressed in other bug reports.
And using the AV, the string is no longer translatable.
True, but isn't that what we live with every time we use an authorized value? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15922 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Owen Leonard from comment #4)
(In reply to Jonathan Druart from comment #3)
There are some other places where the string is hardcoded, at least:
Those sound like issues which could be addressed in other bug reports.
I personally think we should fix all of them at the same time.
And using the AV, the string is no longer translatable.
True, but isn't that what we live with every time we use an authorized value?
Yes, but for these 3 ones I am pretty sure everybody keeps the default value. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15922 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #5)
I personally think we should fix all of them at the same time.
I'd be happy to submit a follow-up for moredetail.tt and detail.tt.
Yes, but for these 3 ones I am pretty sure everybody keeps the default value.
This bug exists because we use more than just the default value for lost, and damaged and we want to see those locally-defined values. Bug 11280 shows that there was a need for withdrawn to be the same.
catalogue/detail.tt 662 [% IF ( item.withdrawn ) %] 663 <span class="wdn">Withdrawn</span> 664 [% END %]
catalogue/detail.tt already shows the authorized value description for lost and damaged. That it doesn't do so for withdrawn is a bug which should have been fixed by Bug 11280. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15922 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |carmen@bywatersolutions.com --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 14235 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15922 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We have a library asking for the exact status in the result lists as well - is there a way to get this moving again? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15922 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- I'm happy to pick this up again if there are no objections to my initial approach. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15922 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- In my opinion dealing with the other pages in separate bugs sounds ok, but we should file them now so the missing behaviour is better documented. As we got libraries differentiating between lost and missing and sometimes using the different status for 'odd' things they need, I can't say they are always left unchanged :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15922 daltonfury42@gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |daltonfury42@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15922 Lisette <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15922 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20341 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15922 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #11 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Owen Leonard from comment #6)
(In reply to Jonathan Druart from comment #5)
I personally think we should fix all of them at the same time.
I'd be happy to submit a follow-up for moredetail.tt and detail.tt.
Yes, but for these 3 ones I am pretty sure everybody keeps the default value.
This bug exists because we use more than just the default value for lost, and damaged and we want to see those locally-defined values. Bug 11280 shows that there was a need for withdrawn to be the same.
catalogue/detail.tt 662 [% IF ( item.withdrawn ) %] 663 <span class="wdn">Withdrawn</span> 664 [% END %]
catalogue/detail.tt already shows the authorized value description for lost and damaged. That it doesn't do so for withdrawn is a bug which should have been fixed by Bug 11280.
I propose Bug 20341 for that. The idea is to just implement for withdrawn the same behavior as lost and damaged. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15922 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Fridolin, what's missing here? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15922 --- Comment #13 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Katrin Fischer from comment #12)
Fridolin, what's missing here? I'm OK with it.
Jonathan has set in discussion, depends on him. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15922 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Sending to QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15922 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15922 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15922 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48402|0 |1 is obsolete| | --- Comment #15 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 74616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74616&action=edit Bug 15922 - Show authorized value description in staff client search results for lost, withdrawn, and damaged If an item in the staff client search results list is lost, withdrawn, or damaged, the actual authorized value description for each of those statuses should be displayed rather than the generic term. This patch adds use of the AuthorisedValues template plugin to output the correct description. To test, apply the patch and perform a catalog search in the staff client which will return results with various values for lost, damaged, and withdrawn. Confirm that the correct lost, damaged, or withdrawn status appears for each item rather than the generic term. Followed test plan, statuses appear as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15922 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74616|0 |1 is obsolete| | --- Comment #16 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 74617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74617&action=edit Bug 15922: Show authorized value description in staff client search results for lost, withdrawn, and damaged If an item in the staff client search results list is lost, withdrawn, or damaged, the actual authorized value description for each of those statuses should be displayed rather than the generic term. This patch adds use of the AuthorisedValues template plugin to output the correct description. To test, apply the patch and perform a catalog search in the staff client which will return results with various values for lost, damaged, and withdrawn. Confirm that the correct lost, damaged, or withdrawn status appears for each item rather than the generic term. Followed test plan, statuses appear as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15922 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15922 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15922 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Show the library's release notes| |description for variations | |of "Lost," "Damaged," and | |"Withdrawn" statuses which | |have been defined in Koha's | |authorized values. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15922 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15922 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15922 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21877 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15922 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21883 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org