[Bug 32946] New: 'Send list' form in OPAC is misaligned
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32946 Bug ID: 32946 Summary: 'Send list' form in OPAC is misaligned Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Not sure what happened there, but the labels and input fields are no longer aligned correctly and when you change the window size it becomes even more apparent. To test: * Create a private list in the OPAC * Open the list and click "send list" to send by email * The "comment" label for example moves directly after the email address field. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32946 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32946 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32946 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 146588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146588&action=edit Bug 32946: 'Send list' form in OPAC is misaligned This patch tweaks the OPAC CSS and the send list template so that form fields are laid out correctly. To test, apply the patch and rebuild the OPAC CSS. - Log in to the OPAC and create a list if necessary. - In the OPAC's view of the list contents, click the "Send list" button. - In the pop-up window the form layout should look correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32946 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32946 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146588|0 |1 is obsolete| | --- Comment #2 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 146696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146696&action=edit Bug 32946: 'Send list' form in OPAC is misaligned This patch tweaks the OPAC CSS and the send list template so that form fields are laid out correctly. To test, apply the patch and rebuild the OPAC CSS. - Log in to the OPAC and create a list if necessary. - In the OPAC's view of the list contents, click the "Send list" button. - In the pop-up window the form layout should look correct. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32946 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32946 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32946 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146696|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 146702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146702&action=edit Bug 32946: 'Send list' form in OPAC is misaligned This patch tweaks the OPAC CSS and the send list template so that form fields are laid out correctly. To test, apply the patch and rebuild the OPAC CSS. - Log in to the OPAC and create a list if necessary. - In the OPAC's view of the list contents, click the "Send list" button. - In the pop-up window the form layout should look correct. Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32946 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 146703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146703&action=edit Bug 32946: (QA follow-up) Fix "Send cart" form The send cart form is almost identical to the list 'Send list' form and requires the exact same fixes to look good. This patch achieves the same look for both forms. To test: * Fill your cart in the OPAC * Open the cart to view contents * Click on "Send" * The form shoud look nicely aligned * Compary to form for sending lists, they should look the same Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32946 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|'Send list' form in OPAC is |'Send list/cart' forms in |misaligned |OPAC is misaligned -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32946 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32946 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32946 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32946 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32946 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 32384 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org