http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9922 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 16855 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16855&action=edit Bug 9922 - holds queue shows home library with AutomaticReturn Test Plan: 1) Enable AutomaticItemReturn 2) Place a reserve on an item where the holding and home branches differ 3) Rebuild the holds queue 4) Check the holds queue, verify the item is listed in the items to pull for the item's home branch 5) Disable AutomaticItemReturn 6) Rebuild the holds queue 7) Verify the item is listed in the items to pull for the item's holding branch 8) Enable AutomaticItemReturn 9) Apply patch 10) Rebuild the holds queue 11) Verify the item is listed in the items to pull for the item's holding branch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9922 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9922 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz --- Comment #3 from Liz Rea <liz@catalyst.net.nz> --- I'm going to be honest - I think it was a mistake to do anything with automatic item return in the hold queue, and any checking for it should be removed. My understanding of the purpose for automaticitemreturn was to automatically send an item home when nothing away from home was left to do with it, as an example, a library system probably wouldn't want to send an item home in between every hold, it would want to send the item on to the next hold from the item's current holding branch. AutomaticItemReturn only factors in when there are no holds left, and the library wants the book to return home automatically at the end of it's run. I'm not sure I understand why it's even a factor on the hold queue - the hold queue should always pick items from the holding branch, regardless of the AIR setting. Unless it has something to do with the Cost Matrix calculations, let's just get rid of checking for automaticitemreturn all together. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9922 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9922 --- Comment #6 from Liz Rea <liz@catalyst.net.nz> --- Thanks for helping us understand Srdjan. :) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9922 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Right now, the test plan does not work for me. Not sure what is going wrong. I have an item level hold on an item with home branch Demo and holding branch Fairfield. I am logged in for Demo and I no matter which value I have for AIR, the item always shows up for Fairfield. Is this only a problem in earlier versions of Koha? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9922 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16922|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 16996 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16996&action=edit [PASSED QA] Bug 9922 - holds queue shows home library with AutomaticReturn Test Plan: 1) Enable AutomaticItemReturn 2) Place a reserve on a record where the holding and home branches differ for the available items 3) Rebuild the holds queue 4) Check the holds queue, verify the item is listed in the items to pull for the item's home branch 5) Disable AutomaticItemReturn 6) Rebuild the holds queue 7) Verify the item is listed in the items to pull for the item's holding branch 8) Enable AutomaticItemReturn 9) Apply patch 10) Rebuild the holds queue 11) Verify the item is listed in the items to pull for the item's holding branch Signed-off-by: Liz Rea <liz@catalyst.net.nz> Tested per plan, and the patch seems sane. Functionality of the hold queue is restored to previous behaviour. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Amended test plan to make clear it has to be a record level hold for the test plan to work. All tests and QA script pass. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9922 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.