https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30164 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 131036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131036&action=edit Bug 30164: Fix datatable wrapper when no filter passed This problem appears (at least) on the cities list view: If you pass a filter in the "Search cities" filter in the header, it won't be taken into account and all the cities will be displayed. There are two problems. First we are passing an "empty" q=[] in the body, the filter from the header is passed as URL parameters. We should not need to pass the q if it's empty. Then the main problem is coming from a bug in Koha::REST::Plugin::Query but I didn't manage to track it down. If we have two 2 passed, only the second one will be used. We are certainly using a hash somewhere we should not. This patch is fixing the bug but not on the correct side. A follow-up bug should take care of the main problem at lower level. Test plan: Hit /admin/cities.pl Create some cities Use the filter in the header of the page and submit => Without this patch all cities are retrieved => With this patch applied only the relevant cities are displayed. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30164 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30165 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30164 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30164 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30164 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131097|0 |1 is obsolete| | --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 131104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131104&action=edit Bug 30164: Fix datatable wrapper when no filter passed This problem appears (at least) on the cities list view: If you pass a filter in the "Search cities" filter in the header, it won't be taken into account and all the cities will be displayed. There are two problems. First we are passing an "empty" q=[] in the body, the filter from the header is passed as URL parameters. We should not need to pass the q if it's empty. Then the main problem is coming from a bug in Koha::REST::Plugin::Query but I didn't manage to track it down. If we have two 2 passed, only the second one will be used. We are certainly using a hash somewhere we should not. This patch is fixing the bug but not on the correct side. A follow-up bug should take care of the main problem at lower level. Test plan: Hit /admin/cities.pl Create some cities Use the filter in the header of the page and submit => Without this patch all cities are retrieved => With this patch applied only the relevant cities are displayed. Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30164 --- Comment #4 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30164 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|22.05.00,21.11.04 |22.05.00,21.11.04,21.05.13 released in| | CC| |andrew@bywatersolutions.com --- Comment #6 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.13 -- You are receiving this mail because: You are watching all bug changes.