https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 124626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124626&action=edit Bug 28966: Prefetch patron data for holds queue viewer We have a partner processing thousands of holds per day, per branch. At this number of holds, the script loads very slow if it manages to load at all. The primary slowdown is the individual fetch of the patron for each hold to be displayed. If we prefetch those patrons, the entire script should load much faster. Test Plan: 1) Create as many holds as you can ( up to a few thousand if you can ) 2) Run the holds queue viewer, note the load time 3) Apply this patch 4) Restart all the things! 5) Reload the holds queue viewer, load time should be improved 6) Note the HTML generated looks the same -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124627|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 124628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124628&action=edit Bug 28966: Prefetch patron data for holds queue viewer We have a partner processing thousands of holds per day, per branch. At this number of holds, the script loads very slow if it manages to load at all. The primary slowdown is the individual fetch of the patron for each hold to be displayed. If we prefetch those patrons, the entire script should load much faster. Test Plan: 1) Create as many holds as you can ( up to a few thousand if you can ) 2) Run the holds queue viewer, note the load time 3) Apply this patch 4) Restart all the things! 5) Reload the holds queue viewer, load time should be improved 6) Note the HTML generated looks the same -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124629|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 124639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124639&action=edit Bug 28966: Prefetch patron data for holds queue viewer We have a partner processing thousands of holds per day, per branch. At this number of holds, the script loads very slow if it manages to load at all. The primary slowdown is the individual fetch of the patron for each hold to be displayed. If we prefetch those patrons, the entire script should load much faster. Test Plan: 1) Create as many holds as you can ( up to a few thousand if you can ) 2) Run the holds queue viewer, note the load time 3) Apply this patch 4) Restart all the things! 5) Reload the holds queue viewer, load time should be improved 6) Note the HTML generated looks the same -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124639|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 124652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124652&action=edit Bug 28966: Prefetch patron data for holds queue viewer We have a partner processing thousands of holds per day, per branch. At this number of holds, the script loads very slow if it manages to load at all. The primary slowdown is the individual fetch of the patron for each hold to be displayed. If we prefetch those patrons, the entire script should load much faster. Test Plan: 1) Create as many holds as you can ( up to a few thousand if you can ) 2) Run the holds queue viewer, note the load time 3) Apply this patch 4) Restart all the things! 5) Reload the holds queue viewer, load time should be improved 6) Note the HTML generated looks the same -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28974 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974 [Bug 28974] Add pagination to holds queue viewer -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124652|0 |1 is obsolete| | CC| |emmi.takkinen@koha-suomi.fi --- Comment #7 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 124854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124854&action=edit Bug 28966: Prefetch patron data for holds queue viewer We have a partner processing thousands of holds per day, per branch. At this number of holds, the script loads very slow if it manages to load at all. The primary slowdown is the individual fetch of the patron for each hold to be displayed. If we prefetch those patrons, the entire script should load much faster. Test Plan: 1) Create as many holds as you can ( up to a few thousand if you can ) 2) Run the holds queue viewer, note the load time 3) Apply this patch 4) Restart all the things! 5) Reload the holds queue viewer, load time should be improved 6) Note the HTML generated looks the same Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala@iki.fi --- Comment #8 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- hmm, this disables the hide_patron_infos_if_needed variable which is probably not wanted, though the feature is quite broken anyways but this makes it more broken. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124854|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 125377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125377&action=edit Bug 28966: Prefetch patron data for holds queue viewer We have a partner processing thousands of holds per day, per branch. At this number of holds, the script loads very slow if it manages to load at all. The primary slowdown is the individual fetch of the patron for each hold to be displayed. If we prefetch those patrons, the entire script should load much faster. Test Plan: 1) Create as many holds as you can ( up to a few thousand if you can ) 2) Run the holds queue viewer, note the load time 3) Apply this patch 4) Restart all the things! 5) Reload the holds queue viewer, load time should be improved 6) Note the HTML generated looks the same Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 Bug 28966 depends on bug 29015, which changed state. Bug 29015 Summary: Add option to limit Holds Queue report by shelving location / collection https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29015 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Jonathan Druart from comment #11)

This is going backward IMO, why not move to DBIC/Koha::Object instead?

Indeed we should be go back to direct SQL even if faster. Se should use DBIC for all tables, with prefetch. But we could start with adding pagination Bug 28974 while working on rewriting to use DBIC. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 --- Comment #14 from Fridolin Somers <fridolin.somers@biblibre.com> --- Oupsy :

Indeed we should be go back to direct SQL even if faster. Indeed we should not go back to direct SQL even if faster.

-- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143583|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 143584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143584&action=edit Bug 28966: Prefetch patron data for holds queue viewer Test Plan: 1) Generate the holds queue 2) Load the holds queue viewer page 3) Apply this patch 4) Restart all the things! 5) Reload the page 6) Note nothing has changed -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143584|0 |1 is obsolete| | Attachment #143857|0 |1 is obsolete| | --- Comment #20 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 143859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143859&action=edit Bug 28966: Add Koha::Object(s) for tmp_holdsqueue -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 Andreas Jonsson <andreas.jonsson@kreablo.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andreas.jonsson@kreablo.se --- Comment #22 from Andreas Jonsson <andreas.jonsson@kreablo.se> --- This patch breaks the patch for bug 29760 since it removes the patron from the itemloop. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 --- Comment #24 from Andreas Jonsson <andreas.jonsson@kreablo.se> --- The column "Patron category" on the page /cgi-bin/koha/circ/view_holdsqueue.pl will contain empty parentheses. This patch removes the patron attribute from each item: - for my $item ( @$items ) { - $item->{patron} = Koha::Patrons->find( $item->{borrowernumber} ); - } But the displaying of category uses this attribute: <td class="hq-patroncategory">[% itemsloo.patron.category.description | html %] ([% itemsloo.patron.categorycode | html %])</td> Also, the phone number should be affected: [% UNLESS Koha.Preference('HidePatronName') %] <p>[% itemsloo.patron.phone | html %]</p> [% END %] -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #26 from Kyle M Hall <kyle@bywatersolutions.com> --- Can you provide a screenshot? Did you test the patch? It's working fine for me! (In reply to Andreas Jonsson from comment #24)

The column "Patron category" on the page /cgi-bin/koha/circ/view_holdsqueue.pl will contain empty parentheses.

This patch removes the patron attribute from each item:

- for my $item ( @$items ) { - $item->{patron} = Koha::Patrons->find( $item->{borrowernumber} ); - }

But the displaying of category uses this attribute:

<td class="hq-patroncategory">[% itemsloo.patron.category.description | html %] ([% itemsloo.patron.categorycode | html %])</td>

Also, the phone number should be affected:

[% UNLESS Koha.Preference('HidePatronName') %] <p>[% itemsloo.patron.phone | html %]</p> [% END %]

-- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 --- Comment #28 from Kyle M Hall <kyle@bywatersolutions.com> --- During my testing I noticed the item's biblioitem's size wasn't displaying correctly. This new edition should fix that! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 --- Comment #30 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 151734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151734&action=edit Bug 28966: Prefetch patron data for holds queue viewer Test Plan: 1) Generate the holds queue 2) Load the holds queue viewer page 3) Apply this patch 4) Restart all the things! 5) Reload the page 6) Note nothing has changed Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 --- Comment #32 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Kyle M Hall from comment #0)

We have a partner processing thousands of holds per day, per branch. At this number of holds, the script loads very slow if it manages to load at all. The primary slowdown is the individual fetch of the patron for each hold to be displayed. If we prefetch those patrons, the entire script should load much faster.

Could you provide some figures that we are faster now ? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA --- Comment #34 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Changing status for feedback. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 --- Comment #36 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #33)

join => [ 'borrower', # 'biblio', # 'biblioitem', # { # 'item' => { # 'item_group_item' => 'item_group' # } # }, ], prefetch => [ 'biblio', 'biblioitem', { 'item' => { 'item_group_item' => 'item_group' } } ],

Do we need to both join and prefetch here ?

The DBIC docs indicate we can drop the join as the prefetch implies it. The syntax of 'prefetch' is the same as 'join' and implies the joining, so there is no need to use both together. I'll add a followup! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151733|0 |1 is obsolete| | Attachment #151734|0 |1 is obsolete| | Attachment #153120|0 |1 is obsolete| | --- Comment #37 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 153875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153875&action=edit Bug 28966: Add Koha::Object(s) for tmp_holdsqueue Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 --- Comment #39 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 153877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153877&action=edit Bug 28966: (QA follow-up) Changes for Koha objects Trivial edits. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153876|0 |1 is obsolete| | --- Comment #42 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 153880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153880&action=edit Bug 28966: Prefetch patron data for holds queue viewer Test Plan: 1) Generate the holds queue 2) Load the holds queue viewer page 3) Apply this patch 4) Restart all the things! 5) Reload the page 6) Note nothing has changed Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153878|0 |1 is obsolete| | --- Comment #44 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 153882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153882&action=edit Bug 28966: (QA follow-up) Remove superfluous joins Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 --- Comment #45 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 --- Comment #46 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 153928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153928&action=edit Bug 28966: (QA Follow-up) Fix failing unit tests Test Plan: 1) prove t/db_dependent/TestBuilder.t 2) Note tests fail 3) Apply this patch 4) Run updatedatabase.pl 5) Update the schema files ( alias 'dbic' can be used in koha-testing-docker ) 6) prove t/db_dependent/TestBuilder.t 7) Tests now pass! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Keywords|additional_work_needed | --- Comment #48 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Thanks Kyle, for promptly fixing the issue. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #50 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Kyle M Hall from comment #47)

Created attachment 153929 [details] [review] Bug 28966: (QA Follow-up) Fix failing unit tests

Test Plan: 1) prove t/db_dependent/TestBuilder.t 2) Note tests fail 3) Apply this patch 4) Run updatedatabase.pl 5) Update the schema files ( alias 'dbic' can be used in koha-testing-docker ) 6) prove t/db_dependent/TestBuilder.t 7) Tests now pass!

This is breaking Koha_Master_My8 12:06:40 koha_1 | DBD::mysql::st execute failed: All parts of a PRIMARY KEY must be NOT NULL; if you need NULL in a key, use UNIQUE instead at /usr/share/perl5/DBIx/RunSQL.pm line 279, <$args{...}> line 1. 12:06:40 koha_1 | Something went wrong loading file /kohadevbox/koha/installer/data/mysql/kohastructure.sql ([SQL ERROR]: CREATE TABLE `tmp_holdsqueue` ( 12:06:40 koha_1 | `biblionumber` int(11) DEFAULT NULL, 12:06:40 koha_1 | `itemnumber` int(11) DEFAULT NULL, 12:06:40 koha_1 | `barcode` varchar(20) DEFAULT NULL, 12:06:40 koha_1 | `surname` longtext NOT NULL, 12:06:40 koha_1 | `firstname` mediumtext DEFAULT NULL, 12:06:40 koha_1 | `phone` mediumtext DEFAULT NULL, 12:06:40 koha_1 | `borrowernumber` int(11) NOT NULL, 12:06:40 koha_1 | `cardnumber` varchar(32) DEFAULT NULL, 12:06:40 koha_1 | `reservedate` date DEFAULT NULL, 12:06:40 koha_1 | `title` longtext DEFAULT NULL, 12:06:40 koha_1 | `itemcallnumber` varchar(255) DEFAULT NULL, 12:06:40 koha_1 | `holdingbranch` varchar(10) DEFAULT NULL, 12:06:40 koha_1 | `pickbranch` varchar(10) DEFAULT NULL, 12:06:40 koha_1 | `notes` mediumtext DEFAULT NULL, 12:06:40 koha_1 | `item_level_request` tinyint(4) NOT NULL DEFAULT 0, 12:06:40 koha_1 | `timestamp` timestamp NOT NULL DEFAULT current_timestamp() ON UPDATE current_timestamp() COMMENT 'date and time this entry as added/last updated', 12:06:40 koha_1 | PRIMARY KEY (`itemnumber`), 12:06:40 koha_1 | KEY `tmp_holdsqueue_ibfk_1` (`itemnumber`), 12:06:40 koha_1 | KEY `tmp_holdsqueue_ibfk_2` (`biblionumber`), 12:06:40 koha_1 | KEY `tmp_holdsqueue_ibfk_3` (`borrowernumber`), 12:06:40 koha_1 | CONSTRAINT `tmp_holdsqueue_ibfk_1` FOREIGN KEY (`itemnumber`) REFERENCES `items` (`itemnumber`) ON DELETE CASCADE ON UPDATE CASCADE, 12:06:40 koha_1 | CONSTRAINT `tmp_holdsqueue_ibfk_2` FOREIGN KEY (`biblionumber`) REFERENCES `biblio` (`biblionumber`) ON DELETE CASCADE ON UPDATE CASCADE, 12:06:40 koha_1 | CONSTRAINT `tmp_holdsqueue_ibfk_3` FOREIGN KEY (`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE CASCADE ON UPDATE CASCADE 12:06:40 koha_1 | ) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci 12:06:40 koha_1 | ) at /kohadevbox/koha/C4/Installer.pm line 585. https://jenkins.koha-community.org/job/Koha_Master_My8/1236/console -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #51 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Thanks Kyle for taking care on the separate bug. Please QA y'all. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 --- Comment #53 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Mohd Hafiz Yusoff from comment #52)

Upgrade from Koha 23.05 to 23.11 and get this error

Upgrade to 23.06.00.013 [01:38:28]: Bug 28966 - Holds queue view too slow to load for large numbers of holds ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Cannot change column 'itemnumber': used in a foreign key constraint 'tmp_holdsqueue_ibfk_1' at /usr/share/koha/lib/C4/Installer.pm line 741

Also reported on the French mailing list: https://groupes.renater.fr/sympa/arc/koha.infos/2024-01/msg00000.html -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35687 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35687 [Bug 35687] Upgrade to 23.06.00.013 may fail -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28966 --- Comment #55 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Kyle M Hall from comment #54)

(In reply to Jonathan Druart from comment #53)

...

(In reply to Mohd Hafiz Yusoff from comment #52)

...

Upgrade from Koha 23.05 to 23.11 and get this error

Upgrade to 23.06.00.013 [01:38:28]: Bug 28966 - Holds queue view too slow to load for large numbers of holds ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Cannot change column 'itemnumber': used in a foreign key constraint 'tmp_holdsqueue_ibfk_1' at /usr/share/koha/lib/C4/Installer.pm line 741

Also reported on the French mailing list: https://groupes.renater.fr/sympa/arc/koha.infos/2024-01/msg00000.html

I wonder if this is mysql or mariadb version specific. Not getting that error on 10.5.22-MariaDB

Filed a new bug report at https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35687 -- You are receiving this mail because: You are watching all bug changes.