http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5633 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Blocks| |5992 Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5633 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Patron Import |Tools -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5633 --- Comment #3 from Jesse Weaver <pianohacker@gmail.com> 2011-06-07 00:35:23 UTC --- Created attachment 4388 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4388 Bug 5633 : MT2897 : Allow import_borrowers.pl to be used in commandline mode Signed-off-by: Jesse Weaver <pianohacker@gmail.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5633 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |henridamien@koha-fr.org, | |ian.walls@bywatersolutions. | |com Patch Status|Signed Off |Failed QA --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> 2011-08-03 16:08:12 UTC --- QA comment Marking "failed QA" for 2 reasons : * I could not test it = there is no CSV example file provided, I tried various configurations, without success * A little bit more information could/should be given in the --help : "the logs of the import are stored in /var/log/koha/reports/ (if you have permissions to do so), and a mail is sent to KohaAdminEmailAddress (system preference) witht the result of the import as well". It could be worth to display an example as well, to avoid #1 from users ! Other points : * Apply cleanly * The "proposed patch" is obsoleted by jesse sign-off Jesse/hdl, if you give me a testing CSV i'll try again ! I can take care of the follow-up of more doc. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5633 --- Comment #5 from Ian Walls <ian.walls@bywatersolutions.com> 2011-08-05 11:51:41 UTC --- I've marked the "proposed patch" as obsolete. An example CSV, along with a test plan, would go a long way towards making this patch more QA-able. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5633 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P2 Status|Failed QA |ASSIGNED Version|rel_3_4 |master AssignedTo|alex.arnaud@biblibre.com |matthias.meusburger@biblibr | |e.com --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> 2012-01-19 14:56:16 UTC --- Matthias, could you resubmit a patch for this feature BUT, it must not be an enhancement in the tools/ directory, as we've decided not to have scripts that can be run from commandline and http, for security reasons. So please do a script in misc/migration_tools As most of the code will be common to both scripts (tools & command-line), you should put common subs into C4/Members.pm module where it's usefull When reading the patch, seeing many lines like this: - $template->param('lastoverwritten'=>$borrower{'surname'}.' / '.$borrowernumber); + $template->param('lastoverwritten'=>$borrower{'surname'}.' / '.$borrowernumber) if (!$commandline); make me feel the misc/migration_tools/import_borrowers.pl script will have less lines than the tools one ;-) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5633 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5633 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4388|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.