[Bug 14268] New: Change Localsyspref type entry to dropdown
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14268 Bug ID: 14268 Summary: Change Localsyspref type entry to dropdown Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: indradg@gmail.com Reporter: indradg@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 14135 The general consensus based on the comment thread of bug 14135 is that it would be better to convert the entry field to a drop-down from the present text input box. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14268 --- Comment #1 from Indranil Das Gupta <indradg@gmail.com> --- Created attachment 39484 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39484&action=edit Bug 14268 - Dropdown to select 'preftype' 'preftype' for Local Use sysprefs is presently set by free form input box (no UI level validation that leaves the user free to enter arbitrary values). This patch addresses that in part by changing it to a dropdown. The patch depends on patch at Bug 14135 Test plan ========= 1/ apply patch available against 14135 (attachment 39408) 2/ apply this patch 3/ visit admin/systempreferences.pl?op=add_form note the dropdown against 'Variable type' for fieldset 'Koha internals'. By default, the type 'Free' would be selected. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14268 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14268 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14268 --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 39484 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39484 Bug 14268 - Dropdown to select 'preftype' Review of attachment 39484: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14268&attachment=39484) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/systempreferences.tt @@ +200,5 @@
<div class="hint">Note: you should have no reasons to modify the following default values</div> <ol> <li><label for="preftype">Variable type:</label> + <select name="preftype" id="preftype"> + <option value="Choice">Choice</option>
None of the options have 'selected'. You need to have logic in the perl script which passes a hash to the template of { value=>$value, selected=>$selected } where $value is generated by a nice loop, and $selected is set to '' or the appropriate HTML triggering a selection. And then this option loop would output the hash in a nicely formatted manner. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14268 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com Status|Needs Signoff |ASSIGNED --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Moving back to ASSIGNED due to comment #2. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14268 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14268 --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 39493 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39493&action=edit Bug 14268: counter-patch -- dropdown for Variable type The information needed to build the dropdown is already passed. This patch uses it to build the variable type dropdown correctly. TEST PLAN --------- 1) Apply 14135 2) In the staff client: Home -> Global system preferences -> Local use 3) Click 'Edit' on any system preference. 4) Note all the types listed. 5) Click 'Cancel' 6) Apply this patch 7) Click '+New Preference' 8) Enter data to have a decent 'Free' type preference. 9) Click 'Save' 10) For each type noted in step 4 (do 'Free' again last) a) Click 'Edit' for the added system preference -- it should be the last saved variable type. b) Change the variable type to the next type. c) Click 'Save' d) Repeat steps (a) through (c) until all the types have been done. -- NOTE: Yes, there are other strange things here, but those are beyond the scope of this bug. 11) Run koha qa test tools -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14268 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39484|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14268 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39493|0 |1 is obsolete| | --- Comment #5 from Indranil Das Gupta <indradg@gmail.com> --- Created attachment 39494 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39494&action=edit Bug 14268: counter-patch -- dropdown for Variable type The information needed to build the dropdown is already passed. This patch uses it to build the variable type dropdown correctly. TEST PLAN --------- 1) Apply 14135 2) In the staff client: Home -> Global system preferences -> Local use 3) Click 'Edit' on any system preference. 4) Note all the types listed. 5) Click 'Cancel' 6) Apply this patch 7) Click '+New Preference' 8) Enter data to have a decent 'Free' type preference. 9) Click 'Save' 10) For each type noted in step 4 (do 'Free' again last) a) Click 'Edit' for the added system preference -- it should be the last saved variable type. b) Change the variable type to the next type. c) Click 'Save' d) Repeat steps (a) through (c) until all the types have been done. -- NOTE: Yes, there are other strange things here, but those are beyond the scope of this bug. 11) Run koha qa test tools Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14268 --- Comment #6 from Indranil Das Gupta <indradg@gmail.com> --- Created attachment 39495 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39495&action=edit Followup - remove redundant instruction for preftype removes the now redundant instruction "Note: you should have no reasons to modify the following default values" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14268 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39495|0 |1 is obsolete| | --- Comment #7 from Indranil Das Gupta <indradg@gmail.com> --- Created attachment 39496 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39496&action=edit Followup - instruction for preftype selection removes the now redundant instruction "Note: you should have no reasons to modify the following default values" and replaces it with "Note: change the variable type to one of the dropdown values as needed" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14268 tadeas.moravec@gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14268 tadeas.moravec@gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39494|0 |1 is obsolete| | --- Comment #8 from tadeas.moravec@gmail.com --- Created attachment 39580 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39580&action=edit Bug 14268: counter-patch -- dropdown for Variable type The information needed to build the dropdown is already passed. This patch uses it to build the variable type dropdown correctly. TEST PLAN --------- 1) Apply 14135 2) In the staff client: Home -> Global system preferences -> Local use 3) Click 'Edit' on any system preference. 4) Note all the types listed. 5) Click 'Cancel' 6) Apply this patch 7) Click '+New Preference' 8) Enter data to have a decent 'Free' type preference. 9) Click 'Save' 10) For each type noted in step 4 (do 'Free' again last) a) Click 'Edit' for the added system preference -- it should be the last saved variable type. b) Change the variable type to the next type. c) Click 'Save' d) Repeat steps (a) through (c) until all the types have been done. -- NOTE: Yes, there are other strange things here, but those are beyond the scope of this bug. 11) Run koha qa test tools Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com> Signed-off-by: Tadeasm <tadeas.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14268 tadeas.moravec@gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39496|0 |1 is obsolete| | --- Comment #9 from tadeas.moravec@gmail.com --- Created attachment 39581 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39581&action=edit Followup - instruction for preftype selection removes the now redundant instruction "Note: you should have no reasons to modify the following default values" and replaces it with "Note: change the variable type to one of the dropdown values as needed" http://bugs.koha-community.org/show_bug.cgi?id=14268 Signed-off-by: Tadeasm <tadeas.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14268 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14268 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39580|0 |1 is obsolete| | Attachment #39581|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 39589 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39589&action=edit Bug 14268: Use dropdown for variable types The information needed to build the dropdown is already passed. This patch uses it to build the variable type dropdown correctly. TEST PLAN --------- 1) Apply 14135 2) In the staff client: Home -> Global system preferences -> Local use 3) Click 'Edit' on any system preference. 4) Note all the types listed. 5) Click 'Cancel' 6) Apply this patch 7) Click '+New Preference' 8) Enter data to have a decent 'Free' type preference. 9) Click 'Save' 10) For each type noted in step 4 (do 'Free' again last) a) Click 'Edit' for the added system preference -- it should be the last saved variable type. b) Change the variable type to the next type. c) Click 'Save' d) Repeat steps (a) through (c) until all the types have been done. -- NOTE: Yes, there are other strange things here, but those are beyond the scope of this bug. 11) Run koha qa test tools Signed-off-by: Indranil Das Gupta (L2C2 Technologies) <indradg@gmail.com> Signed-off-by: Tadeasm <tadeas.moravec@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14268 --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 39590 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39590&action=edit Bug 14268: Followup - instruction for preftype selection removes the now redundant instruction "Note: you should have no reasons to modify the following default values" and replaces it with "Note: change the variable type to one of the dropdown values as needed" Signed-off-by: Tadeasm <tadeas.moravec@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14268 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Mark and Indranil! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org