[Bug 18393] New: Canned report reports/ acquisitions_stats.pl not filtering correctly by collection code
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18393 Bug ID: 18393 Summary: Canned report reports/acquisitions_stats.pl not filtering correctly by collection code Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt@gmail.com Reporter: barton@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Created attachment 61929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61929&action=edit report settings The canned report under Home › Reports › Acquisitions statistics is not filtering on collection code. To replicate: 'Received on' check 'row' Filter: From: 01/01/2016 To: 12/31/2016 (or use a date range that corresponds to acquisitions on your system) 'Collection code' check 'column' Filter: Select 'All' Cell value Choose 'Count items' Output Choose 'To screen into the browser' Click Submit. You will see columns of collection codes, with each row being a separate date. All collection codes will be displayed. Use the browser's back button, change the collection code 'Collection code' check 'column' Filter: Select 'Music' (or a collection code on your system) Click submit. We would expect to see a single column showing the 'Music' collection code -- instead we see all collection codes again. See screenshots for report settings and output. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18393 --- Comment #1 from Barton Chittenden <barton@bywatersolutions.com> --- Created attachment 61930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61930&action=edit Report results, all collection codes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18393 --- Comment #2 from Barton Chittenden <barton@bywatersolutions.com> --- Created attachment 61931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61931&action=edit Report results, choose collection code 'music only' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18393 Barton Chittenden <barton@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18393 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It looks like a template issue, the codes in the values are missing: <select name="Filter"> <option value="" selected="selected">All</option> <option value="">Fiction</option> <option value="">Non-fiction</option> <option value="">Reference</option> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18393 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18393 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Canned report |Statistics wizard for |reports/acquisitions_stats. |acquisitions not filtering |pl not filtering correctly |correctly by collection |by collection code |code -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18393 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18393 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84948&action=edit Bug 18939: Acquisition statistics - Fix wrong template variable name for collection filter The template variable was wrong, so the filter never submitted the collection code for the query. Before: <option value="">Fiction</option> <option value="">Non-fiction</option> After: <option value="FIC">Fiction</option> <option value="NFIC">Non-fiction</option> To test: - Go to Reports > Statistics wizards > Acquisitions - Pick a row and column - Compare results with and without collection filter - Verify the table is always the same - Apply patch - Repeat comparison, verify the filter works now -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18393 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84948|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 85023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85023&action=edit Bug 18939: Acquisition statistics - Fix wrong template variable name for collection filter The template variable was wrong, so the filter never submitted the collection code for the query. Before: <option value="">Fiction</option> <option value="">Non-fiction</option> After: <option value="FIC">Fiction</option> <option value="NFIC">Non-fiction</option> To test: - Go to Reports > Statistics wizards > Acquisitions - Pick a row and column - Compare results with and without collection filter - Verify the table is always the same - Apply patch - Repeat comparison, verify the filter works now https://bugs.koha-community.org/show_bug.cgi?id=18393 Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18393 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize@ptfs-europe | |.com --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work Katrin, another great fix that I'm going to go straight for PQA on.. works well, no regressions found. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18393 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18393 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18393 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18393 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.04 - I corrected the commit message to state the correct bug number on push too.. 18939 -> 18393 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18393 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.05.x for 18.05.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18393 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org