[Bug 36618] New: Make biblio creation optional for ERM local titles
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36618 Bug ID: 36618 Summary: Make biblio creation optional for ERM local titles Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ERM Assignee: jonathan.druart@gmail.com Reporter: matt.blenkinsop@ptfs-europe.com CC: jonathan.druart@gmail.com, jonathan.field@ptfs-europe.com, martin.renvoize@ptfs-europe.com, matt.blenkinsop@ptfs-europe.com, pedro.amorim@ptfs-europe.com Biblio creation for local titles should be optional at the point of creation. This will then be used for the KBART import feature as well -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36618 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart@gmail.com |matt.blenkinsop@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36618 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36618 --- Comment #1 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 164992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164992&action=edit Bug 36618: Make biblio creation optional for ERM local titles This patch makes biblio creation on local title creation optional. Test plan: 1) Navigate to the local title creation form 2) Create a title and leave the "Create record" box unchecked 3) Submit the form 4) Search the catalogue for the title you have just created - no biblio result will be available 5) Repeat steps 2 - 3 but this time check the box to create a record 6) You should now be able to find a record in the catalogue for the title you just imported -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36618 --- Comment #2 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 164993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164993&action=edit Bug 36618: Add unit tests prove t/db_dependent/api/v1/erm_eholdings_titles.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36618 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36618 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34788 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34788 [Bug 34788] Add the ability to import KBART files to ERM -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36618 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clemens.tubach@kit.edu, | |michaela.sieber@kit.edu --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Clemens and Michaela, as you have tested bug 34788, would you mind giving this a sign-off as well? You basically already tested it as it has been part of your testing of bug 34788. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36618 --- Comment #4 from Clemens Tubach <clemens.tubach@kit.edu> --- (In reply to Katrin Fischer from comment #3)
Hi Clemens and Michaela, as you have tested bug 34788, would you mind giving this a sign-off as well? You basically already tested it as it has been part of your testing of bug 34788.
Hi Katrin, I have tried to give the sign-off, but the unit test fails: Test Summary Report ------------------- t/db_dependent/api/v1/erm_eholdings_titles.t (Wstat: 512 (exited 2) Tests: 5 Failed: 2) Failed tests: 3-4 Non-zero exit status: 2 Files=1, Tests=5, 15 wallclock secs ( 0.03 usr 0.02 sys + 11.53 cusr 1.81 csys = 13.39 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36618 --- Comment #5 from Clemens Tubach <clemens.tubach@kit.edu> --- The test works, sorry ... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36618 Clemens Tubach <clemens.tubach@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36618 Clemens Tubach <clemens.tubach@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164992|0 |1 is obsolete| | Attachment #164993|0 |1 is obsolete| | --- Comment #6 from Clemens Tubach <clemens.tubach@kit.edu> --- Created attachment 166149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166149&action=edit Bug 36618: Make biblio creation optional for ERM local titles This patch makes biblio creation on local title creation optional. Test plan: 1) Navigate to the local title creation form 2) Create a title and leave the "Create record" box unchecked 3) Submit the form 4) Search the catalogue for the title you have just created - no biblio result will be available 5) Repeat steps 2 - 3 but this time check the box to create a record 6) You should now be able to find a record in the catalogue for the title you just imported Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36618 --- Comment #7 from Clemens Tubach <clemens.tubach@kit.edu> --- Created attachment 166150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166150&action=edit Bug 36618: Add unit tests prove t/db_dependent/api/v1/erm_eholdings_titles.t Signed-off-by: Clemens Tubach <clemens.tubach@kit.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36618 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |nick@bywatersolutions.com --- Comment #8 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> ---
From what I see, before this patch the default is to create a bibliographic record when adding a title. This is a change of behavior as the default is now to not create the record. Is it intentional/is this the desired default?
When I create a title with no bibliographic record, then edit it, I see a button to: Update linked biblio record If I enabled this, then I create a record. I think this button should either say "Create biblio record" or not be present after I have chosen not to create a biblio the first time? QA tools complain of tidiness -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36618 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36618 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166149|0 |1 is obsolete| | --- Comment #9 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 166380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166380&action=edit Bug 36618: Make biblio creation optional for ERM local titles This patch makes biblio creation on local title creation optional. Test plan: 1) Navigate to the local title creation form 2) Create a title and leave the "Create record" box unchecked 3) Submit the form 4) Search the catalogue for the title you have just created - no biblio result will be available 5) Repeat steps 2 - 3 but this time check the box to create a record 6) You should now be able to find a record in the catalogue for the title you just imported -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36618 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166150|0 |1 is obsolete| | --- Comment #10 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 166381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166381&action=edit Bug 36618: Add unit tests prove t/db_dependent/api/v1/erm_eholdings_titles.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36618 --- Comment #11 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 166382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166382&action=edit Bug 36618: (QA follow-up) Hide option for titles with no linked record This patch hides the "Update linked biblio" option for titles that have been created with no linked biblio record -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36618 --- Comment #12 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- I've fixed the tidying issues and changed it so that it hides the option to update the linked record when updating a title that doesn't have a linked record. I think it makes more sense that eventually the import tool in bug 34788 is expanded to be able to do batch record additions/updates for titles and it also avoids accidental creation of records in the short term -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36618 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36618 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166380|0 |1 is obsolete| | Attachment #166381|0 |1 is obsolete| | Attachment #166382|0 |1 is obsolete| | --- Comment #13 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 166386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166386&action=edit Bug 36618: Make biblio creation optional for ERM local titles This patch makes biblio creation on local title creation optional. Test plan: 1) Navigate to the local title creation form 2) Create a title and leave the "Create record" box unchecked 3) Submit the form 4) Search the catalogue for the title you have just created - no biblio result will be available 5) Repeat steps 2 - 3 but this time check the box to create a record 6) You should now be able to find a record in the catalogue for the title you just imported Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36618 --- Comment #14 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 166387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166387&action=edit Bug 36618: Add unit tests prove t/db_dependent/api/v1/erm_eholdings_titles.t Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36618 --- Comment #15 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 166388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166388&action=edit Bug 36618: (QA follow-up) Hide option for titles with no linked record This patch hides the "Update linked biblio" option for titles that have been created with no linked biblio record Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36618 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36618 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 1) Translatability I don't believe that Update and Create will be picked up by the translation scripts in this construct: + <legend> + {{ + $__("%s linked biblio record").format( + title.title_id ? "Update" : "Create" + ) + }}: + </legend> + <label for="create_linked_biblio" + >{{ + $__("%s record").format( + title.title_id ? "Update" : "Create" + ) + }}:</label + > Please follow-up! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36618 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- In general, don't try to be too clever with things like that. It makes it harder to translate in the translations tools if you cut up sentences. Most of the time it's better to just have 2 full strings to translate because it adds context and looks less confusing in the tools. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36618 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36618 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36618 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Make biblio creation |Make creation of |optional for ERM local |bibliographic records |titles |optional for ERM local | |titles -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36618 --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- What's the additional work needed here? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36618 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Martin Renvoize from comment #19)
What's the additional work needed here?
Comment #16 - broken strings. As it will only "add strings" I'd be happy to still push. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36618 --- Comment #21 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 167111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167111&action=edit Bug 36618: (follow-up) Fix broken translations -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36618 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36618 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36618 --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36618 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36618 --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36618 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #24 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not backported to 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36618 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Without this patch creating release notes| |a local title would always | |create a bibliographic | |record in the catalog as | |well. Now this is optional | |depending on a checkbox. | |The checkbox is also | |available when importing | |local records form a KBART | |file. Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36618 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36618 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org