[Bug 27779] New: Cashup summary 'refunds' should denote what the refund was actioned against.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 Bug ID: 27779 Summary: Cashup summary 'refunds' should denote what the refund was actioned against. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Currently, we group 'Refunds' together in one group. It would be preferable to group them by the type of transaction they're refunding. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13985 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26273 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 [Bug 26273] Expose cashup summary history for a cash register -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26272 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26272 [Bug 26272] Allow cashup summaries to be displayed from the library summary page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 121218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121218&action=edit Bug 27779: Group payouts by type of debit they're applied against This patch adds additional grouping to the cashup summary output such that payouts are additionally grouped by the types of debit they're applied against. The cashup sumary modal is adapted to expose the descriptions at the grouping level too. Test plan 1/ Add a various transactions using a cash register (Using Point of Sale, Patron Accounts with payments etc). 2/ Refund some of the debts and pick the 'cash' option for payout. (ensure you pick a variety of debit types) 3/ Add some credit to a patron account, (either refund a debt as 'credit' or add a 'manual credit') 4/ Payout the credit as 'cash' on the patron account 5/ Cashup the register 6/ Inspect the cashup summary for your cashup. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 121219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121219&action=edit Bug 27779: Update 'REFUND' description in the database This patch simplified the REFUND description from 'Refund applied to a patrons fine' to simply 'Refund'.. this allows the description to be combined with debit type descriptions simply to denote what it was applied against instead of using the generic 'applied to a patrons fine' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121218|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 121224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121224&action=edit Bug 27779: Group payouts by type of debit they're applied against This patch adds additional grouping to the cashup summary output such that payouts are additionally grouped by the types of debit they're applied against. The cashup sumary modal is adapted to expose the descriptions at the grouping level too. Test plan 1/ Add a various transactions using a cash register (Using Point of Sale, Patron Accounts with payments etc). 2/ Refund some of the debts and pick the 'cash' option for payout. (ensure you pick a variety of debit types) 3/ Add some credit to a patron account, (either refund a debt as 'credit' or add a 'manual credit') 4/ Payout the credit as 'cash' on the patron account 5/ Cashup the register 6/ Inspect the cashup summary for your cashup. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121219|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 121225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121225&action=edit Bug 27779: Update 'REFUND' description in the database This patch simplified the REFUND description from 'Refund applied to a patrons fine' to simply 'Refund'.. this allows the description to be combined with debit type descriptions simply to denote what it was applied against instead of using the generic 'applied to a patrons fine' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121224|0 |1 is obsolete| | --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 127552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127552&action=edit Bug 27779: Group payouts by type of debit they're applied against This patch adds additional grouping to the cashup summary output such that payouts are additionally grouped by the types of debit they're applied against. The cashup sumary modal is adapted to expose the descriptions at the grouping level too. Test plan 1/ Add a various transactions using a cash register (Using Point of Sale, Patron Accounts with payments etc). 2/ Refund some of the debts and pick the 'cash' option for payout. (ensure you pick a variety of debit types) 3/ Add some credit to a patron account, (either refund a debt as 'credit' or add a 'manual credit') 4/ Payout the credit as 'cash' on the patron account 5/ Cashup the register 6/ Inspect the cashup summary for your cashup. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121225|0 |1 is obsolete| | --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 127553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127553&action=edit Bug 27779: Update 'REFUND' description in the database This patch simplified the REFUND description from 'Refund applied to a patrons fine' to simply 'Refund'.. this allows the description to be combined with debit type descriptions simply to denote what it was applied against instead of using the generic 'applied to a patrons fine' Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 127554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127554&action=edit Bug 27779: New atomic update syntax Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 Bug 27779 depends on bug 26273, which changed state. Bug 26273 Summary: Expose cashup summary history for a cash register https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26273 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 Bug 27779 depends on bug 26272, which changed state. Bug 26272 Summary: Allow cashup summaries to be displayed from the library summary page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26272 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Small translation issue here: + if ( out.credit_type_code == 'REFUND' ) { + tbody.append('<tr><td>' + out.credit_type.description + ' against ' + out.related_debit.debit_type.description + '</td><td>- ' + out.total + '</td></tr>'); + } else { -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 130024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130024&action=edit Bug 27779: (QA follow-up) Fix translation issue with 'against' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Wondering about another I18N issue here: You assume in your database update that Refund has not been translated to read something different. But they will be translated if you have used a translated web installer, right? So this will throw it back to English, with no way to fix it apart from using SQL, as the GUI doesn't allow to edit the system debit and credit types. Could we negotiate making the description field editable in the GUI on a separate bug? I don't see another way to fix this translation issue nicely. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Cashup summary 'refunds' |Cashup summary 'refunds' |should denote what the |should denote what the |refund was actioned |refund was actioned against |against. | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Testing this led me to filing bug 29985, bug 29986 and bug 29987. :( I am not sure if I am doing this right or wrong. All of these not being strictly related to this patch set, apart from maybe the descriptions issue. The one remaining thing now is that I feel like we should really price format this output (meaning adhering to CurrencyFormat). Any hope we could do this in a follow up? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Realized my follow-up is a little wrong too - translatable strings should always be in double quotes "" because of some languages using '. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127552|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136491&action=edit Bug 27779: Group payouts by type of debit they're applied against This patch adds additional grouping to the cashup summary output such that payouts are additionally grouped by the types of debit they're applied against. The cashup sumary modal is adapted to expose the descriptions at the grouping level too. Test plan 1/ Add a various transactions using a cash register (Using Point of Sale, Patron Accounts with payments etc). 2/ Refund some of the debts and pick the 'cash' option for payout. (ensure you pick a variety of debit types) 3/ Add some credit to a patron account, (either refund a debt as 'credit' or add a 'manual credit') 4/ Payout the credit as 'cash' on the patron account 5/ Cashup the register 6/ Inspect the cashup summary for your cashup. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127553|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136492&action=edit Bug 27779: Update 'REFUND' description in the database This patch simplified the REFUND description from 'Refund applied to a patrons fine' to simply 'Refund'.. this allows the description to be combined with debit type descriptions simply to denote what it was applied against instead of using the generic 'applied to a patrons fine' Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127554|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136493&action=edit Bug 27779: New atomic update syntax Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130024|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136494&action=edit Bug 27779: (QA follow-up) Fix translation issue with 'against' Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136495&action=edit Bug 27779: (QA follow-up) Fix database update Don't overwrite peoples translations if they've already changed the description. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Rebased, follow-up added to correct issue with DB update and corrected and signed off Katrins follow-up. Setting back to signed off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #10)
Wondering about another I18N issue here: You assume in your database update that Refund has not been translated to read something different. But they will be translated if you have used a translated web installer, right? So this will throw it back to English, with no way to fix it apart from using SQL, as the GUI doesn't allow to edit the system debit and credit types.
Could we negotiate making the description field editable in the GUI on a separate bug? I don't see another way to fix this translation issue nicely.
I've corrected the database update so it won't overwrite already changed descriptions. The descriptions are already editable in the GUI.. they're just debit/credit types. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #11)
The one remaining thing now is that I feel like we should really price format this output (meaning adhering to CurrencyFormat).
Any hope we could do this in a follow up?
It's done on bug 31038 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136491|0 |1 is obsolete| | --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 137386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137386&action=edit Bug 27779: Group payouts by type of debit they're applied against This patch adds additional grouping to the cashup summary output such that payouts are additionally grouped by the types of debit they're applied against. The cashup sumary modal is adapted to expose the descriptions at the grouping level too. Test plan 1/ Add a various transactions using a cash register (Using Point of Sale, Patron Accounts with payments etc). 2/ Refund some of the debts and pick the 'cash' option for payout. (ensure you pick a variety of debit types) 3/ Add some credit to a patron account, (either refund a debt as 'credit' or add a 'manual credit') 4/ Payout the credit as 'cash' on the patron account 5/ Cashup the register 6/ Inspect the cashup summary for your cashup. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136492|0 |1 is obsolete| | --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 137387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137387&action=edit Bug 27779: Update 'REFUND' description in the database This patch simplified the REFUND description from 'Refund applied to a patrons fine' to simply 'Refund'.. this allows the description to be combined with debit type descriptions simply to denote what it was applied against instead of using the generic 'applied to a patrons fine' Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136493|0 |1 is obsolete| | --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 137388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137388&action=edit Bug 27779: New atomic update syntax Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136494|0 |1 is obsolete| | --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 137389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137389&action=edit Bug 27779: (QA follow-up) Fix translation issue with 'against' Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136495|0 |1 is obsolete| | --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 137390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137390&action=edit Bug 27779: (QA follow-up) Fix database update Don't overwrite peoples translations if they've already changed the description. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #26 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Please rebase. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137386|0 |1 is obsolete| | --- Comment #27 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 138809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138809&action=edit Bug 27779: Group payouts by type of debit they're applied against This patch adds additional grouping to the cashup summary output such that payouts are additionally grouped by the types of debit they're applied against. The cashup sumary modal is adapted to expose the descriptions at the grouping level too. Test plan 1/ Add a various transactions using a cash register (Using Point of Sale, Patron Accounts with payments etc). 2/ Refund some of the debts and pick the 'cash' option for payout. (ensure you pick a variety of debit types) 3/ Add some credit to a patron account, (either refund a debt as 'credit' or add a 'manual credit') 4/ Payout the credit as 'cash' on the patron account 5/ Cashup the register 6/ Inspect the cashup summary for your cashup. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137387|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 138810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138810&action=edit Bug 27779: Update 'REFUND' description in the database This patch simplified the REFUND description from 'Refund applied to a patrons fine' to simply 'Refund'.. this allows the description to be combined with debit type descriptions simply to denote what it was applied against instead of using the generic 'applied to a patrons fine' Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137388|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 138811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138811&action=edit Bug 27779: New atomic update syntax Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137389|0 |1 is obsolete| | --- Comment #30 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 138812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138812&action=edit Bug 27779: (QA follow-up) Fix translation issue with 'against' Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137390|0 |1 is obsolete| | --- Comment #31 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 138813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138813&action=edit Bug 27779: (QA follow-up) Fix database update Don't overwrite peoples translations if they've already changed the description. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31121, 31039, 31038 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31038 [Bug 31038] Amounts in cashup summary modal no longer properly formatted https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039 [Bug 31039] Rebase issues lead to duplicate JS for cash summary modal printing https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31121 [Bug 31121] Format date range on top of cashup summary page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|31039 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31039 [Bug 31039] Rebase issues lead to duplicate JS for cash summary modal printing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|31038 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31038 [Bug 31038] Amounts in cashup summary modal no longer properly formatted -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 --- Comment #32 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Rebased and fixed up the dependency tree in Bugzilla to reflect the order things were pushed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 --- Comment #33 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 --- Comment #34 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 138849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138849&action=edit Bug 27779: (QA follow-up) Better translatability Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #35 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Hi, please review my follow-up patch and sign it if correct. The way the phrase was built is incorrect IMO, but I didn't find precedent uses of __x() in the codebase. Also, and important too: t/db_dependent/Koha/Cash/Register/Cashups.t .. # Failed test 'Returns only CASHUP actions' # at t/db_dependent/Koha/Cash/Register/Cashups.t line 66. # got: '5' # expected: '1' # Looks like you failed 1 test of 3. t/db_dependent/Koha/Cash/Register/Cashups.t .. 1/1 # Failed test 'search' # at t/db_dependent/Koha/Cash/Register/Cashups.t line 74. # Looks like you failed 1 test of 1. t/db_dependent/Koha/Cash/Register/Cashups.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/1 subtests t/db_dependent/Koha/Cash/Register/Cashup.t ... 1/3 # Failed test 'payout_grouped arrayref is correct' # at t/db_dependent/Koha/Cash/Register/Cashup.t line 226. # Structures begin differing at: # $got->[0]{related_debit} = HASH(0x55c08306c098) # $expected->[0]{related_debit} = Does not exist # Failed test 'payout_grouped arrayref is correct' # at t/db_dependent/Koha/Cash/Register/Cashup.t line 346. # Structures begin differing at: # $got->[0]{credit_type}{description} = 'Refund' # $expected->[0]{credit_type}{description} = 'A refund applied to a patrons fine' # Looks like you failed 2 tests of 29. t/db_dependent/Koha/Cash/Register/Cashup.t ... 3/3 # Failed test 'summary' # at t/db_dependent/Koha/Cash/Register/Cashup.t line 350. # Looks like you failed 1 test of 3. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #36 from Victor Grousset/tuxayo <victor@tuxayo.net> --- __x() usage looks correct 👍️ https://metacpan.org/pod/Locale::TextDomain https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395#c131 can't say for the rest of the patch: correct building of the phrase, complete and accurate usage of format_price or escape_str -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138849|0 |1 is obsolete| | --- Comment #37 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 138883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138883&action=edit Bug 27779: (QA follow-up) Better translatability Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 --- Comment #38 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Great improvement for translation.. think this was originally written long enough ago that I wasn't aware of nicer ways to do it for translators and I never really revisited how this actually worked here.. great spot Tomas! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 --- Comment #39 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 138884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138884&action=edit Bug 27779: (QA follow-up) Fix unit test I forgot to adapt the unit test for the new 'related_debit' key in the outpur from the summary method. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 --- Comment #40 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Patch attached to fix the second failing test.. I can't seem to replicate the failure of the first one however? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #41 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Follow-up pushed to master. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 Bug 27779 depends on bug 31121, which changed state. Bug 31121 Summary: Format date range on top of cashup summary page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31121 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to master |Needs documenting --- Comment #42 from Lucas Gass <lucas@bywatersolutions.com> --- Enhancement will not be backported to 22.05.x series -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|13985 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] [Omnibus] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27779 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13985 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] [Omnibus] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org