https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com | |, katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #4 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- In description of AutoLinkBiblios, there is a typo Do/Don't attempt to **utomatically** link headings when saving records in the cataloging module, obeys LinkerRelink and CatalogModuleRelink for record edits. The rest seems to work. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Just marking this as Failed QA to correct the typo. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135389|0 |1 is obsolete| | Attachment #135931|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 136807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136807&action=edit Bug 30025: Split BiblioAddsAuthorities into two sysprefs This patch adds two new sysprefs: AutoLinkBiblios AllowManualAuthorityEditing Both inherit the setting from BiblioAddsAuhtorities which is removed To test: 1 -Apply patches 2 - Update database 3 - Confirm old setting is transferred to new option 4 - Confirm you can edit authoriteis manually if AllowManualAuthorityEditing set to allow 5 - Confirm you cannot edit authorities manually if AllowManualAuthorityEditing set to don't allow 6 - Confirm a new bib is linked when AutoLinkBiblios is enabled (set AllowManualAuthorityEditing to add unlinked heading) 7 - Confirm new bib notlinked when AutoLinkBiblios is disabled 8 - Confim new bib not linked when AutoLinkBiblios is enabled, but heading doesn't match an authority and AutoCreateAuthorities is disabled 9 - Confim new bib linked to new authority when AutoLinkBiblios is enabled, but heading doesn't match an authority and AutoCreateAuthorities is enabled -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025 Michal Urban <michalurban177@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025 --- Comment #9 from Michal Urban <michalurban177@gmail.com> --- Created attachment 137236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137236&action=edit Bug 30025: Split BiblioAddsAuthorities into two sysprefs Followed Nick's testing procedure, works good This patch adds two new sysprefs: AutoLinkBiblios AllowManualAuthorityEditing Both inherit the setting from BiblioAddsAuhtorities which is removed To test: 1 -Apply patches 2 - Update database 3 - Confirm old setting is transferred to new option 4 - Confirm you can edit authoriteis manually if AllowManualAuthorityEditing set to allow 5 - Confirm you cannot edit authorities manually if AllowManualAuthorityEditing set to don't allow 6 - Confirm a new bib is linked when AutoLinkBiblios is enabled (set AllowManualAuthorityEditing to add unlinked heading) 7 - Confirm new bib notlinked when AutoLinkBiblios is disabled 8 - Confim new bib not linked when AutoLinkBiblios is enabled, but heading doesn't match an authority and AutoCreateAuthorities is disabled 9 - Confim new bib linked to new authority when AutoLinkBiblios is enabled, but heading doesn't match an authority and AutoCreateAuthorities is enabled Signed-off-by: Michal Urban <michalurban177@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Attachment #137235|0 |1 is obsolete| | --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Comment on attachment 137235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137235 Bug 30025: Split BiblioAddsAuthorities into two sysprefs Same patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Reading this description: When editing records, ALLOW catalogers to manually create new headings if needed, rather than having to reference existing authorities. It is not completely clear to me. When I enable this pref, I am able to change e.g. 100$a name of author while linked to a PERSO_NAME authority. If you are using authorities, do you really want that? But when I disable again, I can still create a new authority from the biblio form. But I am no longer able to change the 100$a. It seems that the pref description does not really tell the story. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137236|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025 --- Comment #15 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 139177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139177&action=edit Bug 30025: Split BiblioAddsAuthorities into two sysprefs This patch adds two new sysprefs: AutoLinkBiblios AllowManualAuthorityEditing Both inherit the setting from BiblioAddsAuhtorities which is removed To test: 1 -Apply patches 2 - Update database 3 - Confirm old setting is transferred to new option 4 - Confirm you can edit authoriteis manually if AllowManualAuthorityEditing set to allow 5 - Confirm you cannot edit authorities manually if AllowManualAuthorityEditing set to don't allow 6 - Confirm a new bib is linked when AutoLinkBiblios is enabled (set AllowManualAuthorityEditing to add unlinked heading) 7 - Confirm new bib notlinked when AutoLinkBiblios is disabled 8 - Confim new bib not linked when AutoLinkBiblios is enabled, but heading doesn't match an authority and AutoCreateAuthorities is disabled 9 - Confim new bib linked to new authority when AutoLinkBiblios is enabled, but heading doesn't match an authority and AutoCreateAuthorities is enabled -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025 --- Comment #17 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Hey Nick, I am a bit confused with the RequireChoosingExistingAuthority pref. My system had AutoCreateAuthorities set to "generate" and BiblioAddsAuthorities set to "allow" before I applied the patch. I applied and updated the db. Now, AutoCreateAuthorities is still on "generate", RequireChoosingExistingAuthority is set to "require" and AutoLinkBiblios is set to "Do". I would have expected RequireChoosingExistingAuthority to be set to "don't require" to have the same behaviour as before. In the AutoCreateAuthorities description, it says RequireChoosingExistingAuthority must be set to "don't require". Which makes sense, but is currently not the case. If I try to catalog something, the authority fields are not locked even though RequireChoosingExistingAuthority is set to "require". I am able to write whatever in the fields (I used 100$a) and save the record. I changed RequireChoosingExistingAuthority to "don't require" and the fields are still not locked and I am able to write whatever and save. I changed RequireChoosingExistingAuthority back to "require" and now the fields are locked. Maybe someone else can confirm/infirm to make sure it's not just me... (note: I also tried it on a sandbox to make sure; changed the original prefs to generate and allow, applied patch, RequireChoosingExistingAuthority is set to require by default but am able to write whatever I want in 100$a) Also, side note, the terminology page says we should use "authority record(s)" rather than "authority(ies)". Maybe change the RequireChoosingExistingAuthority description to "When editing records, require/don't require catalogers to reference existing authority records. If set to "don't require", catalogers can manually enter uncontrolled terms into controlled fields." I also added a period at the end of the second sentence and wrote the entire value "don't require". -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025 --- Comment #19 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Caroline Cyr La Rose from comment #17)

My system had AutoCreateAuthorities set to "generate" and BiblioAddsAuthorities set to "allow" before I applied the patch. Now RequireChoosingExistingAuthority is set to "require" and AutoLinkBiblios is set to "Do". I would have expected RequireChoosingExistingAuthority to be set to "don't require" to have the same behaviour as before.

This should be fixed

If I try to catalog something, the authority fields are not locked even though RequireChoosingExistingAuthority is set to "require". I am able to write whatever in the fields (I used 100$a) and save the record.

I do not recreate, try restarting all after the update to make sure the values are not cached? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025 --- Comment #21 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- To test: 1 -Apply patches 2 - Update database 3 - Confirm old setting is transferred to new option 4 - Confirm you can ENTER VALUES IN AUTH-CONTROLLED BIB FIELDS manually if REQUIRECHOOSINGEXISTINGAUTHORITY is set to DON'T REQUIRE 5 - Confirm you cannot ENTER VALUES IN AUTH-CONTROLLED BIB FIELDS manually if REQUIRECHOOSINGEXISTINGAUTHORITY is set to REQUIRE 6 - Confirm a new bib is linked when AutoLinkBiblios is enabled (set REQUIRECHOOSINGEXISTINGAUTHORITY to add unlinked heading) 7 - Confirm new bib notlinked when AutoLinkBiblios is disabled 8 - Confim new bib not linked when AutoLinkBiblios is enabled, but heading doesn't match an authority and AutoCreateAuthorities is disabled 9 - Confim new bib linked to new authority when AutoLinkBiblios is enabled, but heading doesn't match an authority and AutoCreateAuthorities is enabled Updated test plan to reflect syspref names. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139176|0 |1 is obsolete| | --- Comment #22 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Created attachment 139505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139505&action=edit Bug 30025: DB update Signed-off-by: AFHDubCoLib <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139399|0 |1 is obsolete| | --- Comment #24 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Created attachment 139507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139507&action=edit Bug 30025: Replace AllowManualAuthorityEditing with RequireChoosingExistingAuthority This flips the pref from an allowance to a requirement, hopefully this makes the logic here clearer Test as before, but the values for the renamed pref flipped Signed-off-by: AFHDubCoLib <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch splits the release notes| |system preference | |BiblioAddsAuthorities into | |two new system preferences | |that more clearly define | |what the settings do: | |1- | |RequireChoosingExistingAuth | |ority: this preference | |indicates whether a | |cataloger must choose from | |existing authorities, or if | |they can enter free text | |into controlled fields | |2- | |AutoLinkBiblios: this | |preference determines | |whether Koha will attempt | |to link a new record to | |existing authorities upon | |saving. In conjunction with | |the existing preference, | |AutoCreateAuthorities, | |unmatched headings will | |either be linked to a new | |authority, or remain | |uncontrolled Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025 --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Hmm.. I'm still not 100% on the new syspref name.. but it's not a deal breaker for me.. AutoLinkBiblios.. if you take just the name it sounds like it could plausibly be about other types of biblio linking.. like 773's ;p. However.. I think I'll leave that to the RM to debate.. QAing as is -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139506|0 |1 is obsolete| | --- Comment #27 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140467&action=edit Bug 30025: Split BiblioAddsAuthorities into two sysprefs This patch adds two new sysprefs: AutoLinkBiblios AllowManualAuthorityEditing Both inherit the setting from BiblioAddsAuhtorities which is removed To test: 1 -Apply patches 2 - Update database 3 - Confirm old setting is transferred to new option 4 - Confirm you can edit authoriteis manually if AllowManualAuthorityEditing set to allow 5 - Confirm you cannot edit authorities manually if AllowManualAuthorityEditing set to don't allow 6 - Confirm a new bib is linked when AutoLinkBiblios is enabled (set AllowManualAuthorityEditing to add unlinked heading) 7 - Confirm new bib notlinked when AutoLinkBiblios is disabled 8 - Confim new bib not linked when AutoLinkBiblios is enabled, but heading doesn't match an authority and AutoCreateAuthorities is disabled 9 - Confim new bib linked to new authority when AutoLinkBiblios is enabled, but heading doesn't match an authority and AutoCreateAuthorities is enabled Signed-off-by: AFHDubCoLib <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140466|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140469&action=edit Bug 30025: DB update Signed-off-by: AFHDubCoLib <andrewfh@dubcolib.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140468|0 |1 is obsolete| | --- Comment #31 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 140471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140471&action=edit Bug 30025: Replace AllowManualAuthorityEditing with RequireChoosingExistingAuthority This flips the pref from an allowance to a requirement, hopefully this makes the logic here clearer Test as before, but the values for the renamed pref flipped Signed-off-by: AFHDubCoLib <andrewfh@dubcolib.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025 --- Comment #34 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- my $biblio_adds_authorities = C4::Context->preference('BiblioAddsAuthorities'); # Do you stuffs here $dbh->do(q{ INSERT IGNORE INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `type` ) VALUES ('RequireChoosingExistingAuthority',?,NULL,'Require selecting existing authority entry in controlled fields during cataloging.','YesNo'), ('AutoLinkBiblios',?,NULL,'If enabled, link biblio to authorities on creation and edit','YesNo') },undef,($biblio_adds_authorities eq '1' ? '0' : '1', $biblio_adds_authorities)); Use of uninitialized value $biblio_adds_authorities in string eq at /usr/share/koha/installer/data/mysql/db_revs/220600047.pl line 11. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #35 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- You typoed the syspref's name! "AutoCreateAuthorites" -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025 --- Comment #37 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #36)

Why do we see the warning with the default data?

System preference 'RequireChoosingExistingAuthority' is disabled, but needs 'AutoCreateAuthorites' enabled. Otherwise catalogers can add headings that will not be linked to authorities.

This is how it was before these patches as well. Some libraries do operate in this mode - they don't want authorities created automatically. Warning introduced by bug 8301 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30025 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37575 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37575 [Bug 37575] Typo 'AutoCreateAuthorites' in about.pl -- You are receiving this mail because: You are watching all bug changes.