[Bug 7482] New: overdues report downloads without names
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7482 Bug #: 7482 Summary: overdues report downloads without names Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All URL: cgi-bin/koha/circ/overdue.pl OS/Version: All Status: NEW Severity: major Priority: P5 - low Component: Circulation AssignedTo: kyle.m.hall@gmail.com ReportedBy: nengard@gmail.com QAContact: koha.sekjal@gmail.com CC: gmcharlt@gmail.com When you click to download the overdues report it doesn't include the names but the report does print names to the screen. Names should be in the downloaded file. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7482 --- Comment #1 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 8685 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8685&action=edit Bug 7482 - overdues report downloads without names This bug is caused by the build_csv subroutine in overdue.pl using the hash key 'name' for the name field which does not exist. Fixed by adding the name field as a concatenation of firstname and surname to the loop that builds the array of hashrefs, @overduedata. It will be ignored by the Koha 'html' view of the overdue data and will only be used when exporting overdues to csv. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7482 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7482 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Kyle, I tested your patch and it works - I only think perhaps we can do it a bit better. I think having the name concatenated together is not really flexible for generating notices from this format or for sorting the data in a spreadsheet. Someone might want to generate notices using only the last name and borrowertitle. For this I propose a little different patch that gives 2 separate columns for first and last name. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7482 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 8744 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8744&action=edit Bug 7482: overdues report downloads without names This patch is an alternate patch for the bug. Instead of having one column 'name' for a concatenated first and last name it adds 2 separate columns to the exported csv file. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7482 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8685|0 |1 is obsolete| | Attachment #8744|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 8777 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8777&action=edit [SIGNED-OFF] Bug 7482: overdues report downloads without names This patch is an alternate patch for the bug. Instead of having one column 'name' for a concatenated first and last name it adds 2 separate columns to the exported csv file. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7482 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7482 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com QA Contact|koha.sekjal@gmail.com |paul.poulain@biblibre.com --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: tiny patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7482 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_6 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7482 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lzuares@collsk12.org --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 7762 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7482 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #7 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This bug will be included in the Koha 3.6.5 release. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org