[Bug 30255] New: Allow skipping "list" step for record batch modification/deletion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30255 Bug ID: 30255 Summary: Allow skipping "list" step for record batch modification/deletion Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: glasklas@gmail.com QA Contact: testopia@bugs.koha-community.org We encountered an issue using the Batch record modification/deletion-tools for a very large number of records. The "list" step where records can be optionally excluded is not relevant in our use-case and takes forever to load. This patch adds an option for skipping this step and directly enqueue the job for all specified records. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30255 --- Comment #1 from David Gustafsson <glasklas@gmail.com> --- Created attachment 131527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131527&action=edit Bug 30255: Make selection step optional for batch record del/mod Allow the user to optionally skip the record selection step in batch record deletion/modification tools and directly enqueue job for all records. 1) Create a record modification template. 2) Enter some biblionumber(s) in the batch record modification tool form, select the record modification template, the "Select records to modify" option and proceed to the next step. 3) Verify that records can be selected, proceed to the next step and verify that a job has been enqueued for the selected records. 4) Return to the batch record modification form and enter the biblionumbers(s) again. Now select "Modify all" and proceed to the next step. 5) Verify that a job has been enqueued for all records. 6) Enter some biblionumber(s) in the batch record deletion tool form, select the "Select records to delete" option and proceed to the next step. 7) Verify that records can be selected, proceed to the next step and verify that a job has been enqueued for the selected records. 8) Return to the batch record deletion form and enter the biblionumbers(s) again. Now select "Delete all" and proceed to the next step. 9) Verify that a job has been enqueued for all records. Sponsored by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30255 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30255 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |glasklas@gmail.com |ity.org | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi David, please set yourself as Assignee, when you start working on a patch for a bug, thx! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30255 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30255 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131527|0 |1 is obsolete| | --- Comment #3 from David Gustafsson <glasklas@gmail.com> --- Created attachment 151289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151289&action=edit Bug 30255: Make selection step optional for batch record del/mod Allow the user to optionally skip the record selection step in batch record deletion/modification tools and directly enqueue job for all records. 1) Create a record modification template. 2) Enter some biblionumber(s) in the batch record modification tool form, select the record modification template, the "Select records to modify" option and proceed to the next step. 3) Verify that records can be selected, proceed to the next step and verify that a job has been enqueued for the selected records. 4) Return to the batch record modification form and enter the biblionumbers(s) again. Now select "Modify all" and proceed to the next step. 5) Verify that a job has been enqueued for all records. 6) Enter some biblionumber(s) in the batch record deletion tool form, select the "Select records to delete" option and proceed to the next step. 7) Verify that records can be selected, proceed to the next step and verify that a job has been enqueued for the selected records. 8) Return to the batch record deletion form and enter the biblionumbers(s) again. Now select "Delete all" and proceed to the next step. 9) Verify that a job has been enqueued for all records. Sponsored by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30255 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #4 from David Gustafsson <glasklas@gmail.com> --- Rebased against master. Can't get my local koha docker to work with latest master though, and considering how many issues encountered will probably take a while to fix, so have not been able to test. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30255 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to David Gustafsson from comment #4)
Rebased against master. Can't get my local koha docker to work with latest master though, and considering how many issues encountered will probably take a while to fix, so have not been able to test.
It was broken this "morning", pull the new images it should be fixed now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30255 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151289|0 |1 is obsolete| | --- Comment #6 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 151382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151382&action=edit Bug 30255: Make selection step optional for batch record del/mod Allow the user to optionally skip the record selection step in batch record deletion/modification tools and directly enqueue job for all records. 1) Create a record modification template. 2) Enter some biblionumber(s) in the batch record modification tool form, select the record modification template, the "Select records to modify" option and proceed to the next step. 3) Verify that records can be selected, proceed to the next step and verify that a job has been enqueued for the selected records. 4) Return to the batch record modification form and enter the biblionumbers(s) again. Now select "Modify all" and proceed to the next step. 5) Verify that a job has been enqueued for all records. 6) Enter some biblionumber(s) in the batch record deletion tool form, select the "Select records to delete" option and proceed to the next step. 7) Verify that records can be selected, proceed to the next step and verify that a job has been enqueued for the selected records. 8) Return to the batch record deletion form and enter the biblionumbers(s) again. Now select "Delete all" and proceed to the next step. 9) Verify that a job has been enqueued for all records. Sponsored by: Gothenburg University Library Signed-off-by: Laura <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30255 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30255 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- I have the feeling that it is too easy to click select all and continue. Especially since we are used to arrive at the next selection form. So I would suggest to add at least a confirm box (in js or so) to make sure that someone knows that he is going to do something affecting the whole db. If you do not agree, please explain why this would not be needed at all :) Changing status for feedback. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30255 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30255 --- Comment #8 from David Gustafsson <glasklas@gmail.com> --- Created attachment 162547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162547&action=edit Bug 30255: Show hint there will be no confirmation when selecting "Modify all" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30255 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #9 from David Gustafsson <glasklas@gmail.com> --- Thanks for the feedback, the used will now be notified that there is no confirmation step when selecting "Modify all". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30255 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #10 from David Gustafsson <glasklas@gmail.com> --- For some reason the initial state is "Modify all" even though "Select records to modify" when loading page. Don't have time too look into right now, but will fix tomorrow. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30255 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162547|0 |1 is obsolete| | --- Comment #11 from David Gustafsson <glasklas@gmail.com> --- Created attachment 162603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162603&action=edit Bug 30255: Show hint there will be no confirmation when selecting "Modify all" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30255 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #12 from David Gustafsson <glasklas@gmail.com> --- Now fixed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30255 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |blawlor@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30255 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151382|0 |1 is obsolete| | --- Comment #13 from David Gustafsson <glasklas@gmail.com> --- Created attachment 178175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178175&action=edit Bug 30255: Make selection step optional for batch record del/mod Allow the user to optionally skip the record selection step in batch record deletion/modification tools and directly enqueue job for all records. 1) Create a record modification template. 2) Enter some biblionumber(s) in the batch record modification tool form, select the record modification template, the "Select records to modify" option and proceed to the next step. 3) Verify that records can be selected, proceed to the next step and verify that a job has been enqueued for the selected records. 4) Return to the batch record modification form and enter the biblionumbers(s) again. Now select "Modify all" and proceed to the next step. 5) Verify that a job has been enqueued for all records. 6) Enter some biblionumber(s) in the batch record deletion tool form, select the "Select records to delete" option and proceed to the next step. 7) Verify that records can be selected, proceed to the next step and verify that a job has been enqueued for the selected records. 8) Return to the batch record deletion form and enter the biblionumbers(s) again. Now select "Delete all" and proceed to the next step. 9) Verify that a job has been enqueued for all records. Sponsored by: Gothenburg University Library Signed-off-by: Laura <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30255 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162603|0 |1 is obsolete| | --- Comment #14 from David Gustafsson <glasklas@gmail.com> --- Created attachment 178176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178176&action=edit Bug 30255: Show hint there will be no confirmation when selecting "Modify all" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30255 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #15 from David Gustafsson <glasklas@gmail.com> --- Rebased aginst main. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30255 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178175|0 |1 is obsolete| | --- Comment #16 from David Gustafsson <glasklas@gmail.com> --- Created attachment 179486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179486&action=edit Bug 30255: Make selection step optional for batch record del/mod Allow the user to optionally skip the record selection step in batch record deletion/modification tools and directly enqueue job for all records. 1) Create a record modification template. 2) Enter some biblionumber(s) in the batch record modification tool form, select the record modification template, the "Select records to modify" option and proceed to the next step. 3) Verify that records can be selected, proceed to the next step and verify that a job has been enqueued for the selected records. 4) Return to the batch record modification form and enter the biblionumbers(s) again. Now select "Modify all" and proceed to the next step. 5) Verify that a job has been enqueued for all records. 6) Enter some biblionumber(s) in the batch record deletion tool form, select the "Select records to delete" option and proceed to the next step. 7) Verify that records can be selected, proceed to the next step and verify that a job has been enqueued for the selected records. 8) Return to the batch record deletion form and enter the biblionumbers(s) again. Now select "Delete all" and proceed to the next step. 9) Verify that a job has been enqueued for all records. Sponsored by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30255 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178176|0 |1 is obsolete| | --- Comment #17 from David Gustafsson <glasklas@gmail.com> --- Created attachment 179487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179487&action=edit Bug 30255: Show hint there will be no confirmation when selecting "Modify all" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30255 --- Comment #18 from David Gustafsson <glasklas@gmail.com> --- Created attachment 179488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179488&action=edit Bug 30255: Make tidy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30255 --- Comment #19 from David Gustafsson <glasklas@gmail.com> --- Rebase against main. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30255 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |roman.dolny@jezuici.pl Status|Needs Signoff |Failed QA --- Comment #20 from Roman Dolny <roman.dolny@jezuici.pl> --- Can not confirm test. P.4 - I entered list of biblionumbers in text area (cart "Enter a list of record numbers") and selected template. After clicking "Modify all" radio tab with biblionumbers has changed to "Upload a file". Clicking any of "Next step" radio sets active tab to "Upload a file". P. 9 - If there is biblionumber of non-existent record at list of numbers to delete then job is started but no records are deleted. QA script unhappy: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt FAIL forbidden patterns forbidden pattern: tab char (line 162) FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt` -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30255 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179486|0 |1 is obsolete| | --- Comment #21 from David Gustafsson <glasklas@gmail.com> --- Created attachment 189803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189803&action=edit Bug 30255: Make selection step optional for batch record del/mod Allow the user to optionally skip the record selection step in batch record deletion/modification tools and directly enqueue job for all records. 1) Create a record modification template. 2) Enter some biblionumber(s) in the batch record modification tool form, select the record modification template, the "Select records to modify" option and proceed to the next step. 3) Verify that records can be selected, proceed to the next step and verify that a job has been enqueued for the selected records. 4) Return to the batch record modification form and enter the biblionumbers(s) again. Now select "Modify all" and proceed to the next step. 5) Verify that a job has been enqueued for all records. 6) Enter some biblionumber(s) in the batch record deletion tool form, select the "Select records to delete" option and proceed to the next step. 7) Verify that records can be selected, proceed to the next step and verify that a job has been enqueued for the selected records. 8) Return to the batch record deletion form and enter the biblionumbers(s) again. Now select "Delete all" and proceed to the next step. 9) Verify that a job has been enqueued for all records. Sponsored by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30255 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179487|0 |1 is obsolete| | --- Comment #22 from David Gustafsson <glasklas@gmail.com> --- Created attachment 189804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189804&action=edit Bug 30255: Show hint there will be no confirmation when selecting "Modify all" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30255 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179488|0 |1 is obsolete| | --- Comment #23 from David Gustafsson <glasklas@gmail.com> --- Created attachment 189805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189805&action=edit Bug 30255: Make tidy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30255 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #24 from David Gustafsson <glasklas@gmail.com> --- (In reply to Roman Dolny from comment #20)
Can not confirm test.
P.4 - I entered list of biblionumbers in text area (cart "Enter a list of record numbers") and selected template. After clicking "Modify all" radio tab with biblionumbers has changed to "Upload a file". Clicking any of "Next step" radio sets active tab to "Upload a file".
P. 9 - If there is biblionumber of non-existent record at list of numbers to delete then job is started but no records are deleted.
QA script unhappy: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt FAIL forbidden patterns forbidden pattern: tab char (line 162) FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt`
Thanks for testing. I have fixed the tab issue. About the disappearance of the active tab that seems to be a behaviour that is triggered a listener on radio buttons that was not specific to the record type radio buttons. This has now been fixed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30255 --- Comment #25 from David Gustafsson <glasklas@gmail.com> --- Created attachment 189806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189806&action=edit Bug 30255: Only update tab display when changing record type -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30255 --- Comment #26 from David Gustafsson <glasklas@gmail.com> --- About the non-existent records, I initially missed that point. I will look into if it's possibly to have it check if the biblios exist, it could be that it partly defeats the purpose of the feature to do so as it was mainly meant to mitigate the problem of the verification step being very slow to load for a large number of biblios, but perhaps it will not be that slow to just check if they exist. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30255 --- Comment #27 from David Gustafsson <glasklas@gmail.com> --- After giving this some thought, as errors are also caught in the background job I think this is sufficient and avoids loading all the biblios before scheduling the job. The "Modify all" is mostly needed for very large biblionumber sets that has been generated by some script, where it should be fairly unlikely that invalid biblionumbers exists. For manual entry the "Select records to modify" can still be used and the user will be notified of missing biblios. WHat could be done is to add a special case for when numbers are missing in background job, instead of failing with "Can't call method "metadata" on an undefined value at /kohadevbox/koha/Koha/BackgroundJob/BatchUpdateBiblio.pm line 87." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30255 --- Comment #28 from David Gustafsson <glasklas@gmail.com> --- Created attachment 189824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189824&action=edit Bug 30255: Improve handling of non-existant record ids in modification/deletion background jobs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30255 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189824|0 |1 is obsolete| | --- Comment #29 from David Gustafsson <glasklas@gmail.com> --- Created attachment 189825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189825&action=edit Bug 30255: Improve handling of non-existant record ids in modification/deletion background jobs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30255 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189825|0 |1 is obsolete| | --- Comment #30 from David Gustafsson <glasklas@gmail.com> --- Created attachment 189826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189826&action=edit Bug 30255: Improve handling of non-existant record ids in modification/deletion background jobs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30255 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #31 from Roman Dolny <roman.dolny@jezuici.pl> --- Thanks for fixing reported problems. Tabs and modifications are OK, but I found one more problem with batch record deletion. Notice ISBN for recs 1-5 in KTD: 1 => 9780670026623 2 => 0812917561 3 => 0520078438 4 => 0131103709 5 => 0596001738 Delete record number 3. Then use "Batch record deletion". Enter 5 numbers (1-5) into IDs textarea, select "Delete all" and Continue. View "View detail of the enqueued job" - started, progres 2/5, info "All records have been deleted successfully!" Searching of any ISBN (1-5) gives no results. But records 4 and 5 haven't been deleted - check http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=4 - record is present. So, it seems that deleting stops on non existing record. At the same time ES index was cleared for all. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30255 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189803|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30255 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189804|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30255 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189805|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30255 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189806|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30255 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189826|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30255 --- Comment #32 from David Gustafsson <glasklas@gmail.com> --- Created attachment 208156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208156&action=edit Bug 30255: Make selection step optional for batch record del/mod Allow the user to optionally skip the record selection step in batch record deletion/modification tools and directly enqueue job for all records. 1) Create a record modification template. 2) Enter some biblionumber(s) in the batch record modification tool form, select the record modification template, the "Select records to modify" option and proceed to the next step. 3) Verify that records can be selected, proceed to the next step and verify that a job has been enqueued for the selected records. 4) Return to the batch record modification form and enter the biblionumbers(s) again. Now select "Modify all" and proceed to the next step. 5) Verify that a job has been enqueued for all records. 6) Enter some biblionumber(s) in the batch record deletion tool form, select the "Select records to delete" option and proceed to the next step. 7) Verify that records can be selected, proceed to the next step and verify that a job has been enqueued for the selected records. 8) Return to the batch record deletion form and enter the biblionumbers(s) again. Now select "Delete all" and proceed to the next step. 9) Verify that a job has been enqueued for all records. Sponsored by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30255 --- Comment #33 from David Gustafsson <glasklas@gmail.com> --- Created attachment 208157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208157&action=edit Bug 30255: Show hint there will be no confirmation when selecting "Modify all" Patch from commit 12e7477 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30255 --- Comment #34 from David Gustafsson <glasklas@gmail.com> --- Created attachment 208158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208158&action=edit Bug 30255: Make tidy Patch from commit 880be06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30255 --- Comment #35 from David Gustafsson <glasklas@gmail.com> --- Created attachment 208159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208159&action=edit Bug 30255: Only update tab display when changing record type Patch from commit 4e77d73 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30255 --- Comment #36 from David Gustafsson <glasklas@gmail.com> --- Created attachment 208160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208160&action=edit Bug 30255: Improve handling of non-existant record ids in modification/deletion background jobs Patch from commit b8283c0 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30255 --- Comment #37 from David Gustafsson <glasklas@gmail.com> --- Created attachment 208161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208161&action=edit Bug 30255: Fix issue with non existant biblios on biblio batch deletion Patch from commit 225e561 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30255 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #38 from David Gustafsson <glasklas@gmail.com> --- (In reply to Roman Dolny from comment #31)
Thanks for fixing reported problems. Tabs and modifications are OK, but I found one more problem with batch record deletion.
Notice ISBN for recs 1-5 in KTD: 1 => 9780670026623 2 => 0812917561 3 => 0520078438 4 => 0131103709 5 => 0596001738
Delete record number 3. Then use "Batch record deletion". Enter 5 numbers (1-5) into IDs textarea, select "Delete all" and Continue. View "View detail of the enqueued job" - started, progres 2/5, info "All records have been deleted successfully!" Searching of any ISBN (1-5) gives no results. But records 4 and 5 haven't been deleted - check http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=4 - record is present.
So, it seems that deleting stops on non existing record. At the same time ES index was cleared for all.
Thanks for spotting this, the issue should now be fixed and the user should also be notified for non existent biblios. I think it should work as it was a pretty minor change, but will do some testing myself. Also rebased against main. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30255 --- Comment #39 from David Gustafsson <glasklas@gmail.com> --- Yes, it seems to work. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org