[Bug 9393] New: Fix bad label and add note to circulation.pl if borrower has pending modifications
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9393 Bug ID: 9393 Summary: Fix bad label and add note to circulation.pl if borrower has pending modifications Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com * Change 'mobile phone' to 'other phone' * Run typed in captcha through uc before comparing. * Add note to circulation.pl if borrower has pending modifications -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9393 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 14594 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14594&action=edit [SIGNED-OFF] Bug 9393 - Change 'mobile phone' to 'other phone', run typed in captcha through uc before comparing. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Label changed and captcha is not case sensitive -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9393 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 14595 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14595&action=edit [SIGNED-OFF] Bug 9393 - Add note to circulation.pl if borrower has pending modifications Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> New link "patron modifications" (if there are) on the checkout page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9393 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9393 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9393 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9384 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9393 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9384 | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9393 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7067 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9393 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Patch complexity|--- |Small patch Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9393 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy@rijksmuseum.nl QA Contact| |m.de.rooy@rijksmuseum.nl --- Comment #3 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: Small changes. Look good with two notes: members/members-update.pl still lists: Primary Mobile Phone (wrong case use too) I am wondering if we can do the other phone change like this. Lots of people may have entered mobile phone numbers here, and suddenly it is just an other phone. Could be that it should move to primary phone if that is not filled or so? We probably need more community consensus for such a change. Could you raise or prove that consensus? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9393 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- (In reply to M. de Rooy from comment #3)
I am wondering if we can do the other phone change like this. Lots of people may have entered mobile phone numbers here, and suddenly it is just an other phone.
The staff client already uses the "other phone" label. This patch simply makes the two interfaces consistent. The other issue (with members-update.pl) seems like it could be handled in a separate patch and shouldn't block this one in my opinion. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9393 --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Maybe we should change all the labels to read other/mobile phone. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9393 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28913 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28913&action=edit Bug 9393: Capitalization fixes Call No. > Call no. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org