[Bug 21377] New: Variable declarations erroneously filtered
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21377 Bug ID: 21377 Summary: Variable declarations erroneously filtered Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: andrew.isherwood@ptfs-europe.com In the main ILL template file ill-requests.tt a few variable declarations that are not strings have the "html" filter applied to them, this breaks them. These filters should be removed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21377 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21377 --- Comment #1 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 79079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79079&action=edit Bug 21377: Remove erroneous "html" filter use The "html" filter that is being applied to these variable declarations is inappropriate and has been removed. To test: - Before applying the patch, on master, view the "Manage request" page for an ILL request - TEST: Observe that, apart from the "Edit request" button, the various available action buttons do not display correctly - Apply the patch - TEST: Refresh the page and observe that the buttons now display correctly -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21377 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |andrew.isherwood@ptfs-europ |ity.org |e.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21377 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |critical --- Comment #2 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Upping the priority of this as it impacts every ILL bug -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21377 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21377 --- Comment #3 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- ...including master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21377 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #4 from Julian Maurice <julian.maurice@biblibre.com> --- If variables should not be escaped, you have to be explicit about it by using the $raw filter: https://wiki.koha-community.org/wiki/Coding_Guidelines#HTML9:_filter_all_the... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21377 --- Comment #5 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 79401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79401&action=edit Bug 21377: (follow-up) Add raw filter Rather than just removing the html filter, it should be replaced with the raw filter -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21377 --- Comment #6 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Thanks for the pointer Julian, I'd completely missed the purpose of the raw filter, thanks for flagging it up! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21377 --- Comment #7 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Actually, I've just noticed that adding the raw filter breaks it (stupid browser caching when I tested it). This suggests the raw filter doesn't just pass the variable straight through and somehow breaks variables that aren't just strings. I'll do some digging... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21377 --- Comment #8 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- I'm not sure applying any filter is appropriate. I'm just assigning a variable based on another variable, there's no displaying going on. So, actually looking at what I'm doing, I'm not surprised it breaks it! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21377 --- Comment #9 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 79402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79402&action=edit Bug 21377: (follow-up) Re-remove raw filter This patch removes the raw filter that was erroneously applied, these are variable declarations, they don't need filtering. I've also simplified things by removing two of the extraneous variable declarations. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21377 --- Comment #10 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Andrew Isherwood from comment #7)
Actually, I've just noticed that adding the raw filter breaks it (stupid browser caching when I tested it). This suggests the raw filter doesn't just pass the variable straight through and somehow breaks variables that aren't just strings. I'll do some digging...
That's odd. The raw filter should return exactly what it has been given. But as theses variables are not directly displayed, it should be ok without filters. Sorry for the extra work -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21377 --- Comment #11 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- No worries :) It actually ended up with me simplifying things a little bit, so was worthwhile! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21377 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21377 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79079|0 |1 is obsolete| | Attachment #79401|0 |1 is obsolete| | Attachment #79402|0 |1 is obsolete| | --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 79437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79437&action=edit Bug 21377: Remove erroneous "html" filter use The "html" filter that is being applied to these variable declarations is inappropriate and has been removed. To test: - Before applying the patch, on master, view the "Manage request" page for an ILL request - TEST: Observe that, apart from the "Edit request" button, the various available action buttons do not display correctly - Apply the patch - TEST: Refresh the page and observe that the buttons now display correctly Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21377 --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 79438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79438&action=edit Bug 21377: (follow-up) Add raw filter Rather than just removing the html filter, it should be replaced with the raw filter Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21377 --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 79439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79439&action=edit Bug 21377: (follow-up) Re-remove raw filter This patch removes the raw filter that was erroneously applied, these are variable declarations, they don't need filtering. I've also simplified things by removing two of the extraneous variable declarations. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21377 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18589 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 [Bug 18589] Show ILLs as part of patron profile -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21377 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |julian.maurice@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21377 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79437|0 |1 is obsolete| | --- Comment #15 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 79512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79512&action=edit Bug 21377: Remove erroneous "html" filter use The "html" filter that is being applied to these variable declarations is inappropriate and has been removed. I've also simplified things by removing two of the extraneous variable declarations. To test: - Before applying the patch, on master, view the "Manage request" page for an ILL request - TEST: Observe that, apart from the "Edit request" button, the various available action buttons do not display correctly - Apply the patch - TEST: Refresh the page and observe that the buttons now display correctly Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21377 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79438|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21377 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79439|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21377 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #16 from Julian Maurice <julian.maurice@biblibre.com> --- Squashed all patches into one, to make it easier to read -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21377 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20640 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20640 [Bug 20640] Allow migrating a request between backends -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21377 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7317 CC| |martin.renvoize@ptfs-europe | |.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21377 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #17 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21377 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13618 CC| |jonathan.druart@bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 [Bug 13618] Add additional template filter methods and a filter presence test to Koha -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21377 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Dependencies/Cause not in 18.05.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21377 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|20640 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20640 [Bug 20640] Allow migrating a request between backends -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21377 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|18589 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 [Bug 18589] Show ILLs as part of patron profile -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21377 Bug 21377 depends on bug 13618, which changed state. Bug 13618 Summary: Add additional template filter methods and a filter presence test to Koha https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org