https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33322 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33322 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 148657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148657&action=edit Bug 33322: Refine click handler for suggestion batch operations The handler for suggestion batch operations looks for clicks on "button[type='submit']" which is not very specific. With the new staff interface this ends up including the header search form. This patch modifies the markup of the batch operations section of the template and makes the click handler more specific so that only the right buttons are affected. To test, apply the patch and go to Suggestions. - In the header search form, perform a catalog search. You should be able to click the submit button to successfully initiate the search. - Without checking a checkbox associated with any open suggestion, test the batch operation buttons at the bottom: - Change status - Change item type - Update manager - Delete - Archive All should trigger a JS alert, "Please select at least one suggestion" - Test each batch operation with one or more suggestions selected and confirm that the operation completes successfully. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33322 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33322 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148761|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 148925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148925&action=edit Bug 33322: Refine click handler for suggestion batch operations The handler for suggestion batch operations looks for clicks on "button[type='submit']" which is not very specific. With the new staff interface this ends up including the header search form. This patch modifies the markup of the batch operations section of the template and makes the click handler more specific so that only the right buttons are affected. To test, apply the patch and go to Suggestions. - In the header search form, perform a catalog search. You should be able to click the submit button to successfully initiate the search. - Without checking a checkbox associated with any open suggestion, test the batch operation buttons at the bottom: - Change status - Change item type - Update manager - Delete - Archive All should trigger a JS alert, "Please select at least one suggestion" - Test each batch operation with one or more suggestions selected and confirm that the operation completes successfully. Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33322 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- I got confused and thought we had a second selector, added a comment as a reminder - feel free to drop that RM -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33322 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33322 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33322 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Doesn't apply cleanly to 22.05.x, no backport. If needed please rebase. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33322 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Owen Leonard from comment #10)

The bug is a result of the new staff interface so 22.05.x shouldn't need it

Thanks Owen. -- You are receiving this mail because: You are watching all bug changes.