https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27628 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 116331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116331&action=edit Bug 27628: Fix minor HTML markup errors in OPAC search results templates This patch makes a couple of minor corrections to templates related to OPAC search results: An errant quote, and invalidly repeating ids. The #login4tags id is changed to a class, and CSS related to this id (which was not used) is removed. For consistency, the id is changed to a class on the detail page as well. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Perform a search in the OPAC. Confirm that the "Log in to add tags" link still looks correct at various browser widths. - Confirm that it works to trigger the login modal. - Validate the source of the page. There should be no errors. - View the detail page for a bibliographic record. - The "Log in to add tags" link should look correct and work correctly. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27628 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116331|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 116333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116333&action=edit Bug 27628: Fix minor HTML markup errors in OPAC search results templates This patch makes a couple of minor corrections to templates related to OPAC search results: An errant quote, and invalidly repeating ids. The #login4tags id is changed to a class, and CSS related to this id (which was not used) is removed. For consistency, the id is changed to a class on the detail page as well. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Perform a search in the OPAC. Confirm that the "Log in to add tags" link still looks correct at various browser widths. - Confirm that it works to trigger the login modal. - Validate the source of the page. There should be no errors. - View the detail page for a bibliographic record. - The "Log in to add tags" link should look correct and work correctly. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27628 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116333|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 116445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116445&action=edit Bug 27628: Fix minor HTML markup errors in OPAC search results templates This patch makes a couple of minor corrections to templates related to OPAC search results: An errant quote, and invalidly repeating ids. The #login4tags id is changed to a class, and CSS related to this id (which was not used) is removed. For consistency, the id is changed to a class on the detail page as well. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). - Perform a search in the OPAC. Confirm that the "Log in to add tags" link still looks correct at various browser widths. - Confirm that it works to trigger the login modal. - Validate the source of the page. There should be no errors. - View the detail page for a bibliographic record. - The "Log in to add tags" link should look correct and work correctly. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27628 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27628 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00 |21.05.00,20.11.03 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.03 -- You are receiving this mail because: You are watching all bug changes.