https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 64434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64434&action=edit Rancor DGI: add support for editing/searching records from import batches Add the ability to edit records in import batches -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64434|0 |1 is obsolete| | --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 66882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66882&action=edit Bug 18823: Rancor - add support for editing/searching records from import batches Add the ability to edit records in import batches To test: 1 - Open the advanced cataloging editor 2 - Note you have options for save targets 3 - Save record in various formats and to a 'batch' 4 - Manage the batch and note your new record is included -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 66884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66884&action=edit Bug 18823: Rancor - Allow searching of batches to be enabled/disabled To test: 1 - Open advanced cataloging editor (rancor) 2 - Under settings select 'import batches' 3 - Select some branches for search and some as save targets 4 - Verify the options work as expected (Note: empty batches cannot be searched) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19265 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19265 [Bug 19265] Advanced Editor - Rancor - Add ability to export selected records from and import records into an import batch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19269 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19269 [Bug 19269] Advanced Editor - Rancor - Add ability to search batches by lccn and pubdate -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 77241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77241&action=edit Bug 18823: Rancor - Improvements to import batch searching Refactoring and improving feedback -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 77243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77243&action=edit Bug 18823: Rancor - Save overriding warnings Allow saving of record even if invalid To test: Open/create a record with missing mandatory fields Click save Record is not saved and errors are listed Choose the dropdown under the save button and select 'Save overriding warnings' Note record is saved -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|18822 |19263 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18822 [Bug 18822] Advanced editor - Rancor - searching broken under Elasticsearch https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19263 [Bug 19263] Advanced Editor - Rancor - Add auto control number (001) widget -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 --- Comment #14 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 79241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79241&action=edit Bug 18823: Rancor - Improvements to import batch searching Refactoring and improving feedback -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 --- Comment #16 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 79243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79243&action=edit Bug 18823: Rancor - Save overriding warnings Allow saving of record even if invalid To test: Open/create a record with missing mandatory fields Click save Record is not saved and errors are listed Choose the dropdown under the save button and select 'Save overriding warnings' Note record is saved -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Cori Lynn Arnold` <carnold@dgiinc.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |carnold@dgiinc.com --- Comment #18 from Cori Lynn Arnold` <carnold@dgiinc.com> --- Tried testing this on bywater sandbox. Steps (Browser Chrome): a. Enabled EnableAdvancedCatalogingEditor in Administration interface b. Went to Cataloging c. Clicked on "Advanced editor" button d. Browser hangs with "Loading, please wait..." Repeated on Firefox Repeated on IE Back to Chrome: a. Disabled EnableAdvancedCatalogingEditor in Administration interface b. Went to Cataloging c. Clicked on "New Record Button", selected "Default Framework" d. Browser doesn't hang. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 --- Comment #19 from Cori Lynn Arnold <carnold@dgiinc.com> --- Created attachment 80519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80519&action=edit Bug 18823: Refactor and fix issue with updating import batch record Rebased code with changes from Bug 19263 Added missing function from previous patch to make saves of edits to import batches Changed setting for import batches created by Rancor to 'staged' as there is no mechanism to change them from 'staging' Changes to make batch names work with single quotes "Client's Batch" Changes to fix QA tool issues (i.e. bootstrap button & undef) Tests: 1) Open advanced cataloging editor 2) Under settings select 'Import Batches' 3) Create a few import batches, some for searching and some as targets (and some both) 3.a) not that import batches for saving appear on the left side as targets to save 4) Search for a bibliographic record, make changes and apply to an import batch 5) Search for the bibliographic record in the import batch 6) Make changes and verify the changes are applied (either through searching again, or through the Staged MARC management in Tools) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Cori Lynn Arnold <carnold@dgiinc.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80536|0 |1 is obsolete| | --- Comment #21 from Cori Lynn Arnold <carnold@dgiinc.com> --- Comment on attachment 80536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80536 Bug 18823: Fix patch issues This didn't work. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Cori Lynn Arnold <carnold@dgiinc.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79241|0 |1 is obsolete| | Attachment #79242|0 |1 is obsolete| | --- Comment #23 from Cori Lynn Arnold <carnold@dgiinc.com> --- Created attachment 80606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80606&action=edit Bug 1883: Improvements to import batch searching and enabled/disabled Rebase. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Cori Lynn Arnold <carnold@dgiinc.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79244|0 |1 is obsolete| | Attachment #80519|0 |1 is obsolete| | --- Comment #25 from Cori Lynn Arnold <carnold@dgiinc.com> --- Created attachment 80613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80613&action=edit Bug 18823: Rancor - improve batch search/update ISBN handling Rebase -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Cori Lynn Arnold <carnold@dgiinc.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80606|0 |1 is obsolete| | --- Comment #27 from Cori Lynn Arnold <carnold@dgiinc.com> --- Created attachment 80627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80627&action=edit Bug 18823: Improvements to import batch searching and enabled/disabled Rebase. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Cori Lynn Arnold <carnold@dgiinc.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80613|0 |1 is obsolete| | --- Comment #29 from Cori Lynn Arnold <carnold@dgiinc.com> --- Created attachment 80637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80637&action=edit Bug 18823: Rancor - improve batch search/update ISBN handling Rebase -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Cori Lynn Arnold <carnold@dgiinc.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Cori Lynn Arnold <carnold@dgiinc.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80651|0 |1 is obsolete| | --- Comment #32 from Cori Lynn Arnold <carnold@dgiinc.com> --- Created attachment 80861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80861&action=edit Bug 18823: Search improvements Search can now find titles and keywords with single quotes i.e. "Time Traveler's Wife" in import batches. Tests: 1) Open advanced cataloging edtior 2) Under settings select 'Import Batches' 3) Create a few import batches, some for searching and some as targets (and some both) 3.a) note that import batches for saving appear on the left side as targets to save 4) Search for a bibliographic record, make changes and apply to an import batch 5) Search for the bibliographic record in the import batch by author, title, isbn 6) Make changes to the import batch records and verify the changes are applied (either through searching again, or through the Staged MARC management page in Tools) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Cori Lynn Arnold <carnold@dgiinc.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80866|0 |1 is obsolete| | --- Comment #34 from Cori Lynn Arnold <carnold@dgiinc.com> --- Created attachment 80868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80868&action=edit Bug 18823: Rancor - add support for editing/searching records rebase. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 --- Comment #36 from Cori Lynn Arnold <carnold@dgiinc.com> --- Created attachment 80870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80870&action=edit Bug 18823: Improvements to import batch searching and enabled/disabled Rebase. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 --- Comment #38 from Cori Lynn Arnold <carnold@dgiinc.com> --- Created attachment 80872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80872&action=edit Bug 18823: Rancor - improve batch search/update ISBN handling Rebase -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #40 from Christopher Brannon <cbrannon@cdalibrary.org> --- Cori Lynn, Minor requests. I am not a cataloger. I'd be happy to test, but a couple things I request: Write the test as basic and complete as you can. The more detail you can give, the more people are able to participate and follow up. I don't know off the top of my head how to open the advanced editor without some research. If you could include the steps to get there, that would be great. This is my personal bias, but anytime you can include steps that show behavior before, and then after the patch is applied, is a plus. We don't always notice what is different, especially if we don't hang out in those areas a lot. These are just minor suggestions. If I can figure out how to get there, I will certainly test what I can. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 --- Comment #42 from Cori Lynn Arnold <carnold@dgiinc.com> --- Created attachment 80947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80947&action=edit Testing Advanced Cataloging with Import Batches Testing document for 18823 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 --- Comment #44 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Cori Lynn Arnold from comment #43)

Thanks for the feedback, Christopher Brannon! I added a testing document that goes through a lot of testing steps, but feel free to color outside the lines as well.

Thanks for the doc! I'm a little confused on step 4 under the patch. Where do I go to click on import? I see export buttons, but no import. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Bug 18823 depends on bug 19263, which changed state. Bug 19263 Summary: Advanced Editor - Rancor - Add auto control number (001) widget https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19263 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80870|0 |1 is obsolete| | --- Comment #47 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 85356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85356&action=edit Bug 18823: Improvements to import batch searching and enabled/disabled Rebase. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80872|0 |1 is obsolete| | --- Comment #49 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 85358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85358&action=edit Bug 18823: Rancor - improve batch search/update ISBN handling Rebase -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud@biblibre.com --- Comment #51 from Alex Arnaud <alex.arnaud@biblibre.com> --- Hello Cori, I have rebased this patches. Thanks for the testing documentation, very useful! I have some questions: 1) when i clean an import batch created in Rancor from Staged MARC management page, it disappears from import batches table in advanced editor. Wanted behavior ? 2) Searchable/Save target properties are lost after leaving the advanced editor. Also wanted behavior ? I can patch this if needed. Tell me your opinion. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 --- Comment #52 from Cori Lynn Arnold <carnold@dgiinc.com> --- Created attachment 85376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85376&action=edit Save To Box Issue Save to box not working as expected -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Cori Lynn Arnold <carnold@dgiinc.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #54 from Cori Lynn Arnold <carnold@dgiinc.com> --- As discussed in previous comments. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 --- Comment #56 from Cori Lynn Arnold <carnold@dgiinc.com> --- As discussed over IRC: 1. A batch should never be automatically unchecked by the system. It should remain checked through the whole process until a cataloger unchecks the batch. 2. If a batch and a specific ID is checked, then saving the record will overwrite the record with that ID, it will not duplicate the record. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 --- Comment #58 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 85720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85720&action=edit Bug 18823: Check Batch and Record save target when importing a record from a batch. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Cori Lynn Arnold <carnold@dgiinc.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #59 from Cori Lynn Arnold <carnold@dgiinc.com> --- In order to test this I clicked around a bunch everything looked good. Then went through a “normal” cataloging process for our company and found an issue. 1. Start by importing a batch of records. [We do some pre-processing here that does 75% of the copy cataloging pieces automagically] So I went to Tools->Stage records for import 2. Once this is complete, I go to Settings->Import batches and see that the batch shows up in “Import Batches” Yay! 3. I select this batch to be searchable, but not a save target. I want my records to go into FAW (the client that I’m cataloging for) https://paste.pics/fb6948f2a662bd927011008d40993c0c 4. I search for the record I want to catalog for FAW. Yay! It comes up! So I hit “Import” 5. I make the required changes *Problem* Though the batch is set as _unchecked_ for “Save Target” it is automatically selected for “Save to:” https://paste.pics/fc0f4afded30ad1d83ff94188578742e -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Cori Lynn Arnold <carnold@dgiinc.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #62 from Cori Lynn Arnold <carnold@dgiinc.com> --- Interface fails when updating an existing record. Steps: 1. Create an import batch named "18823 Testing" using the Advanced editor under Settings -> Import Batches. Make the import batch searchable and a save target. 2. Create 2 records. One with 001 as faw00012345, the other with 001 as faw00054321 ; 245 as "Penultimate Test" for one, "Antonomasia Test" for the other. Save both to "18823 Testing" import batch. 3. Realize that you are only human and made a mistake on the first record in the title. Now you want the title of the first record to be "Pen Ultimate Test" Search for the first record using the keyword search box and enter "Penultimate Test" and having your "18823 Testing" checked in the search. Find the record you created in step 2. Select "Import" (or "Substitute" at this point I do not know the difference??) 4. Update the title to "Pen Ultimate Test" 5. Hit "Save" Error: https://paste.pics/0bf7411510f2bb31b560da96291a3766 Control Number Conflict "Cannot Save" Expected: System to recognize that we imported the record from the same batch we are updating and to override the old record with the new one with the title changed. Catalogers (like developers) must be able to fix mistakes :) While I understand the control number conflict, if one is searching from the batch of which we are saving then the save should over-ride the record. If we use the "Save overriding warnings" option, then the record is duplicated in the import batch. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85785|0 |1 is obsolete| | --- Comment #64 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 85828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85828&action=edit Bug 18823: Don't show/check batch that are not enabled for saved targets -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Cori Lynn Arnold <carnold@dgiinc.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #65 from Cori Lynn Arnold <carnold@dgiinc.com> --- Can't search the import batch I just created and added two records to. Steps to reproduce: 1. Create a new import batch (Settings->Import batches...) called "New Batch" 2. Make "New Batch" searchable and a save target https://paste.pics/300ea164128d55e87c65652f1abd6223 3. Create 2 records. One with 001 as faw00012345, the other with 001 as faw00054321 ; 245 as "Penultimate Test" for one, "Antonomasia Test" for the other. Save both to "New Batch" import batch. 4. Search using the left hand search area for "Penultimate Test" in keywords Expected: "New Batch" is listed as a searchable target. Result: "New Batch" is not listed as a searchable target. https://paste.pics/33d5257511e53ee1d46722c1b1a8cece -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 --- Comment #68 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 86174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86174&action=edit Bug 21728: (RM follow-up) Add 'Reserve Fee' for new installs Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: cori <corilynn.arnold@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85356|0 |1 is obsolete| | --- Comment #70 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 86176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86176&action=edit Bug 18823: Improvements to import batch searching and enabled/disabled Rebase. Signed-off-by: cori <corilynn.arnold@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85358|0 |1 is obsolete| | --- Comment #72 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 86178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86178&action=edit Bug 18823: Rancor - improve batch search/update ISBN handling Rebase Signed-off-by: cori <corilynn.arnold@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85719|0 |1 is obsolete| | --- Comment #74 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 86180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86180&action=edit Bug 18823: Keep Batch selected and remove record backends when needed. Signed-off-by: cori <corilynn.arnold@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85828|0 |1 is obsolete| | --- Comment #76 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 86182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86182&action=edit Bug 18823: Don't show/check batch that are not enabled for saved targets Signed-off-by: cori <corilynn.arnold@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Cori Lynn Arnold <carnold@dgiinc.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #78 from Cori Lynn Arnold <carnold@dgiinc.com> --- Looks great! Worked with it for an hour cataloging :) -cori lynn -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86174|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 --- Comment #79 from Alex Arnaud <alex.arnaud@biblibre.com> --- Bug 21720: Update Tests Bug 21728: (RM follow-up) Add 'Reserve Fee' for new installs Make these two patches obsolete since they're not part of this enhancement. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86176|0 |1 is obsolete| | --- Comment #81 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 86792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86792&action=edit Bug 18823: Improvements to import batch searching and enabled/disabled Rebase. Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86178|0 |1 is obsolete| | --- Comment #83 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 86794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86794&action=edit Bug 18823: Rancor - improve batch search/update ISBN handling Rebase Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86180|0 |1 is obsolete| | --- Comment #85 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 86796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86796&action=edit Bug 18823: Keep Batch selected and remove record backends when needed. Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86182|0 |1 is obsolete| | --- Comment #87 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 86798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86798&action=edit Bug 18823: Don't show/check batch that are not enabled for saved targets Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Signed Off |Failed QA --- Comment #89 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Starting with a first code review and the tests. All in all this is quite a MASSSIVE patch. 12 files changed, 992 insertions(+), 156 deletions(-) I can't shake the feeling that this should have been broken up into smaller patches in a dependency tree. 1) QA test tools a) FAIL koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc FAIL filters missing_filter at line 807 ( Preferences.Save( [% loggelogged_in_user.borrowernumber %] );) missing_filter at line 45 ( name: _("Batch: ") + `[% batch.file_name %]`,) missing_filter at line 44 ( 'batch:[% batch.import_batch_id %]': {) missing_filter at line 327 ( [% batch.import_batch_id %]: {) missing_filter at line 328 ( 'name': `[% batch.file_name %]`,) b) FAIL C4/Biblio.pm FAIL pod coverage POD is missing for 'UpdateMarcTimestamp' 2) Unit tests There are no unit tests included in this patch, but it touches a lot of methods: a) New method C4/Biblio Upate005Time is untested - I can see it's just a copy of existing code tho. b) New method C4/ImportBatch _get_import_record_timestamp is untested and should have POD. c) Changes to existing methods are not accompanied by tests: - _update_import_record_marc - _add_biblio_fields c) Changes to Koha/MetaSearcher are untested. d) New svc/cataloguing/import_batches is untested. e) New svc/cataloguing/metasearch 3) Question +use C4::Koha qw(); # Purely for GetNormalizedISBN Why not list the method inside qw if only GetNormalizedISBN is needed? 4) Can you point me to the most current and complete test plan? (including Controlnumber handling etc.) 5) Some first notes from GUI testing a) I am not completely sold on the placement of the 'Save to' box. It already looks a bit 'squashed' and it will look worse in other languages (being German I know our words for things tend to be longer) b) Main issue: Should we not preselect something or at least remember what was selected? I think 'Save to catalog' would probably the most common for normal cataloguing. Once saved for the first time, both: 'new record' and 'catalog record #' are checked. I'd expect it to create a duplicate in that case. (blocker for me - please check) c) When a record is saved, the message appears no longer centered, but far to the right. I think it's easier to miss this way. d) The modal for 'Import batches...' covers the whole screen. Changing something there will take immediate effect. I wonder if a close button would help usability or just making the modal a little smaller. e) Why is it 'Save as MARC' but 'New MARCXML'? e) When checking both, only the MARCXML is saved. I think maybe multi-select should not allowed or should be handled? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86791|0 |1 is obsolete| | --- Comment #90 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 88417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88417&action=edit Bug 18823: Rancor - add support for editing/searching records rebase. Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86793|0 |1 is obsolete| | --- Comment #92 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 88419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88419&action=edit Bug 18823: Rancor - save override warnings Rebase. Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86795|0 |1 is obsolete| | --- Comment #94 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 88421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88421&action=edit Bug 18823: Search improvements Search can now find titles and keywords with single quotes i.e. "Time Traveler's Wife" in import batches. Tests: 1) Open advanced cataloging edtior 2) Under settings select 'Import Batches' 3) Create a few import batches, some for searching and some as targets (and some both) 3.a) note that import batches for saving appear on the left side as targets to save 4) Search for a bibliographic record, make changes and apply to an import batch 5) Search for the bibliographic record in the import batch by author, title, isbn 6) Make changes to the import batch records and verify the changes are applied (either through searching again, or through the Staged MARC management page in Tools) Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86797|0 |1 is obsolete| | --- Comment #96 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 88423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88423&action=edit Bug 18823: Check Batch and Record save target when importing a record from a batch. Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86799|0 |1 is obsolete| | --- Comment #98 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 88425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88425&action=edit Bug 18823: Fix targets registering Signed-off-by: cori <corilynn.arnold@gmail.com> ebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 --- Comment #100 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 88427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88427&action=edit Bug 18823: add unit tests for added/changed subroutines -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 --- Comment #102 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 88429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88429&action=edit Bug 18823: center sucess saving message -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 --- Comment #104 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 88431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88431&action=edit Bug 18823: Rename 'New MARCXML' to 'Save as MARCXML' and it can't be selected along with MARC -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #106 from Alex Arnaud <alex.arnaud@biblibre.com> --- (In reply to Katrin Fischer from comment #89)

2) Unit tests

c) Changes to Koha/MetaSearcher are untested. d) New svc/cataloguing/import_batches is untested. e) New svc/cataloguing/metasearch

As far as i know, we don't test scripts in svc (currently 0 test). I'm not aware of a valid method to do that. About Koha/MetaSearcher. I started writing units tests but i encountered a problem: The method in charge of searching use forked process. That make the db context set in UT lost. The only way i found to make it works: commit all db changes. But this is quite unsafe.

5) Some first notes from GUI testing

a) I am not completely sold on the placement of the 'Save to' box. It already looks a bit 'squashed' and it will look worse in other languages (being German I know our words for things tend to be longer)

I also have long batch names. But i believe text is properly handle with line returns. And i think this box positioning/sizing is consistent with the search one. Maybe you/someone can do a better proposal I think all the rest is fixed or improved. Put this back to needs signoff since there is some behavior changes -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88418|0 |1 is obsolete| | --- Comment #108 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 88494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88494&action=edit Bug 18823: Improvements to import batch searching and enabled/disabled Rebase. Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88420|0 |1 is obsolete| | --- Comment #110 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 88496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88496&action=edit Bug 18823: Rancor - improve batch search/update ISBN handling Rebase Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88422|0 |1 is obsolete| | --- Comment #112 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 88498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88498&action=edit Bug 18823: Keep Batch selected and remove record backends when needed. Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88424|0 |1 is obsolete| | --- Comment #114 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 88500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88500&action=edit Bug 18823: Don't show/check batch that are not enabled for saved targets Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88426|0 |1 is obsolete| | --- Comment #116 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 88502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88502&action=edit Bug 18823: Add pod for UpdateMarcTimestamp and template filters -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88428|0 |1 is obsolete| | --- Comment #118 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 88504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88504&action=edit Bug 18823: C4::Koha::GetNormalizedISBN loading -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88430|0 |1 is obsolete| | --- Comment #120 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 88506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88506&action=edit Bug 18823: reduce batches management modal -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88432|0 |1 is obsolete| | --- Comment #122 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 88508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88508&action=edit Bug 18823: Don't keep record number checked after saving -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 --- Comment #124 from Alex Arnaud <alex.arnaud@biblibre.com> --- This is a consequence of removing record number (the last patch). Katrin said: "Once saved for the first time, both: 'new record' and 'catalog record #' are checked. I'd expect it to create a duplicate in that case." But now i see the benefit of keeping it. After saving a record in a batch, i think there is 2 options: 1) Update the record because you made a mistake - let the "Batch: batch_name" checked, - let the "batch_name: #id" checked So that the record is updated in the batch. 2) Save a new record in the same batch from the already saved record - make a few changes on record - let the "Batch: batch_name" checked, - uncheck "batch_name: #id" New record saved So, let the record number seems to fix the problem. Are you ok with that? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88508|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Cori Lynn Arnold <carnold@dgiinc.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #126 from Cori Lynn Arnold <carnold@dgiinc.com> --- Failed to apply: Applying: Bug 18823: Rancor - add support for editing/searching records Using index info to reconstruct a base tree... M C4/Biblio.pm M cataloguing/editor.pl M koha-tmpl/intranet-tmpl/prog/css/cateditor.css M koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc M koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/editor.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/editor.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/editor.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc Auto-merging koha-tmpl/intranet-tmpl/prog/css/cateditor.css CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/css/cateditor.css Auto-merging cataloguing/editor.pl Auto-merging C4/Biblio.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 18823: Rancor - add support for editing/searching records The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-18823-Rancor---add-support-for-editingsearchin-0J4EtP.patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88493|0 |1 is obsolete| | --- Comment #127 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 91205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91205&action=edit Bug 18823: Rancor - add support for editing/searching records rebase. Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88495|0 |1 is obsolete| | --- Comment #129 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 91207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91207&action=edit Bug 18823: Rancor - save override warnings Rebase. Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88497|0 |1 is obsolete| | --- Comment #131 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 91209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91209&action=edit Bug 18823: Search improvements Search can now find titles and keywords with single quotes i.e. "Time Traveler's Wife" in import batches. Tests: 1) Open advanced cataloging edtior 2) Under settings select 'Import Batches' 3) Create a few import batches, some for searching and some as targets (and some both) 3.a) note that import batches for saving appear on the left side as targets to save 4) Search for a bibliographic record, make changes and apply to an import batch 5) Search for the bibliographic record in the import batch by author, title, isbn 6) Make changes to the import batch records and verify the changes are applied (either through searching again, or through the Staged MARC management page in Tools) Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88499|0 |1 is obsolete| | --- Comment #133 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 91211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91211&action=edit Bug 18823: Check Batch and Record save target when importing a record from a batch. Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88501|0 |1 is obsolete| | --- Comment #135 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 91213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91213&action=edit Bug 18823: Fix targets registering Signed-off-by: cori <corilynn.arnold@gmail.com> ebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88503|0 |1 is obsolete| | --- Comment #137 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 91215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91215&action=edit Bug 18823: add unit tests for added/changed subroutines -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88505|0 |1 is obsolete| | --- Comment #139 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 91217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91217&action=edit Bug 18823: center sucess saving message -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88507|0 |1 is obsolete| | --- Comment #141 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 91219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91219&action=edit Bug 18823: Rename 'New MARCXML' to 'Save as MARCXML' and it can't be selected along with MARC -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Cori Lynn Arnold <carnold@dgiinc.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #142 from Cori Lynn Arnold <carnold@dgiinc.com> --- Patches apply, but going to the advanced editor causes a javascript error that prevents the page from fully loading: Uncaught ReferenceError: insert_copyright is not defined at marc-editor.js:140 at Object.execCb (require_19.0600010.js:29) at X.check (require_19.0600010.js:18) at X.<anonymous> (require_19.0600010.js:23) at require_19.0600010.js:8 at require_19.0600010.js:23 at y (require_19.0600010.js:7) at X.emit (require_19.0600010.js:23) at X.check (require_19.0600010.js:19) at X.<anonymous> (require_19.0600010.js:23) https://snag.gy/4eWg7B.jpg using Chrome browser. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 --- Comment #144 from Alex Arnaud <alex.arnaud@biblibre.com> --- That last error seems to be introduced by Bug 16232 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23436 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23436 [Bug 23436] Undefined named save backend in advanced editor -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 --- Comment #146 from Cori Lynn Arnold <carnold@dgiinc.com> --- Created attachment 92051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92051&action=edit Bug 11529: (RM follow-up) Add WHILE to directive list The QA tools don't current recognise the WHILE directive used in this template update. This patch adds the keyword to the list of recognised directives and thus allows through unfiltered variables during QA runs. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92051|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Cori Lynn Arnold <carnold@dgiinc.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92120|0 |1 is obsolete| | --- Comment #149 from Cori Lynn Arnold <carnold@dgiinc.com> --- Created attachment 92124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92124&action=edit Bug 18823: Fix save button size and show searchable backends only in search result Signed-off-by: Cori Lynn Arnold <carnold@dgiinc.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91205|0 |1 is obsolete| | --- Comment #151 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 94436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94436&action=edit Bug 18823: Rancor - add support for editing/searching records rebase. Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91207|0 |1 is obsolete| | --- Comment #153 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 94438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94438&action=edit Bug 18823: Rancor - save override warnings Rebase. Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91209|0 |1 is obsolete| | --- Comment #155 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 94440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94440&action=edit Bug 18823: Search improvements Search can now find titles and keywords with single quotes i.e. "Time Traveler's Wife" in import batches. Tests: 1) Open advanced cataloging edtior 2) Under settings select 'Import Batches' 3) Create a few import batches, some for searching and some as targets (and some both) 3.a) note that import batches for saving appear on the left side as targets to save 4) Search for a bibliographic record, make changes and apply to an import batch 5) Search for the bibliographic record in the import batch by author, title, isbn 6) Make changes to the import batch records and verify the changes are applied (either through searching again, or through the Staged MARC management page in Tools) Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91211|0 |1 is obsolete| | --- Comment #157 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 94442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94442&action=edit Bug 18823: Check Batch and Record save target when importing a record from a batch. Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91213|0 |1 is obsolete| | --- Comment #159 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 94444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94444&action=edit Bug 18823: Fix targets registering Signed-off-by: cori <corilynn.arnold@gmail.com> ebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91215|0 |1 is obsolete| | --- Comment #161 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 94446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94446&action=edit Bug 18823: add unit tests for added/changed subroutines -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91217|0 |1 is obsolete| | --- Comment #163 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 94448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94448&action=edit Bug 18823: center sucess saving message -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91219|0 |1 is obsolete| | --- Comment #165 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 94450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94450&action=edit Bug 18823: Rename 'New MARCXML' to 'Save as MARCXML' and it can't be selected along with MARC -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 --- Comment #167 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 94452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94452&action=edit Bug 18823: typo on loggelogged_in_user -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 --- Comment #170 from Cori Lynn Arnold <carnold@dgiinc.com> --- As discussed on IRC, the use cases are that a cataloger needs to be able to save, edit, and delete records in an import batch. We (at DGI) are not sticklers on the interface or how that gets handled by the GUI, but we *need* the feature to work, and work soon. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Cori Lynn Arnold <carnold@dgiinc.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Failed QA --- Comment #172 from Cori Lynn Arnold <carnold@dgiinc.com> --- Alex, Please address Nick's comment 171 re: "Edit as new (Duplicate)" I think it's fine if we just label it that. Also, please make sure to provide a thorough test plan before sending it back to "Needs Sign Off" Thanks! -cori lynn -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94437|0 |1 is obsolete| | --- Comment #174 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 99093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99093&action=edit Bug 18823: Improvements to import batch searching and enabled/disabled Rebase. Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94439|0 |1 is obsolete| | --- Comment #176 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 99095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99095&action=edit Bug 18823: Rancor - improve batch search/update ISBN handling Rebase Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94441|0 |1 is obsolete| | --- Comment #178 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 99097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99097&action=edit Bug 18823: Keep Batch selected and remove record backends when needed. Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94443|0 |1 is obsolete| | --- Comment #180 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 99099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99099&action=edit Bug 18823: Don't show/check batch that are not enabled for saved targets Signed-off-by: cori <corilynn.arnold@gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94445|0 |1 is obsolete| | --- Comment #182 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 99101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99101&action=edit Bug 18823: Add pod for UpdateMarcTimestamp and template filters -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94447|0 |1 is obsolete| | --- Comment #184 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 99103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99103&action=edit Bug 18823: C4::Koha::GetNormalizedISBN loading -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94449|0 |1 is obsolete| | --- Comment #186 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 99105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99105&action=edit Bug 18823: reduce batches management modal -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94451|0 |1 is obsolete| | --- Comment #188 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 99107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99107&action=edit Bug 18823: Fix save button size and show searchable backends only in search result Signed-off-by: Cori Lynn Arnold <carnold@dgiinc.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 --- Comment #190 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 99109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99109&action=edit Bug 18823: combine Duplicate and New Catalog Record save targets -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com Status|Needs Signoff |Patch doesn't apply --- Comment #192 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- I wasn't able to apply these to master. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Heather <flyingendpaper@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |flyingendpaper@gmail.com -- You are receiving this mail because: You are watching all bug changes.