[Bug 16186] New: t/db_dependent/Circulation_Issuingrule.t is failing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16186 Bug ID: 16186 Summary: t/db_dependent/Circulation_Issuingrule.t is failing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: mtompset@hotmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Bug 5786 changed the query for GetIssuingRules to SELECT *, which means if columns are added to the DB, this breaks. Add missing column(s) into the issuing rules hashes in the test. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16186 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |mtompset@hotmail.com |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16186 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16186 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16186 --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 49794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49794&action=edit Bug 16186: t/db_dependent/Circulation_Issuingrule.t is failing Went a little beyond scope and added missing fields, even though tests weren't failing. TEST PLAN --------- 1) prove t/db_dependent/Circulation_Issuingrule.t -- fails 2) apply patch 3) prove t/db_dependent/Circulation_Issuingrule.t -- pass 4) git diff origin/master -- t/db_dependent/Circulation_Issuingrule.t -- notice that bug 5876 and bug 9129 combined to cause this 5) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16186 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16186 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49794|0 |1 is obsolete| | --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 49796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49796&action=edit Bug 16186: t/db_dependent/Circulation_Issuingrule.t is failing TEST PLAN --------- 1) prove t/db_dependent/Circulation_Issuingrule.t -- fails 2) apply patch 3) prove t/db_dependent/Circulation_Issuingrule.t -- pass 4) git diff origin/master -- t/db_dependent/Circulation_Issuingrule.t -- notice that bug 5876 and bug 9129 combined to cause this 5) run koha qa test tools Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16186 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Signed Off |Passed QA --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Trivial fix for the tests. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16186 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #4 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16186 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |julian.maurice@biblibre.com Resolution|--- |FIXED --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Not needed in stable versions, status changed to RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org