[Bug 13030] New: Show waiting hold expiration date for waiting holds on circulation.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13030 Bug ID: 13030 Summary: Show waiting hold expiration date for waiting holds on circulation.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com We should show the date a waiting hold is set to expire for each hold in the list of waiting holds in circulation.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13030 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12892 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13030 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13030 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13030 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32012 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32012&action=edit Bug 13030 - Show waiting hold expiration date for waiting holds on circulation.pl We should show the date a waiting hold is set to expire for each hold in the list of waiting holds in circulation.pl Test Plan: 1) Apply this patch 2) Find a waiting hold for a patron, browser to circulation.pl for that patron 3) Set system preference ReservesMaxPickUpDelay to 5 4) Refresh circulation.pl, note the waiting holds now display a "waiting until" part with the waiting date plus 5 days 5) Set system preference ReservesMaxPickUpDelay to 0 ( or empty string ) 6) Refresh circulation.pl, note the waiting hols no longer have a "waiting until" line. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13030 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32012|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32070 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32070&action=edit Bug 13030 - Show waiting hold expiration date for waiting holds on circulation.pl We should show the date a waiting hold is set to expire for each hold in the list of waiting holds in circulation.pl Test Plan: 1) Apply this patch 2) Find a waiting hold for a patron, browser to circulation.pl for that patron 3) Set system preference ReservesMaxPickUpDelay to 5 4) Refresh circulation.pl, note the waiting holds now display a "waiting until" part with the waiting date plus 5 days 5) Set system preference ReservesMaxPickUpDelay to 0 ( or empty string ) 6) Refresh circulation.pl, note the waiting hols no longer have a "waiting until" line. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13030 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #3 from Frédéric Demians <frederic@tamil.fr> --- I'm unable to apply this patch to my devel Git repository, with a very strange error message: fatal: sha1 information is lacking or useless (Koha/Hold.pm). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13030 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13030 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Frédéric Demians from comment #3)
fatal: sha1 information is lacking or useless (Koha/Hold.pm).
This usually means you didn't apply a dependent patch first. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13030 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13030 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13030 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32070|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 32935 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32935&action=edit [SIGNED-OFF] Bug 13030 - Show waiting hold expiration date for waiting holds on circulation.pl We should show the date a waiting hold is set to expire for each hold in the list of waiting holds in circulation.pl Test Plan: 1) Apply this patch 2) Find a waiting hold for a patron, browser to circulation.pl for that patron 3) Set system preference ReservesMaxPickUpDelay to 5 4) Refresh circulation.pl, note the waiting holds now display a "waiting until" part with the waiting date plus 5 days 5) Set system preference ReservesMaxPickUpDelay to 0 ( or empty string ) 6) Refresh circulation.pl, note the waiting hols no longer have a "waiting until" line. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Followed test plan successfully. Automated tests successful. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13030 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Needs 12892 and 13019. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13030 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off CC| |chris@bigballofwax.co.nz --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Since 12892 was rewritten to not depend on 13019, this bug is no longer blocked -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13030 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Patch won't apply - is it possible it relies on code from one of the other solutions for the waiting holds bug? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13030 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13019 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13030 --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Chris Cormack from comment #7)
Since 12892 was rewritten to not depend on 13019, this bug is no longer blocked
I'm afraid instead of removing the block, it's broken the patch entirely! I'll have to fix it up. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13030 jdemuth@roseville.ca.us <jdemuth@roseville.ca.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth@roseville.ca.us -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13030 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |BLOCKED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13030 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13030 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|12892, 13019 |13851 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13030 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13853 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13030 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Status|Signed Off |BLOCKED --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- This patch is blocked for QA by bug 13851, please reintroduce it in the QA queue when it will be ready. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13030 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13030 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13030 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We need to get bug 13851 signed off first in order to continue here. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13030 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32935|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 40027 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40027&action=edit Bug 13030 - Show waiting hold expiration date for waiting holds on circulation.pl We should show the date a waiting hold is set to expire for each hold in the list of waiting holds in circulation.pl Test Plan: 1) Apply this patch 2) Find a waiting hold for a patron, browser to circulation.pl for that patron 3) Set system preference ReservesMaxPickUpDelay to 5 4) Refresh circulation.pl, note the waiting holds now display a "waiting until" part with the waiting date plus 5 days 5) Set system preference ReservesMaxPickUpDelay to 0 ( or empty string ) 6) Refresh circulation.pl, note the waiting hols no longer have a "waiting until" line. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Followed test plan successfully. Automated tests successful. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13030 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13030 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40027|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 40038 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40038&action=edit [SIGNED-OFF] Bug 13030 - Show waiting hold expiration date for waiting holds on circulation.pl We should show the date a waiting hold is set to expire for each hold in the list of waiting holds in circulation.pl Test Plan: 1) Apply this patch 2) Find a waiting hold for a patron, browser to circulation.pl for that patron 3) Set system preference ReservesMaxPickUpDelay to 5 4) Refresh circulation.pl, note the waiting holds now display a "waiting until" part with the waiting date plus 5 days 5) Set system preference ReservesMaxPickUpDelay to 0 ( or empty string ) 6) Refresh circulation.pl, note the waiting hols no longer have a "waiting until" line. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Followed test plan successfully. Automated tests successful. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Cathi Wiggins <CWIGGINS@ci.arcadia.ca.us> Signed-off-by: Megan Wianecki <mwianecki@mplmain.mtpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13030 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #14 from Jonathan Druart <jonathan.druart@biblibre.com> --- Do the tests pass for you? I get the following errors: t/Hold.t .. 2/5 DBIx::Class::Storage::DBI::_warn_undetermined_driver(): This version of DBIC does not yet seem to supply a driver for your particular RDBMS and/or connection method ('Mock'). While we will attempt to continue anyway, the results are likely to be underwhelming. Please upgrade DBIC, and if this message does not go away, file a bugreport including the following info: { DBD => "DBD::Mock", DBD_VER => "1.45", DBIC_DRIVER => "DBIx::Class::Storage::DBI", DBIC_DSN => sub { package Koha::Database; use warnings; use strict; use feature 'say', 'state', 'switch', 'unicode_strings'; 'C4::Context'->dbh; }, DBIC_VER => "0.082810", DBI_VER => "1.631" } DBIx::Class::Storage::DBI::sql_maker(): Your storage class (DBIx::Class::Storage::DBI) does not set sql_limit_dialect and you have not supplied an explicit limit_dialect in your connection_info. DBIC will attempt to use the GenericSubQ dialect, which works on most databases but can be (and often is) painfully slow. Please file an RT ticket against 'DBIx::Class::Storage::DBI' at Koha/Objects.pm line 85 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13030 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13030 --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 40411 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40411&action=edit Bug 13030 [QA Followup] - Fix unit testsBug 13030 [QA Followup] - Fix unit tests -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13030 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40411|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 40412 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40412&action=edit Bug 13030 [QA Followup] - Fix unit tests -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13030 --- Comment #17 from Jonathan Druart <jonathan.druart@biblibre.com> --- Comment on attachment 40038 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40038 [SIGNED-OFF] Bug 13030 - Show waiting hold expiration date for waiting holds on circulation.pl Review of attachment 40038: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13030&attachment=40038) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt @@ +775,4 @@
<br/> [% IF ( w.branch.branchcode == Branches.GetLoggedInBranchcode() ) %]<strong class="waitinghere">[% ELSE %]<strong>[% END %] + Waiting at [% w.branch.branchname | html %] [% IF w.waiting_expires_on %] until [% w.waiting_expires_on | $KohaDates %] [% END %]
Sorry, I didn't see that before: there are 2 calls to the waiting_expires_on method. It is easy to make only 1 call. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13030 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13030 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13030 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40038|0 |1 is obsolete| | Attachment #40412|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 40414 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40414&action=edit Bug 13030 - Show waiting hold expiration date for waiting holds on circulation.pl We should show the date a waiting hold is set to expire for each hold in the list of waiting holds in circulation.pl Test Plan: 1) Apply this patch 2) Find a waiting hold for a patron, browser to circulation.pl for that patron 3) Set system preference ReservesMaxPickUpDelay to 5 4) Refresh circulation.pl, note the waiting holds now display a "waiting until" part with the waiting date plus 5 days 5) Set system preference ReservesMaxPickUpDelay to 0 ( or empty string ) 6) Refresh circulation.pl, note the waiting hols no longer have a "waiting until" line. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Followed test plan successfully. Automated tests successful. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Cathi Wiggins <CWIGGINS@ci.arcadia.ca.us> Signed-off-by: Megan Wianecki <mwianecki@mplmain.mtpl.org> Bug 13030 [QA Followup] - Fix unit tests Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13030 --- Comment #19 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 40415 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40415&action=edit Bug 13030: Remove the unnecessary double call Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13030 --- Comment #20 from Jonathan Druart <jonathan.druart@biblibre.com> --- I have squashed the 2 patches to avoid the add/del of a file in the same patch set. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13030 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #21 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13030 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Show waiting hold |Show hold expiration date |expiration date for waiting |for waiting holds on |holds on circulation.pl |circulation.pl -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org