[Bug 34901] New: Item-level holds can show inaccurate transit status on the patron details page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34901 Bug ID: 34901 Summary: Item-level holds can show inaccurate transit status on the patron details page Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Hold requests Assignee: emily.lamancusa@montgomerycountymd.gov Reporter: emily.lamancusa@montgomerycountymd.gov QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com If a patron has an item-level hold, and that same item happens to be in transit or waiting for a different patron's hold, the patron details page will label the item-level hold as in transit. Since the item-level hold has not been found yet, it should have a blank status. To reproduce: 1. Place a record-level hold for Patron A, for pickup at a library other than the logged-in library 2. Check in an item --> Note that the item is now in transit for the hold 3. Place an item-level hold for Patron B on that same item 4. Go to the details page for Patron B, and click on their Holds tab --> The status column now says the hold is in transit, although it is actually Patron A's hold that is in transit 5. Switch the logged in library to match the pickup location for Patron A's hold 6. Check the item in again --> Note that Patron A's hold is now Waiting 7. Return to the details page for Patron B --> The status column says the hold is "not yet transferred" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34901 --- Comment #1 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 156302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156302&action=edit Bug 34901: Display transit status on patron holds tab only if hold found value is "T" Check the transit status of the *hold* in addition to the transit status of the *item*, to avoid displaying a misleading transit status on item-level holds when the item is actually in transit for a different hold To test: 1. Create a record-level hold for Patron A for pickup at a library other than the logged-in library 2. Check in an item to fill that hold 3. Put an item-level hold on that same item for Patron B at a different library other than the logged-in library 4. Open Patron A's and Patron B's account details pages in separate tabs --> Note that the Holds tab on Patron A's account detail page correctly shows that their hold is in-transit --> Note that the Holds tab on Patron B's account detail page incorrectly shows that their hold on the same item is also in-transit 4. Apply patch 5. Clear browser cache 6. Refresh both patrons' account details pages --> Confirm that the holds tab on Patron A's account still correctly says their hold is in-transit --> Confirm that the holds tab on Patron B's account now correctly shows a blank status for their hold 7. Cancel Patron A's hold 8. Check in the item again to put it in transit for Patron B's hold 9. Reload Patron B's account page --> Confirm that the holds tab on Patron B's account now correctly says their hold is in-transit -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34901 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34901 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34901 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34901 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156302|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 157065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157065&action=edit Bug 34901: Display transit status on patron holds tab only if hold found value is "T" Check the transit status of the *hold* in addition to the transit status of the *item*, to avoid displaying a misleading transit status on item-level holds when the item is actually in transit for a different hold To test: 1. Create a record-level hold for Patron A for pickup at a library other than the logged-in library 2. Check in an item to fill that hold 3. Put an item-level hold on that same item for Patron B at a different library other than the logged-in library 4. Open Patron A's and Patron B's account details pages in separate tabs --> Note that the Holds tab on Patron A's account detail page correctly shows that their hold is in-transit --> Note that the Holds tab on Patron B's account detail page incorrectly shows that their hold on the same item is also in-transit 4. Apply patch 5. Clear browser cache 6. Refresh both patrons' account details pages --> Confirm that the holds tab on Patron A's account still correctly says their hold is in-transit --> Confirm that the holds tab on Patron B's account now correctly shows a blank status for their hold 7. Cancel Patron A's hold 8. Check in the item again to put it in transit for Patron B's hold 9. Reload Patron B's account page --> Confirm that the holds tab on Patron B's account now correctly says their hold is in-transit Signed-off-by: Katariina Hanhisalo <katariina.hanhisalo@xamk.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34901 Katariina Hanhisalo <katariina.hanhisalo@xamk.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katariina.hanhisalo@xamk.fi --- Comment #3 from Katariina Hanhisalo <katariina.hanhisalo@xamk.fi> --- Batch works as described. Just to notice, if you in the end also cancel Patron Bs hold and check in the book, it still wants to go to the palace where Patron B had the pick-up location. But this is another problem I think. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34901 Katariina Hanhisalo <katariina.hanhisalo@xamk.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34901 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157065|0 |1 is obsolete| | --- Comment #4 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 157067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157067&action=edit Bug 34901: Display transit status on patron holds tab only if hold found value is "T" Check the transit status of the *hold* in addition to the transit status of the *item*, to avoid displaying a misleading transit status on item-level holds when the item is actually in transit for a different hold To test: 1. Create a record-level hold for Patron A for pickup at a library other than the logged-in library 2. Check in an item to fill that hold 3. Put an item-level hold on that same item for Patron B at a different library other than the logged-in library 4. Open Patron A's and Patron B's account details pages in separate tabs --> Note that the Holds tab on Patron A's account detail page correctly shows that their hold is in-transit --> Note that the Holds tab on Patron B's account detail page incorrectly shows that their hold on the same item is also in-transit 4. Apply patch 5. Clear browser cache 6. Refresh both patrons' account details pages --> Confirm that the holds tab on Patron A's account still correctly says their hold is in-transit --> Confirm that the holds tab on Patron B's account now correctly shows a blank status for their hold 7. Cancel Patron A's hold 8. Check in the item again to put it in transit for Patron B's hold 9. Reload Patron B's account page --> Confirm that the holds tab on Patron B's account now correctly says their hold is in-transit Signed-off-by: Tuomas Kunttu <tuomas.kunttu@kouvola.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34901 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34901 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34901 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157067|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 157162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157162&action=edit Bug 34901: Display transit status on patron holds tab only if hold found value is "T" Check the transit status of the *hold* in addition to the transit status of the *item*, to avoid displaying a misleading transit status on item-level holds when the item is actually in transit for a different hold To test: 1. Create a record-level hold for Patron A for pickup at a library other than the logged-in library 2. Check in an item to fill that hold 3. Put an item-level hold on that same item for Patron B at a different library other than the logged-in library 4. Open Patron A's and Patron B's account details pages in separate tabs --> Note that the Holds tab on Patron A's account detail page correctly shows that their hold is in-transit --> Note that the Holds tab on Patron B's account detail page incorrectly shows that their hold on the same item is also in-transit 4. Apply patch 5. Clear browser cache 6. Refresh both patrons' account details pages --> Confirm that the holds tab on Patron A's account still correctly says their hold is in-transit --> Confirm that the holds tab on Patron B's account now correctly shows a blank status for their hold 7. Cancel Patron A's hold 8. Check in the item again to put it in transit for Patron B's hold 9. Reload Patron B's account page --> Confirm that the holds tab on Patron B's account now correctly says their hold is in-transit Signed-off-by: Katariina Hanhisalo <katariina.hanhisalo@xamk.fi> Signed-off-by: Tuomas Kunttu <tuomas.kunttu@kouvola.fi> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34901 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34901 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34901 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.05 released in| | --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34901 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.11.00,23.05.05 |23.11.00,23.05.05,22.11.12 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34901 --- Comment #8 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to oldstable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org