[Bug 20539] New: Warnings in catalogue/search.pl need to be removed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20539 Bug ID: 20539 Summary: Warnings in catalogue/search.pl need to be removed Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Depends on: 19995 Use of uninitialized value $template_type in string eq at /home/vagrant/kohaclone/catalogue/search.pl line 273. Use of uninitialized value $limit_cgi in split at /home/vagrant/kohaclone/catalogue/search.pl line 496. Use of uninitialized value $total in addition (+) at /home/vagrant/kohaclone/catalogue/search.pl line 541. Use of uninitialized value $limit_cgi_not_availablity in substitution (s///) at /home/vagrant/kohaclone/catalogue/search.pl line 590. Use of uninitialized value $gotonumber in string eq at /home/vagrant/kohaclone/catalogue/search.pl line 706. Use of uninitialized value $gotonumber in string eq at /home/vagrant/kohaclone/catalogue/search.pl line 706. Use of uninitialized value $gotopage in pattern match (m//) at /home/vagrant/kohaclone/catalogue/search.pl line 711. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19995 [Bug 19995] use Modern::Perl in Catalogue perl scripts -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20539 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_18_05_candidate -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20539 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |julian.maurice@biblibre.com Assignee|koha-bugs@lists.koha-commun |julian.maurice@biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20539 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 73849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73849&action=edit Bug 20539: Remove warnings in catalogue/search.pl Test plan: 1. Start a search from intranet 2. See several warnings in logs 3. Apply patch (&& reload starman) 4. Start a new search 5. Confirm that warnings are gone and that the search still works -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20539 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20539 Roch D'Amour <roch.damour@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20539 Roch D'Amour <roch.damour@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73849|0 |1 is obsolete| | --- Comment #2 from Roch D'Amour <roch.damour@inlibro.com> --- Created attachment 74176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74176&action=edit Bug 20539: Remove warnings in catalogue/search.pl Test plan: 1. Start a search from intranet 2. See several warnings in logs 3. Apply patch (&& reload starman) 4. Start a new search 5. Confirm that warnings are gone and that the search still works Signed-off-by: Roch D'Amour <roch.damour@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20539 Roch D'Amour <roch.damour@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |roch.damour@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20539 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20539 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74176|0 |1 is obsolete| | --- Comment #3 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 74181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74181&action=edit Bug 20539: Remove warnings in catalogue/search.pl Test plan: 1. Start a search from intranet 2. See several warnings in logs 3. Apply patch (&& reload starman) 4. Start a new search 5. Confirm that warnings are gone and that the search still works Signed-off-by: Roch D'Amour <roch.damour@inlibro.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20539 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20539 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_18_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20539 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Cannot recreate in 17.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20539 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org