[Bug 16027] New: Use Font Awesome icons in the professional cataloging interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16027 Bug ID: 16027 Summary: Use Font Awesome icons in the professional cataloging interface Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/cataloguing/editor.pl OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org The professional cataloging interface should use Font Awesome icons instead of Glyphicons. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16027 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16027 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 49126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49126&action=edit Bug 16027 - Use Font Awesome icons in the professional cataloging interface The professional cataloging interface uses Glyphicons. They should be replaced with Font Awesome icons. I have replaced the "Import record" icon as per the discussion on Bug 15966 about which icon better expresses import vs. export. To test, apply the patch and go to Cataloging -> Advanced editor. - Confirm that the icons in the toolbar look correct. - Click the "Macros" button and confirm that toolbar buttons in the modal look correct. - Click the "Advanced" link in the left-hand sidebar and confirm that the buttons in that modal look correct. - Click the "Save" button without adding anything to the blank record. Confirm that the "Missing..." error messages are styled with the correct icon. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16027 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16080 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16080 [Bug 16080] Remove unused images from the staff client -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16027 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16027 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49126|0 |1 is obsolete| | --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 49449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49449&action=edit Bug 16027 - Use Font Awesome icons in the professional cataloging interface The professional cataloging interface uses Glyphicons. They should be replaced with Font Awesome icons. I have replaced the "Import record" icon as per the discussion on Bug 15966 about which icon better expresses import vs. export. To test, apply the patch and go to Cataloging -> Advanced editor. - Confirm that the icons in the toolbar look correct. - Click the "Macros" button and confirm that toolbar buttons in the modal look correct. - Click the "Advanced" link in the left-hand sidebar and confirm that the buttons in that modal look correct. - Click the "Save" button without adding anything to the blank record. Confirm that the "Missing..." error messages are styled with the correct icon. NOTE: My Advance area was blank until I toggle device twice in the console of Chrome. Same issue before and after patch, code eyeballs well. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16027 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16027 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49449|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 49462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49462&action=edit Bug 16027 - Use Font Awesome icons in the professional cataloging interface The professional cataloging interface uses Glyphicons. They should be replaced with Font Awesome icons. I have replaced the "Import record" icon as per the discussion on Bug 15966 about which icon better expresses import vs. export. To test, apply the patch and go to Cataloging -> Advanced editor. - Confirm that the icons in the toolbar look correct. - Click the "Macros" button and confirm that toolbar buttons in the modal look correct. - Click the "Advanced" link in the left-hand sidebar and confirm that the buttons in that modal look correct. - Click the "Save" button without adding anything to the blank record. Confirm that the "Missing..." error messages are styled with the correct icon. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16027 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #4 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16027 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice@biblibre.com --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.6 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org