[Bug 10083] New: In Transit string doesn't get translated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10083 Bug ID: 10083 Summary: In Transit string doesn't get translated Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: eric.begin@inLibro.com CC: frederic@tamil.fr When applying a translation, the In transit string in the item status is not translated. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10083 Eric Bégin <eric.begin@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|In Transit string doesn't |In Transit string doesn't |get translated |get translated in the staff | |interface --- Comment #1 from Eric Bégin <eric.begin@inLibro.com> --- (In reply to comment #0)
When applying a translation, the In transit string in the item status is not translated.
Forgot to mentionned this problam is in the staff interface. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10083 --- Comment #2 from Eric Bégin <eric.begin@inLibro.com> --- Created attachment 17561 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17561&action=edit Patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10083 Eric Bégin <eric.begin@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10083 Eric Bégin <eric.begin@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10083 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |chris@bigballofwax.co.nz --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Big merge conflict, could you try rebasing it on latest master please Eric -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10083 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10083 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17561|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 17732 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17732&action=edit Bug 10083 - In Transit string doesn't get translated in the staff interface For some reason this text inside a <td> isn't getting picked up by the translator unless it's inside a <span>. This patch adds the span and tidies up the text. To test, apply the patch and "translate update" a translation. Searching the po file for "In transit from" should return a result from detail.pl. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10083 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.10 |master Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10083 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10083 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17732|0 |1 is obsolete| | --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 17760 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17760&action=edit Bug 10083 - In Transit string doesn't get translated in the staff interface For some reason this text inside a <td> isn't getting picked up by the translator unless it's inside a <span>. This patch adds the span and tidies up the text. To test, apply the patch and "translate update" a translation. Searching the po file for "In transit from" should return a result from detail.pl. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10083 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10083 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17760|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 17767 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17767&action=edit [PASSED QA] Bug 10083 - In Transit string doesn't get translated in the staff interface For some reason this text inside a <td> isn't getting picked up by the translator unless it's inside a <span>. This patch adds the span and tidies up the text. To test, apply the patch and "translate update" a translation. Searching the po file for "In transit from" should return a result from detail.pl. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Template only change fixing a translation problem. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10083 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10083 --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- Doesn't apply to 3.10.x please resubmit if needed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10083 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17767|0 |1 is obsolete| | --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 18169 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18169&action=edit Bug 10083 [3.10.x] In Transit string doesn't get translated in the staff interface For some reason this text inside a <td> isn't getting picked up by the translator unless it's inside a <span>. This patch adds the span and tidies up the text. To test, apply the patch and "translate update" a translation. Searching the po file for "In transit from" should return a result from detail.pl. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10083 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED Version|master |3.10 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10083 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10083 --- Comment #10 from Gaetan Boisson <gaetan.boisson@biblibre.com> --- Created attachment 18457 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18457&action=edit [SIGNED OFF] Bug 10083 [3.10.x] In Transit string doesn't get translated in the staff interface For some reason this text inside a <td> isn't getting picked up by the translator unless it's inside a <span>. This patch adds the span and tidies up the text. To test, apply the patch and "translate update" a translation. Searching the po file for "In transit from" should return a result from detail.pl. Signed-off-by: Gaetan Boisson <gaetan.boisson@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10083 Gaetan Boisson <gaetan.boisson@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |gaetan.boisson@biblibre.com --- Comment #11 from Gaetan Boisson <gaetan.boisson@biblibre.com> --- On a 3.10 instance, before applying the patch, the string "In transit from" is found only once in the French po file (for request.pl). After applying the patch and running updating the French po file, the string is found twice, once for request.pl and once for detail.pl. Signed off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10083 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: I confirm the proposed patch works for 3.10 branch. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10083 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18169|0 |1 is obsolete| | Attachment #18457|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 18459 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18459&action=edit Bug 10083 [3.10.x] In Transit string doesn't get translated in the staff interface For some reason this text inside a <td> isn't getting picked up by the translator unless it's inside a <span>. This patch adds the span and tidies up the text. To test, apply the patch and "translate update" a translation. Searching the po file for "In transit from" should return a result from detail.pl. Signed-off-by: Gaetan Boisson <gaetan.boisson@biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10083 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #14 from Chris Cormack <chris@bigballofwax.co.nz> --- Another one for you Bernardo :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10083 --- Comment #15 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Thanks Owen! Pushed to 3.10.x, will be on 3.10.7 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10083 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable CC| |gmcharlt@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10083 Chris Hall <chrish@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish@catalyst.net.nz --- Comment #16 from Chris Hall <chrish@catalyst.net.nz> --- Pushed to 3.8.x, will be in 3.8.14 Thanks :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10083 Francois Charbonnier <francois.charbonnier@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org