[Bug 21537] New: Regression in #19289: typo in acquisitions template processor name
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21537 Bug ID: 21537 Summary: Regression in #19289: typo in acquisitions template processor name Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oliver.behnke@aei.mpg.de QA Contact: testopia@bugs.koha-community.org Hi, we just ran across the following error when creating a new book order based on a suggestion:
Template process failed: file error - options_for_itemtypes: not found at /usr/share/koha/lib/C4/Templates.pm line 122
Investigating the problem I found a regression in #19289 where a new template processor called "options_for_item_types" got added to intranet-tmpl/prog/en/includes/html_helpers.inc. However, in intranet-tmpl/prog/en/modules/acqui/neworderempty.tt it's called as "options_for_itemtypes". Note the missing underscore in "itemtypes". Cheers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21537 Oliver Behnke <oliver.behnke@aei.mpg.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19289 Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21537 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Version|18.05 |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21537 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19289 Summary|Regression in #19289: typo |Regression: typo in |in acquisitions template |acquisitions template |processor name |processor name Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21537 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21537 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 80359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80359&action=edit Bug 21537: Fix itemtype processing To test: 0 - Set UseACQFrameworkForBiblioRecords to 'Use' 1 - Define a subfield in the ACQ framework linked to authorised value 'itemtypes' 2 - Make sure that field is visible 3 - Create a purchase suggestion 4 - Accept it 5 - Go to Acquisitions 6 - Find a vendor with an open basket, or create one 7 - Add to the basket using a suggestion 8 - Choose the suggestion 9 - Internal server error 10 - Apply patch 11 - Place order form a suggestion again 12 - Confirm that the field linked to itemtypes shows correctly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21537 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21537 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21537 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80359|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 80477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80477&action=edit Bug 21537: Fix typo for options_for_item_types To test: 0 - Set UseACQFrameworkForBiblioRecords to 'Use' 1 - Define a subfield in the ACQ framework linked to authorised value 'itemtypes' 2 - Make sure that field is visible 3 - Create a purchase suggestion 4 - Accept it 5 - Go to Acquisitions 6 - Find a vendor with an open basket, or create one 7 - Add to the basket using a suggestion 8 - Choose the suggestion 9 - Internal server error 10 - Apply patch 11 - Place order form a suggestion again 12 - Confirm that the field linked to itemtypes shows correctly Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21537 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80477|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 80504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80504&action=edit Bug 21537: Fix typo for options_for_item_types To test: 0 - Set UseACQFrameworkForBiblioRecords to 'Use' 1 - Define a subfield in the ACQ framework linked to authorised value 'itemtypes' 2 - Make sure that field is visible 3 - Create a purchase suggestion 4 - Accept it 5 - Go to Acquisitions 6 - Find a vendor with an open basket, or create one 7 - Add to the basket using a suggestion 8 - Choose the suggestion 9 - Internal server error 10 - Apply patch 11 - Place order form a suggestion again 12 - Confirm that the field linked to itemtypes shows correctly Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21537 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Another trivial patch which resolves the problem and causes no regressions. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21537 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21537 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21537 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Regression: typo in |Error when creating a new |acquisitions template |order from a suggestion |processor name | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21537 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Templates |Acquisitions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21537 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Error when creating a new |Template error when |order from a suggestion |creating a new order from a | |suggestion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21537 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21537 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21537 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Depends on Bug 19289 not in 17.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org