https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24441 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 97469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97469&action=edit Bug 24441: Error when checking in an item with BranchTansferLimitsType set to itemtype It appears that the transition to using Koha::Item in AddReturn has introduced a bug. Previously $item was a hashref with the key 'itemtype', now that it's an object, it has no itemtype method and so triggers an error with the message "The method Koha::Item->itemtype is not covered by tests!". Test Plan: 1) Enable Branch Transfer Limits via itemtype 2) Check in an item 3) Note the error 4) Apply this patch 5) Restart all the things! 6) Check in an item 7) No error! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24441 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24441 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97469|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 97513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97513&action=edit Bug 24441: Error when checking in an item with BranchTansferLimitsType set to itemtype It appears that the transition to using Koha::Item in AddReturn has introduced a bug. Previously $item was a hashref with the key 'itemtype', now that it's an object, it has no itemtype method and so triggers an error with the message "The method Koha::Item->itemtype is not covered by tests!". Test Plan: 1) Enable Branch Transfer Limits via itemtype 2) Check in an item 3) Note the error 4) Apply this patch 5) Restart all the things! 6) Check in an item 7) No error! Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Maribeth (Turner) Shafer - Central Kansas Library System CKLS <mshafer@ckls.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24441 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24441 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 97670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97670&action=edit Bug 24441: Error when checking in an item with BranchTansferLimitsType set to itemtype It appears that the transition to using Koha::Item in AddReturn has introduced a bug. Previously $item was a hashref with the key 'itemtype', now that it's an object, it has no itemtype method and so triggers an error with the message "The method Koha::Item->itemtype is not covered by tests!". Test Plan: 1) Enable Branch Transfer Limits via itemtype 2) Check in an item 3) Note the error 4) Apply this patch 5) Restart all the things! 6) Check in an item 7) No error! Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Maribeth (Turner) Shafer - Central Kansas Library System CKLS <mshafer@ckls.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24441 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.