[Bug 12677] New: Use Bootstrap "label" style for inline OPAC renewal messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12677 Bug ID: 12677 Summary: Use Bootstrap "label" style for inline OPAC renewal messages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Bug 12568 adds more prominent renewal messages to the OPAC user's list of checkouts. I would prefer that the messages be styled with a style which is better suited to an inline message. The "alert" style is more suited to block-level messages. With some CSS tweaks the Bootstrap "label" style would work well I think: http://getbootstrap.com/2.3.2/components.html#labels-badges -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12677 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12568 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12677 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12677 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 30472 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30472&action=edit Bug 12677 - Use Bootstrap "label" style for inline OPAC renewal messages This patch revises the styling of the renewal success message to use a default Bootstrap style more suited to inline messages. I think this is preferable to using the alert style because the alert is designed to be a block-level element. http://getbootstrap.com/2.3.2/components.html#labels-badges Because Koha's CSS already uses a "label" class for something else I duplicate the Bootstrap "label" class in opac.css as "blabel." The Bootstrap color definitions are included. To test, follow the test plan already provided: 1) Apply this patch 2) From the OPAC, renew some items 3) Note the "Renewed!" message in the "Renew" column of the checkouts table -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12677 --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 30482 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30482&action=edit [Signed-off] Bug 12677 - Use Bootstrap "label" style for inline OPAC renewal messages This patch revises the styling of the renewal success message to use a default Bootstrap style more suited to inline messages. I think this is preferable to using the alert style because the alert is designed to be a block-level element. http://getbootstrap.com/2.3.2/components.html#labels-badges Because Koha's CSS already uses a "label" class for something else I duplicate the Bootstrap "label" class in opac.css as "blabel." The Bootstrap color definitions are included. To test, follow the test plan already provided: 1) Apply this patch 2) From the OPAC, renew some items 3) Note the "Renewed!" message in the "Renew" column of the checkouts table Patch works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12677 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30472|0 |1 is obsolete| | CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12677 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12677 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 30491 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30491&action=edit [PASSED QA] Bug 12677 - Use Bootstrap "label" style for inline OPAC renewal messages This patch revises the styling of the renewal success message to use a default Bootstrap style more suited to inline messages. I think this is preferable to using the alert style because the alert is designed to be a block-level element. http://getbootstrap.com/2.3.2/components.html#labels-badges Because Koha's CSS already uses a "label" class for something else I duplicate the Bootstrap "label" class in opac.css as "blabel." The Bootstrap color definitions are included. To test, follow the test plan already provided: 1) Apply this patch 2) From the OPAC, renew some items 3) Note the "Renewed!" message in the "Renew" column of the checkouts table Patch works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, no problems found. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12677 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12677 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30482|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12677 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org