[Bug 5647] New: Enhanced Notices are using name and not id
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5647 Summary: Enhanced Notices are using name and not id Change sponsored?: --- Product: Koha Version: unspecified Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Notices AssignedTo: henridamien@koha-fr.org ReportedBy: nengard@gmail.com QAContact: koha-bugs@lists.koha-community.org Estimated Hours: 0.0 According to bug 5646 the messaging preferences can't be translated because the code queries the name and not the id. I am opening a new bug here because that bug has been "resolved" with a work around. Instead I think the code should be updated to check for the primary key (id) instead of the name. This is necessary for translations and so that we can make changes to those labels.
From Bug 5646 (reported by Katrin)
If you tranlate the message names in the installer sql files your messages will stop working, because the code relies on those have a specific value. - advance_notices.pl - C4/Members/Messaging.pm - C4/Form/MessagingPreferences.pm ... In C4/Members/Messaging.pm I found following lines: 47 my $preferences = C4::Members::Messaging::GetMessagingPreferences( { borrowernumber => $borrower->{'borrowernumber'}, 48 message_name => 'DUE' } ); 50 my $preferences = C4::Members::Messaging::GetMessagingPreferences( { categorycode => 'LIBRARY', 51 message_name => 'DUE' } ); We don't have DUE as a message name in the en file. Bug? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5647 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=5646 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5647 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer@bsz-bw.de Resolution|--- |WONTFIX --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The translatabilty problem for message names has been solved on template level. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org