[Bug 29449] New: Show userid on "your personal details" tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29449 Bug ID: 29449 Summary: Show userid on "your personal details" tab Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: magnus@libriotech.no QA Contact: testopia@bugs.koha-community.org In the OPAC, the "your personal details" tab of a logged in user shows the card number, but not the userid. This is extra confusing for users who have their username generated in the firstname.surname form. I can't think of cases where a library would want to hide the userid from patrons, but if there are any arguments for this, there would have to be a syspref (or a per patron category setting?) to enable/disable the display. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29449 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We already have the "*unwanted*" prefs for the OPAC and they also already list userid, but it's not displayed according to it, like you say. I'd almost say that this is a bug? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29449 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29449 --- Comment #2 from Magnus Enger <magnus@libriotech.no> --- Created attachment 147114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147114&action=edit Bug 29449: Show userid on "Personal details" tab To reproduce: - Login to the OPAC - Go to the "Personal details" tab - Verify the Username/userid of the logged in user is not shown anywhere To test: - Apply this patch - Reload the "Personal details" tab - Verify the userid is now shown below the "Library card number" - Try adding "userid" to PatronSelfModificationBorrowerUnwantedField and verify the field is hidden as expected - Sign off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29449 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |magnus@libriotech.no CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29449 --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Works as described but when a patron self registers there is now an empty 'Username:' Should we check to see if the action is 'edit' or not so that will not appear on the self registration form? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29449 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29449 --- Comment #4 from Magnus Enger <magnus@libriotech.no> --- (In reply to Lucas Gass from comment #3)
Works as described but when a patron self registers there is now an empty 'Username:'
Should we check to see if the action is 'edit' or not so that will not appear on the self registration form?
Gah! I thought I checked that! It makes perfect sense of course. New patch coming. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29449 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29449 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147114|0 |1 is obsolete| | --- Comment #5 from Magnus Enger <magnus@libriotech.no> --- Created attachment 147195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147195&action=edit Bug 29449: Show userid on "Personal details" tab To reproduce: - Login to the OPAC - Go to the "Personal details" tab - Verify the Username/userid of the logged in user is not shown anywhere To test: - Apply this patch - Reload the "Personal details" tab - Verify that "Username:" and the userid is now shown below the "Library card number" - Try adding "userid" to PatronSelfModificationBorrowerUnwantedField and verify the field is hidden as expected - Log out - Go to "Don't have an account? Register here." - Verify "Username:" is *not* shown - Sign off https://bugs.koha-community.org/show_bug.cgi?id=32922 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29449 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147195|0 |1 is obsolete| | --- Comment #6 from Magnus Enger <magnus@libriotech.no> --- Created attachment 147196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147196&action=edit Bug 29449: Show userid on "Personal details" tab To reproduce: - Login to the OPAC - Go to the "Personal details" tab - Verify the Username/userid of the logged in user is not shown anywhere To test: - Apply this patch - Reload the "Personal details" tab - Verify that "Username:" and the userid is now shown below the "Library card number" - Try adding "userid" to PatronSelfModificationBorrowerUnwantedField and verify the field is hidden as expected - Log out - Go to "Don't have an account? Register here." - Verify "Username:" is *not* shown - Sign off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29449 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com Status|Needs Signoff |Signed Off --- Comment #7 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- (In reply to Magnus Enger from comment #6)
Created attachment 147196 [details] [review] Bug 29449: Show userid on "Personal details" tab
To reproduce: - Login to the OPAC - Go to the "Personal details" tab - Verify the Username/userid of the logged in user is not shown anywhere
To test: - Apply this patch - Reload the "Personal details" tab - Verify that "Username:" and the userid is now shown below the "Library card number" - Try adding "userid" to PatronSelfModificationBorrowerUnwantedField and verify the field is hidden as expected - Log out - Go to "Don't have an account? Register here." - Verify "Username:" is *not* shown - Sign off
Signed-Off-By: Laura Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29449 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147196|0 |1 is obsolete| | --- Comment #8 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 147975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147975&action=edit Bug 29449: Show userid on "Personal details" tab To reproduce: - Login to the OPAC - Go to the "Personal details" tab - Verify the Username/userid of the logged in user is not shown anywhere To test: - Apply this patch - Reload the "Personal details" tab - Verify that "Username:" and the userid is now shown below the "Library card number" - Try adding "userid" to PatronSelfModificationBorrowerUnwantedField and verify the field is hidden as expected - Log out - Go to "Don't have an account? Register here." - Verify "Username:" is *not* shown - Sign off Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29449 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29449 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147975|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 148687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148687&action=edit Bug 29449: Show userid on "Personal details" tab To reproduce: - Login to the OPAC - Go to the "Personal details" tab - Verify the Username/userid of the logged in user is not shown anywhere To test: - Apply this patch - Reload the "Personal details" tab - Verify that "Username:" and the userid is now shown below the "Library card number" - Try adding "userid" to PatronSelfModificationBorrowerUnwantedField and verify the field is hidden as expected - Log out - Go to "Don't have an account? Register here." - Verify "Username:" is *not* shown - Sign off Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29449 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29449 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29449 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29449 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Interesting! I have a question: What would be the recommended way to use this in relation to the various borrower mandatory/unwanted settings? I applied this change on 21.11 and still did not see userid. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29449 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop@ptfs-europe | |.com Status|Pushed to master |Needs documenting --- Comment #12 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Enhancement - not backporting to 22.11.x Nice work everyone! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29449 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Patrons can now see their release notes| |username in the 'Personal | |details' tab in the OPAC. | | | |This can be hidden from | |them using the | |PatronSelfModificationBorro | |werUnwantedField system | |preference, if needed. Resolution|--- |FIXED Status|Needs documenting |RESOLVED CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #13 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Seems like a bug fix. Nothing to add/amend in the manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org