https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38060 --- Comment #1 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 172294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172294&action=edit Bug 38060: Load bookings table on page load if tab href exists in URL hash Test plan, k-t-d or sandbox: 1) Start by making an item bookable. Visit a record's detail page: <staff_url>/cgi-bin/koha/catalogue/moredetail.pl?biblionumber=76 2) Make the first item (39999000003154) bookable by setting 'Bookable': Yes and click 'Update' 3) At the top of the page, you should now see a 'Place booking' button. Click that. 4) Select the patron: type 'koha' and pick 'koha (42)'. (This is borrowernumber 51). 5) Select booking dates, any date interval in the future. Click 'Submit'. 6) Attempt to access this patron's detail page with the bookings tab open: <staff_url>/cgi-bin/koha/members/moremember.pl?borrowernumber=51#bookings_panel 7) Notice the tab opens, but the table does not render. 8) Attempt the same in the circulation page: <staff_url>/cgi-bin/koha/circ/circulation.pl?borrowernumber=51#bookings_panel 9) Again, notice the tab opens, but the table does not render. 10) Apply patch. Repeat steps 6) and 8). Notice the table now renders. Additional testing: 1) Place a hold for this patron and attempt to access the holds tab directly: /cgi-bin/koha/circ/circulation.pl?borrowernumber=51#holds_panel 2) Notice it opens the tab and renders the table. This was already the case prior to this patch, this patch is only bringing the same behavior to the bookings tab for consistency. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38060 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172294|0 |1 is obsolete| | --- Comment #2 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 172295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172295&action=edit Bug 38060: Load bookings table on page load if tab href exists in URL hash Test plan, k-t-d or sandbox: 1) Start by making an item bookable. Visit a record's detail page: <staff_url>/cgi-bin/koha/catalogue/moredetail.pl?biblionumber=76 2) Make the first item (39999000003154) bookable by setting 'Bookable': Yes and click 'Update' 3) At the top of the page, you should now see a 'Place booking' button. Click that. 4) Select the patron: type 'koha' and pick 'koha (42)'. (This is borrowernumber 51). 5) Select booking dates, any date interval in the future. Click 'Submit'. 6) Attempt to access this patron's detail page with the bookings tab open: <staff_url>/cgi-bin/koha/members/moremember.pl?borrowernumber=51#bookings_panel 7) Notice the tab opens, but the table does not render. 8) Attempt the same in the circulation page: <staff_url>/cgi-bin/koha/circ/circulation.pl?borrowernumber=51#bookings_panel 9) Again, notice the tab opens, but the table does not render. 10) Apply patch. Repeat steps 6) and 8). Notice the table now renders. Additional testing: 1) Place a hold for this patron and attempt to access the holds tab directly: /cgi-bin/koha/circ/circulation.pl?borrowernumber=51#holds_panel 2) Notice it opens the tab and renders the table. This was already the case prior to this patch, this patch is only bringing the same behavior to the bookings tab for consistency. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38060 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172295|0 |1 is obsolete| | --- Comment #3 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 172373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172373&action=edit Bug 38060: Load bookings table on page load if tab href exists in URL hash Test plan, k-t-d or sandbox: 1) Start by making an item bookable. Visit a record's detail page: <staff_url>/cgi-bin/koha/catalogue/moredetail.pl?biblionumber=76 2) Make the first item (39999000003154) bookable by setting 'Bookable': Yes and click 'Update' 3) At the top of the page, you should now see a 'Place booking' button. Click that. 4) Select the patron: type 'koha' and pick 'koha (42)'. (This is borrowernumber 51). 5) Select booking dates, any date interval in the future. Click 'Submit'. 6) Attempt to access this patron's detail page with the bookings tab open: <staff_url>/cgi-bin/koha/members/moremember.pl?borrowernumber=51#bookings_panel 7) Notice the tab opens, but the table does not render. 8) Attempt the same in the circulation page: <staff_url>/cgi-bin/koha/circ/circulation.pl?borrowernumber=51#bookings_panel 9) Again, notice the tab opens, but the table does not render. 10) Apply patch. Repeat steps 6) and 8). Notice the table now renders. Additional testing: 1) Place a hold for this patron and attempt to access the holds tab directly: /cgi-bin/koha/circ/circulation.pl?borrowernumber=51#holds_panel 2) Notice it opens the tab and renders the table. This was already the case prior to this patch, this patch is only bringing the same behavior to the bookings tab for consistency. Signed-off-by: davedaghita <ddaghita@mckinneytexas.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38060 davedaghita <ddaghita@mckinneytexas.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38060 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com Status|Signed Off |Passed QA --- Comment #6 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Thanks for the quick fix here Pedro, you beat me to it :) All working and a clear improvement in code handling. Passign QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38060 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38060 Bug 38060 depends on bug 37047, which changed state. Bug 37047 Summary: Patron bookings are not visible from patrons checkout page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37047 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.