[Bug 31724] New: MARC framework subfield deletion - 'i' added to end of the breadcrumb on confirm deletion page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31724 Bug ID: 31724 Summary: MARC framework subfield deletion - 'i' added to end of the breadcrumb on confirm deletion page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: david@davidnind.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl When deleting a subfield in a MARC framework, there is an 'i' added to the breadcrumb on the confirm deletion page, for example: - Home > Administration > MARC frameworks > BKS framework structure > Tag 245 Subfield structure > Confirm deletion of subfield ci - This should be ... Confirm deletion of subfield c It looks like this was added in bug 27846 (released in 21.05.00). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31724 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |david@davidnind.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31724 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31724 --- Comment #1 from David Nind <david@davidnind.com> --- Created attachment 141560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141560&action=edit Bug 31724: Remove 'i' from breadcrumb when deleting a MARC framework subfield Remove 'i' added to the end of the breadcrumb on the confirmation page when deleteing a MARC framework subfield. Test plan: 1. Go to Administration > MARC bibliographic frameworks. 2. View the subfields for a tag for a framework, for example: . BKS framework > Actions > MARC structure . Search for tag 245 . Select Actions > View subfields. 3. Select any subfield to delete and select the Delete button. 4. Note that there is an 'i' at the end of the breadcrumb, for example: . ... > Confirm deletion of subfield bi 5. Apply the patch. 6. Refresh the page and note that that 'i' is removed. 7. Sign off. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31724 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the breadcrumb release notes| |when deleting a subfield | |for a framework. An 'i' was | |incorrectly added to the | |end of the breadcrumb on | |the deletion confirmation | |page, for example: ... > | |Confirm deletion of | |subfield bi -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31724 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #2 from Fridolin Somers <fridolin.somers@biblibre.com> --- Looks like a VIM residue ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31724 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27846 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27846 [Bug 27846] Accessibility: Staff Client - Breadcrumbs should be more accessible -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31724 --- Comment #3 from David Nind <david@davidnind.com> --- (In reply to Fridolin Somers from comment #2)
Looks like a VIM residue ;)
That was my thought as well. The other alternative was that it should be a ? to match the dialogue box text. But I think it makes sense not to have the question mark. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31724 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141560|0 |1 is obsolete| | --- Comment #4 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 141591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141591&action=edit Bug 31724: Remove 'i' from breadcrumb when deleting a MARC framework subfield Remove 'i' added to the end of the breadcrumb on the confirmation page when deleteing a MARC framework subfield. Test plan: 1. Go to Administration > MARC bibliographic frameworks. 2. View the subfields for a tag for a framework, for example: . BKS framework > Actions > MARC structure . Search for tag 245 . Select Actions > View subfields. 3. Select any subfield to delete and select the Delete button. 4. Note that there is an 'i' at the end of the breadcrumb, for example: . ... > Confirm deletion of subfield bi 5. Apply the patch. 6. Refresh the page and note that that 'i' is removed. 7. Sign off. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31724 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31724 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141591|0 |1 is obsolete| | --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 141592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141592&action=edit Bug 31724: Remove 'i' from breadcrumb when deleting a MARC framework subfield Remove 'i' added to the end of the breadcrumb on the confirmation page when deleteing a MARC framework subfield. Test plan: 1. Go to Administration > MARC bibliographic frameworks. 2. View the subfields for a tag for a framework, for example: . BKS framework > Actions > MARC structure . Search for tag 245 . Select Actions > View subfields. 3. Select any subfield to delete and select the Delete button. 4. Note that there is an 'i' at the end of the breadcrumb, for example: . ... > Confirm deletion of subfield bi 5. Apply the patch. 6. Refresh the page and note that that 'i' is removed. 7. Sign off. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31724 --- Comment #6 from David Nind <david@davidnind.com> --- Thanks Fridolin for signing off! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31724 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31724 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141592|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 141854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141854&action=edit Bug 31724: Remove 'i' from breadcrumb when deleting a MARC framework subfield Remove 'i' added to the end of the breadcrumb on the confirmation page when deleteing a MARC framework subfield. Test plan: 1. Go to Administration > MARC bibliographic frameworks. 2. View the subfields for a tag for a framework, for example: . BKS framework > Actions > MARC structure . Search for tag 245 . Select Actions > View subfields. 3. Select any subfield to delete and select the Delete button. 4. Note that there is an 'i' at the end of the breadcrumb, for example: . ... > Confirm deletion of subfield bi 5. Apply the patch. 6. Refresh the page and note that that 'i' is removed. 7. Sign off. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31724 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Vim users.... haha -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31724 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31724 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org