https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m, | |jonathan.druart+koha@gmail. | |com, | |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 128114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128114&action=edit Bug 29605: (follow-up) Add language_script_mapping primary key Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- How did we miss that?! It also means that there is a RM step that is missing when releasing -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add missing UNIQUE |DB structure may not be |constraints in |synced with |kohastructure.sql (Bug |kohastructure.sql |15067 follow-up) | Assignee|tomascohen@gmail.com |jonathan.druart+koha@gmail. | |com Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128153&action=edit Bug 29605: account_offsets.type is not null -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128155&action=edit Bug 29605: additional_contents.lang Up to 50 on bug 23797 but bug 24387 switched it back to 25 (bad resolution conflict) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 128157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128157&action=edit Bug 29605: language_script_mapping.language_subtag cannot be null It's a PK now -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Test plan: % git checkout -b bug_29605 origin/master % yes|git bz apply 29605 % git checkout v21.05.00 % reset_all % git checkout bug_29605 % updatedatabase # We are going to update the 21.05.00 DB with all the 21.11 dbrevs # Generate the DBIC schema file using the current DB % perl misc/devel/update_dbix_class_files.pl --koha-conf $KOHA_CONF % git commit -a -m"test diff" # commit the changes to help understand % dbic # generate the schema file using kohastructure.sql % git diff => NO relevant changes should be seen in this diff, only comments and date/md5sum must differ. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 --- Comment #13 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #3)

How did we miss that?! It also means that there is a RM step that is missing when releasing

https://tree.taiga.io/project/koha-ils/task/117 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 --- Comment #16 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to David Nind from comment #15)

Created attachment 128239 [details] Bug 29605 - Error messages after reset_all

I had a go at testing this, but I get "BEGIN failed--compilation aborted at...." error messages after the reset_all command.

See attachment for the command line log.

Ah 21.05.x does not have same perl deps as 21.11. Try installing package libemail-valid-perl. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 --- Comment #18 from David Nind <david@davidnind.com> --- Created attachment 128313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128313&action=edit Bug 29605 - Result from git diff I followed Jonathan's test plan in comment 12 - I've attached the diff, so I hope that is what is expected. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 --- Comment #20 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to David Nind from comment #19)

Created attachment 128314 [details] Bug 29605 - Error when accessing staff interface and OPAC

I haven't signed off because when I try to go into the staff interface or the OPAC I get errors (after flush_memcached and restart_all) - see the attached error trace.

apt install libcgi-session-serialize-yaml-perl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I was slow to the game here.. adding to the ndiscussion on tiaga, I've used a few systems that take the approach Julian suggests and never had any real performance concerns. I quite like the idea of not having to maintain the structure twice. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 --- Comment #24 from Tomás Cohen Arazi <tomascohen@gmail.com> --- After the upgrade: - language_script_mapping.language_subtag is_nullable 0 vs 1 - __PACKAGE__->add_unique_constraint("uniq_code", ["rfc4646_subtag", "iso639_2_code"]); - AdditionalContent.pm => field sizes differences for 'category' and 'content' -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 --- Comment #26 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Ok. This is ready to go IMHO. The only missing bit is the updated DBIC files, which make sense and should be done by the RM on pushing, so we are good. New revisited test plan: % git checkout -b bug_29605 origin/master % yes|git bz apply 29605 % git checkout v21.05.00 % reset_all % git checkout bug_29605 % updatedatabase # We are going to update the 21.05.00 DB with all the 21.11 dbrevs % perl cp_debian_files.pl --koha_dir /kohadevbox/koha/ --gitify_dir /kohadevbox/gitify/ --instance kohadev # Generate the DBIC schema file using the current DB % perl misc/devel/update_dbix_class_files.pl --koha-conf $KOHA_CONF % git commit -a -m"test diff" # commit the changes to help understand % dbic # generate the schema file using kohastructure.sql % git diff => NO relevant changes should be seen in this diff, only comments and date/md5sum must differ. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128114|0 |1 is obsolete| | --- Comment #28 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 128438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128438&action=edit Bug 29605: (follow-up) Add language_script_mapping primary key Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128153|0 |1 is obsolete| | --- Comment #30 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 128440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128440&action=edit Bug 29605: account_offsets.type is not null Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128155|0 |1 is obsolete| | --- Comment #32 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 128442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128442&action=edit Bug 29605: additional_contents.lang Up to 50 on bug 23797 but bug 24387 switched it back to 25 (bad resolution conflict) Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128157|0 |1 is obsolete| | --- Comment #34 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 128444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128444&action=edit Bug 29605: language_script_mapping.language_subtag cannot be null It's a PK now Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128239|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128313|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 --- Comment #36 from David Nind <david@davidnind.com> --- Created attachment 128483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128483&action=edit Bug 29605 - Error when accessing staff interface and OPAC - 2021-12-14 Still getting an error trace when accessing staff interface and OPAC after flush_memcached and restart_all (see attached). Testing notes (koha-testing-docker): 1. apt-get install libcgi-session-serialize-yaml-perl (comment 16) 2. apt-get install libemail-valid-perl (comment 20) 3. Use updated test plan in comment 26: . for perl cp_debian_files.pl... change to: perl /kohadevbox/misc4dev/cp_debian_files.pl --koha_dir /kohadevbox/koha/ --gitify_dir /kohadevbox/gitify/ --instance kohadev 5. As per comment 27 check SQL for steps 4, 5 and 6. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 --- Comment #38 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Can anyone QA this one? -- You are receiving this mail because: You are watching all bug changes.

SHOW CREATE TABLE language_subtag_registry; => SUCCESS: There's UNIQUE KEY uniq_lang (subtag, type)

SHOW CREATE TABLE language_descriptions; => SUCCESS: There's UNIQUE KEY uniq_desc (subtag, type, lang)

SHOW CREATE TABLE language_rfc4646_to_iso639; => SUCCESS: There's UNIQUE KEY uniq_code (rfc4646_subtag, iso639_2_code)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128437|0 |1 is obsolete| | Attachment #128438|0 |1 is obsolete| | Attachment #128439|0 |1 is obsolete| | Attachment #128440|0 |1 is obsolete| | Attachment #128441|0 |1 is obsolete| | Attachment #128442|0 |1 is obsolete| | Attachment #128443|0 |1 is obsolete| | Attachment #128444|0 |1 is obsolete| | Attachment #128445|0 |1 is obsolete| | --- Comment #39 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 129153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129153&action=edit Bug 29605: Add missing constraints from bug 15067 This patch fixes a missed update to kohastructure.sql. To test: 1. Checkout prior to bug 15067 (ab270c026be06f08745a14d1aea992877d20f812) would work. 2. Run: $ reset_all 3. Checkout v21.11.00 4. Run: $ updatedatabase $ koha-mysql kohadev 5. Run: 6. Run: 7. Replicate a fresh install. Run: $ reset_all 8. Repeat 4, 5 and 6 => FAIL: The UNIQUE constraints are not there! 9. Apply this patch 10. Run: $ reset_all 11. Repeat 8 => SUCCESS: The UNIQUE constraints are there! 12. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 --- Comment #41 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 129155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129155&action=edit Bug 29605: Missing FK on tmp_holdsqueue.borrowernumber (tmp_holdsqueue_ibfk_3) Bad copy paste on the foreign_key_exists condition Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 --- Comment #43 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 129157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129157&action=edit Bug 29605: additional_contents.code Added 100 on 210600016, but 20 in kohastructure Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 --- Comment #45 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 129159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129159&action=edit Bug 29605: search_marc_map.marc_type NOT NULL was missing when MODIFY Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 --- Comment #47 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 129161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129161&action=edit Bug 29605: branchtransfers.cancellation_reason reason and cancellation_reason was inversed, and the enum values were lower cases Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29596 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29596 [Bug 29596] Add Yiddish language -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 --- Comment #49 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 --- Comment #51 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Jonathan Druart from comment #50)

This needs to be backported.

Ah sure, sorry I misunderstood the meaning of this keyword. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #53 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Missing dependency, not backported to 21.05 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 --- Comment #55 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Martin Renvoize from comment #54)

We're out of sync again already

We need to refine the process here.. didn't we decide we should be only submitting atomicupdates and using koha-dump to generate the kohastructure file from it?

We discussed that already. The problem is that most of the time the error is coming from the atomic update, the kohastructure is correct... -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605 --- Comment #56 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #55)

We discussed that already. The problem is that most of the time the error is coming from the atomic update, the kohastructure is correct...

Yeah it's easy to test a new kohastructure.sql or an atomic update against the last kohastructure.sql, but systems in the wild don't always play nice with atomic updates. Bug 30951 also shows a problem with /usr/share/koha/intranet/cgi-bin/installer/data/mysql/db_revs/211102003.pl where it doesn't take into account existing duplicate keys before adding a primary key. I suppose Bug 30951 might need to update that database migration so that it does some kind of deduping... or to throw a fatal error that includes a line number to make it easier to troubleshoot... -- You are receiving this mail because: You are watching all bug changes.