[Bug 18242] New: Remove primary key on old_issues.issue_id
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 Bug ID: 18242 Summary: Remove primary key on old_issues.issue_id Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: critical Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org The table old_issues has a primary key defined on the issue_id column. This issue_id comes from the issues table when an item is checked in. In some case the value of issue_id already exists in the table Basically this happens when an item is returned and mysqld is restarted: The auto increment value for issues.issue_id will be reset to MAX(issue_id)+1 (which is the value of the last entry of old_issues). See also the description of bug 18003 for more informations. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18185 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 60969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60969&action=edit Bug 18242: [SOLUTION 1]DB changes - remove PK on old_issues.issue_id -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 60970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60970&action=edit Bug 18242: [SOLUTION 1]Schema changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 60971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60971&action=edit Bug 18242: [SOLUTION 1]Remove primary key on old_issues.issue_id The table old_issues has a primary key defined on the issue_id column. This issue_id comes from the issues table when an item is checked in. In some case the value of issue_id already exists in the table Basically this happens when an item is returned and mysqld is restarted: The auto increment value for issues.issue_id will be reset to MAX(issue_id)+1 (which is the value of the last entry of old_issues). See also the description of bug 18003 for more informations. The easier solution seems to add a new column id as a primary key. The changes to the codebase are very small. However this will raise few problems: - We can no longer assume that accountlines.issue_id==old_issues.id (I guess it is problematic). - Code in Koha::REST::V1::_object_ownership_by_checkout_id is wrong assuming that old_issues.issuing_id is unique -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 60972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60972&action=edit Bug 18242: [SOLUTION 2]Add tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 60973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60973&action=edit Bug 18242: [SOLUTION 2]Handle correctly move to old_issues The table old_issues has a primary key defined on the issue_id column. This issue_id comes from the issues table when an item is checked in. In some case the value of issue_id already exists in the table Basically this happens when an item is returned and mysqld is restarted: The auto increment value for issues.issue_id will be reset to MAX(issue_id)+1 (which is the value of the last entry of old_issues). See also the description of bug 18003 for more informations. In this solution the change is done at code level instead of DB structure: If old_issues.issue_id already exists before moving from the issues table, the issue_id is updated (not on cascade for accountlines.issue_id, should it?) before the move. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18003 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60969|0 |1 is obsolete| | Attachment #60970|0 |1 is obsolete| | Attachment #60971|0 |1 is obsolete| | Attachment #60972|0 |1 is obsolete| | --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 61056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61056&action=edit Bug 18242: [SOLUTION 2]Add tests Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60973|0 |1 is obsolete| | --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 61057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61057&action=edit Bug 18242: [SOLUTION 2]Handle correctly move to old_issues The table old_issues has a primary key defined on the issue_id column. This issue_id comes from the issues table when an item is checked in. In some case the value of issue_id already exists in the table Basically this happens when an item is returned and mysqld is restarted: The auto increment value for issues.issue_id will be reset to MAX(issue_id)+1 (which is the value of the last entry of old_issues). See also the description of bug 18003 for more informations. In this solution the change is done at code level instead of DB structure: If old_issues.issue_id already exists before moving from the issues table, the issue_id is updated (not on cascade for accountlines.issue_id, should it?) before the move. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |freddyguerr@gmail.com --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- *** Bug 18185 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61056|0 |1 is obsolete| | --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 61254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61254&action=edit Bug 18242: [SOLUTION 2]Add tests Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61057|0 |1 is obsolete| | --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 61255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61255&action=edit Bug 18242: [SOLUTION 2]Handle correctly move to old_issues The table old_issues has a primary key defined on the issue_id column. This issue_id comes from the issues table when an item is checked in. In some case the value of issue_id already exists in the table Basically this happens when an item is returned and mysqld is restarted: The auto increment value for issues.issue_id will be reset to MAX(issue_id)+1 (which is the value of the last entry of old_issues). See also the description of bug 18003 for more informations. In this solution the change is done at code level instead of DB structure: If old_issues.issue_id already exists before moving from the issues table, the issue_id is updated (not on cascade for accountlines.issue_id, should it?) before the move. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- This works in all testing I tried, it does seem that if things get out of sync the ids will be updated for most returns and never get back into sync, however, I can't think of any reason issue_id needs to be static so seems fine -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #12 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the 17.05 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18329 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18329 [Bug 18329] Batch record deletion broken -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Patches don't appear to work for 16.11.x: # Failed test 'No tests run for subtest "Handle ids duplication"' # at t/db_dependent/Circulation/Returns.t line 289. Can't locate object method "find" via package "Koha::Old::Checkouts" (perhaps you forgot to load "Koha::Old::Checkouts"?) at t/db_dependent/Circulation/Returns.t line 287. If this is needed, please provide patches for 16.11.x! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- For 16.11.x you just need to replace Koha::Old::Checkout with Koha::OldIssue (bug 17796). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Jonathan, could you please provide patches for 16.11.x? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 61794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61794&action=edit Bug 18242: 16.11.x adaptation - Old::Checkouts vs OldIssues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 --- Comment #17 from Fred <freddyguerr@gmail.com> --- Please I have problems in the loans, I deleted the circulation history, please in what files should I make the changes ?. What change should I make in the database ?. I have version 16.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- These patches have been pushed to 16.11.x and will be in 16.11.07. Thx for the follow-up, Jonahtan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 --- Comment #19 from Mason James <mtj@kohaaloha.com> --- Hi, the atches don't appear to work for 16.05.x: If this is needed, please provide patches for 16.05.x ----------- mason@xen1:~/g/k/16.05.x$ git bz apply 18242 Bug 18242 - Remove primary key on old_issues.issue_id 61254 - Bug 18242: [SOLUTION 2]Add tests 61255 - Bug 18242: [SOLUTION 2]Handle correctly move to old_issues 61794 - Bug 18242: 16.11.x adaptation - Old::Checkouts vs OldIssues Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 18242: [SOLUTION 2]Add tests Using index info to reconstruct a base tree... M t/db_dependent/Circulation/Returns.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Circulation/Returns.t CONFLICT (content): Merge conflict in t/db_dependent/Circulation/Returns.t Failed to merge in the changes. Patch failed at 0001 Bug 18242: [SOLUTION 2]Add tests The copy of the patch that failed is found in: /home/mason/g/k/16.05.x/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-18242-SOLUTION-2Add-tests-uyNJwm.patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 63168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63168&action=edit Bug 18242: 16.05 version - [SOLUTION 2]Add tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 --- Comment #21 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 63169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63169&action=edit Bug 18242: 16.05 version - [SOLUTION 2]Handle correctly move to old_issues The table old_issues has a primary key defined on the issue_id column. This issue_id comes from the issues table when an item is checked in. In some case the value of issue_id already exists in the table Basically this happens when an item is returned and mysqld is restarted: The auto increment value for issues.issue_id will be reset to MAX(issue_id)+1 (which is the value of the last entry of old_issues). See also the description of bug 18003 for more informations. In this solution the change is done at code level instead of DB structure: If old_issues.issue_id already exists before moving from the issues table, the issue_id is updated (not on cascade for accountlines.issue_id, should it?) before the move. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 63170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63170&action=edit Bug 18242: 16.05 version - 16.11.x adaptation - Old::Checkouts vs OldIssues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Last 3 patches are for 16.05.x I DID NOT TEST THEM! If you want them for 16.05.x, please test. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 --- Comment #24 from Mason James <mtj@kohaaloha.com> --- (In reply to Jonathan Druart from comment #23)
Last 3 patches are for 16.05.x I DID NOT TEST THEM! If you want them for 16.05.x, please test.
thanks Jonathan, the patchset looks to be working as expected on 16.05.x :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 --- Comment #25 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.12 release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove primary key on |Move of checkouts to |old_issues.issue_id |old_issues is not handle | |correctly --- Comment #26 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Updating the bug report title, we did not remove the PK on old_issues. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18651 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18651 [Bug 18651] Move of checkouts is still not correctly handled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 --- Comment #27 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #21)
In this solution the change is done at code level instead of DB structure: If old_issues.issue_id already exists before moving from the issues table, the issue_id is updated (not on cascade for accountlines.issue_id, should it?) before the move.
See bug 18651 for a follow-up -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 Barton Chittenden <barton@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18651 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Move of checkouts to |Move of checkouts to |old_issues is not handle |old_issues is not handled |correctly |correctly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18806 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18806 [Bug 18806] Cannot revert a batch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 Barton Chittenden <barton@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18428 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Tests fail for me with and without this patch: 1..26 ok 1 - connect to intranet ok 2 - login to staff client ok 3 - load main page ok 4 - open tools module Link not found at t/db_dependent/www/batch.t line 69. # Looks like your test exited with 255 just after 4. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18931 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18963 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 Pongtawat <pongtawat@punsarn.asia> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pongtawat@punsarn.asia --- Comment #29 from Pongtawat <pongtawat@punsarn.asia> --- This patch cause a big problem for me in 16.11. The way the new issue_id are calculated/updated didn't take into consideration the case that 2 checkouts for the same item happen at the same time. While it is very unlikely, I think it shouldn't cause a problem. In our case, our Self-return vendor make a mistake and issue 2 SIP checkin messages at the same time. One of them work properly, but the other one incorrectly move the latest row in issues into old_issues. This cause the item to lost it checkout status (almost). Probably we should backport #18966 to oldstable too? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 --- Comment #30 from Pongtawat <pongtawat@punsarn.asia> --- Oh, I just notice that 16.11.10 was just released and it includes #18966 too :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 --- Comment #31 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Pongtawat from comment #30)
Oh, I just notice that 16.11.10 was just released and it includes #18966 too :)
\o/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 Sophie MEYNIEUX <sophie.meynieux@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sophie.meynieux@biblibre.co | |m --- Comment #32 from Sophie MEYNIEUX <sophie.meynieux@biblibre.com> --- This patch does not always work for 16.11 When you change issue_id with max(issue_id)+1 from old_issues but try to insert it into issues, you may have a primary key conflict. my $new_issue_id = $dbh->selectrow_array(q|SELECT MAX(issue_id)+1 FROM old_issues|); $dbh->do( q|UPDATE issues SET issue_id = ? WHERE issue_id = ?|, undef, $new_issue_id, $issue_id ); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 --- Comment #33 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Sophie MEYNIEUX from comment #32)
This patch does not always work for 16.11
Which versions of 16.11.x? You should read the description of bug 18966. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18242 claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18081 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18081 [Bug 18081] [omnibus] GDPR (General Data Protection Regulation) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org