http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9135 --- Comment #1 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 13652 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13652&action=edit Bug 9135: updatedatabase.pl fails when DEBUG is set When the DEBUG environment variable is set to a true value, all DBI errors are treated as fatal. Unfortunately, duplicate keys are incredibly common in updatedatabase.pl, since sysprefs are often added in testing, then re-added once the patches have been pushed to master (or added when on a maintenance branch, and then re-added when the system is upgraded to either a newer maintenance branch or master). This patch disables fatal errors for the updatedatabase.pl script. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9135 --- Comment #3 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- The easiest way to test this is to set your database version back, then run from the command line: export DEBUG=1 installer/data/mysql/updatedatabase.pl Without the patch, you won't get through the upgrade. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9135 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13652|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 13808 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13808&action=edit [SIGNED-OFF] Bug 9135: updatedatabase.pl fails when DEBUG is set When the DEBUG environment variable is set to a true value, all DBI errors are treated as fatal. Unfortunately, duplicate keys are incredibly common in updatedatabase.pl, since sysprefs are often added in testing, then re-added once the patches have been pushed to master (or added when on a maintenance branch, and then re-added when the system is upgraded to either a newer maintenance branch or master). This patch disables fatal errors for the updatedatabase.pl script. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests and perlcritic pass. To test, run from command line: export DEBUG=1 installer/data/mysql/updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9135 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13808|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 13837 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13837&action=edit Bug 9135: updatedatabase.pl fails when DEBUG is set When the DEBUG environment variable is set to a true value, all DBI errors are treated as fatal. Unfortunately, duplicate keys are incredibly common in updatedatabase.pl, since sysprefs are often added in testing, then re-added once the patches have been pushed to master (or added when on a maintenance branch, and then re-added when the system is upgraded to either a newer maintenance branch or master). This patch disables fatal errors for the updatedatabase.pl script. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests and perlcritic pass. To test, run from command line: export DEBUG=1 installer/data/mysql/updatedatabase.pl Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> If a query causes an error, the script continues as expected. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9135 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x and 3.8.x, will be in 3.10.1 and 3.8.8 -- You are receiving this mail because: You are watching all bug changes.