[Bug 6776] New: Add Checkin tab to patron search tool
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6776 Bug #: 6776 Summary: Add Checkin tab to patron search tool Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_6 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Circulation AssignedTo: kyle.m.hall@gmail.com ReportedBy: savitra.sirohi@osslabs.biz QAContact: koha-bugs@lists.koha-community.org CC: gmcharlt@gmail.com Add check-in as an option in patron-search.inc, thus allowing a checkin tab to be available in several patron and circulation pages -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6776 Savitra Sirohi <savitra.sirohi@osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |amit.gupta@osslabs.biz AssignedTo|kyle.m.hall@gmail.com |shinoy.m@osslabs.biz -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6776 --- Comment #1 from Amit Gupta <amit.gupta@osslabs.biz> 2011-09-09 07:57:22 UTC --- Created attachment 5376 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5376 Add Checkin tab to patron search tool Add Checkin tab to patron search tool -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6776 Amit Gupta <amit.gupta@osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6776 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6776 --- Comment #2 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-06 16:30:16 UTC --- Created attachment 5745 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5745 Bug 6776 - Add Checkin tab to patron search tool Add check-in as an option in patron-search.inc, thus allowing a checkin tab to be available in several patron and circulation pages Signed-off-by: Amit Gupta <amit.gupta@osslabs.biz> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6776 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5376|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6776 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Patch Status|Signed Off |Passed QA --- Comment #3 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-06 16:31:39 UTC --- QA comment: trivial patch, correctly spelled, usefull addition even if all other search tabs have usually 3 tabs, marking passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6776 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.walls@bywatersolutions. | |com Patch Status|Passed QA |Failed QA --- Comment #4 from Ian Walls <ian.walls@bywatersolutions.com> 2011-10-06 19:51:52 UTC --- Does not respect checkin permissions like circulation/circ-search.inc does. Needs to be wrapped in [% IF ( CAN_user_circulate ) %] -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6776 --- Comment #5 from Amit Gupta <amit.gupta@osslabs.biz> 2011-10-07 06:27:10 UTC --- Created attachment 5761 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5761 Add Checkin tab to patron search tool Add Checkin tab to patron search tool wrapped in [% IF ( CAN_user_circulate ) %] -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6776 Amit Gupta <amit.gupta@osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6776 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Failed QA --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-07 09:15:50 UTC --- QA comment, sorry amit, another comment: please don't use tabs, but 4 spaces. It would also be better to have: + </div> + [% END %] instead of + </div>[% END %] I almost missed the END and thought it would not work ! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6776 --- Comment #7 from Ian Walls <ian.walls@bywatersolutions.com> 2011-10-07 11:31:13 UTC --- Thank you for resubmitting with the permissions change! One other small bit, not a blocker to QA but something I noticed; since Checkout and Checkin require the same permissions, you can wrap the tabs in the same [% if %] block, instead of having conditionals individually for both tabs. This is just a shortcut, not important, and your way does allow for us to more easily differentiate checkin and checkout permissions in the future. The change from tab to 4 spaces is requested; putting [% END %] on it's own line is optional. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6776 --- Comment #8 from Amit Gupta <amit.gupta@osslabs.biz> 2011-10-07 12:10:49 UTC --- Created attachment 5766 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5766 Add Checkin tab to patron search tool Using space instead of tab. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6776 Amit Gupta <amit.gupta@osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6776 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5761|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6776 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Passed QA --- Comment #9 from Ian Walls <ian.walls@bywatersolutions.com> 2011-10-07 12:14:13 UTC --- Thank you for your diligence on this, Amit. I count the previous signoffs as still good, and include my own. Passed QA. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6776 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5745|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6776 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> 2011-10-07 12:16:59 UTC --- I would also like to comment that we don't have a strict rule about tabs versus spaces in the templates, although maybe we should. There is also no style rule about Template:Toolkit tag placement. These could be subjects of future template style discussions, but shouldn't be a barrier to QA until rules are in place. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6776 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Passed QA |Patch Pushed --- Comment #11 from Chris Cormack <chris@bigballofwax.co.nz> 2011-10-09 21:08:33 UTC --- Pushed please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6776 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #12 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Seems to be working. Closing. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org