[Bug 17213] New: Self registration cardnumber is not editable if errors found when form submitted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17213 Bug ID: 17213 Summary: Self registration cardnumber is not editable if errors found when form submitted Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com To recreate: Make sure cardnumber is not in 'PatronSelfRegistrationBorrowerUnwantedField' Register a new patron using an existing cardnumber You get a 'card number is in use' error, but you can't edit the field -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17213 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14659 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14659 [Bug 14659] Allow patrons to enter card number and patron category on OPAC registration page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17213 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17213 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 54970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54970&action=edit Bug 17213 - Self registration cardnumber is not editable if errors found when form submitted To test: Enable self registration Make sure cardnumber is not in 'PatronSelfRegistrationBorrowerUnwantedField' Enter an invalid or used cardnumber Submit form Note errors appears correctly but cardnumber is not editable Apply Patch Enter an invalid or used cardnumber Submit form Note errors appears correctly and cardnumber is editable -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17213 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 54971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54971&action=edit Bug 17213 - Add HTML5 validation to cardnumber field on patron self registration To test: Verify that different values in 'CardnumberLength' system preference display correctly in the self reigstration form -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17213 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Needs Signoff |Failed QA --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- With the patch applied, instead of getting the 'cardnumber in use' error, the account is created with a NULL cardnumber! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17213 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54971|0 |1 is obsolete| | --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 55097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55097&action=edit Bug 17213 - Add HTML5 validation to cardnumber field on patron self registration To test: Verify that different values in 'CardnumberLength' system preference display correctly in the self reigstration form -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17213 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Kyle M Hall from comment #3)
With the patch applied, instead of getting the 'cardnumber in use' error, the account is created with a NULL cardnumber!
Fixed bad copy paste error (wrong variable names) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17213 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17213 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54970|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 55449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55449&action=edit [SIGNED-OFF] Bug 17213 - Self registration cardnumber is not editable if errors found when form submitted To test: Enable self registration Make sure cardnumber is not in 'PatronSelfRegistrationBorrowerUnwantedField' Enter an invalid or used cardnumber Submit form Note errors appears correctly but cardnumber is not editable Apply Patch Enter an invalid or used cardnumber Submit form Note errors appears correctly and cardnumber is editable Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17213 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55097|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 55450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55450&action=edit [SIGNED-OFF] Bug 17213 - Add HTML5 validation to cardnumber field on patron self registration To test: Verify that different values in 'CardnumberLength' system preference display correctly in the self reigstration form Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17213 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17213 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |Patch doesn't apply --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- fatal: sha1 information is lacking or useless (koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17213 --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 55530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55530&action=edit Bug 17213 - Self registration cardnumber is not editable if errors found when form submitted To test: Enable self registration Make sure cardnumber is not in 'PatronSelfRegistrationBorrowerUnwantedField' Enter an invalid or used cardnumber Submit form Note errors appears correctly but cardnumber is not editable Apply Patch Enter an invalid or used cardnumber Submit form Note errors appears correctly and cardnumber is editable Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17213 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55449|0 |1 is obsolete| | Attachment #55450|0 |1 is obsolete| | --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 55531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55531&action=edit Bug 17213 - Add HTML5 validation to cardnumber field on patron self registration To test: Verify that different values in 'CardnumberLength' system preference display correctly in the self reigstration form Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17213 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17213 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The cardnumber is not unwanted... but still doesn't show up in my tests. What am I missing? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17213 --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #11)
The cardnumber is not unwanted... but still doesn't show up in my tests. What am I missing?
Do you have AutoMemberNum enabled? That must be turned off to see card number -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17213 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17213 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55530|0 |1 is obsolete| | Attachment #55531|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 55665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55665&action=edit [PASSED QA] Bug 17213 - Add HTML5 validation to cardnumber field on patron self registration To test: Verify that different values in 'CardnumberLength' system preference display correctly in the self reigstration form Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17213 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55665|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 55666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55666&action=edit [PASSED QA] Bug 17213 - Self registration cardnumber is not editable if errors found when form submitted To test: Enable self registration Make sure cardnumber is not in 'PatronSelfRegistrationBorrowerUnwantedField' Enter an invalid or used cardnumber Submit form Note errors appears correctly but cardnumber is not editable Apply Patch Enter an invalid or used cardnumber Submit form Note errors appears correctly and cardnumber is editable Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17213 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 55667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55667&action=edit [PASSED QA] Bug 17213 - Add HTML5 validation to cardnumber field on patron self registration To test: Verify that different values in 'CardnumberLength' system preference display correctly in the self reigstration form Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17213 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Nick! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17213 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #17 from Frédéric Demians <frederic@tamil.fr> --- It doesn't apply on 16.05 branch. If it's required, a version of this patch for 16.05 should be submitted. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org