[Bug 36751] New: Creating new patron attribute types should start with type choice
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36751 Bug ID: 36751 Summary: Creating new patron attribute types should start with type choice Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: pedro.amorim@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com A date attribute type cannot be text, an authorised value category attribute type cannot be date, etc. As such, we should ideally not keep adding options to the attribute type form that can't make sense together. Currently, an authorised value category attribute can be set as "repeatable" but it doesn't work. A future use-case example: we add the option for a "True/False" attribute type, this type should not possibly be a date, an authorised value category, repeatable and should also not possibly be marked as a unique identifier. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36751 --- Comment #1 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 166061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166061&action=edit Bug 36751: PoC This is a PoC only. More work should be done here. Imo, ideally, we'd have a mapping where each 'model' would define what it supports ('repeateable', 'searchable', 'unique identifier', etc). But first would like to know what others think of this. Is this is a good idea? Should we invest more time here. Test plan, k-t-d: Visit patron attribute types at: http://localhost:8081/cgi-bin/koha/admin/patron-attr-types.pl Click "New patron attribute type" Notice you are now presented with choices in regards to the model of the attribute type: "Text", "Date" or "Authorized value category Notice if you pick "Date", you're unable to pick an authorized value category Notice if you pick "Authorised value category", you're unable to pick if its a date or not -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36751 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |36164 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36164 [Bug 36164] Bring more consistency to our module landing pages -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36751 --- Comment #2 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 166062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166062&action=edit UI demo screenshot -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36751 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com, | |julian.maurice@biblibre.com | |, | |martin.renvoize@ptfs-europe | |.com, | |nick@bywatersolutions.com, | |oleonard@myacpl.org Status|NEW |In Discussion -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36751 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36761 Assignee|koha-bugs@lists.koha-commun |pedro.amorim@ptfs-europe.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36751 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Yes, good idea, but I would put everything on the same view. The buttons on top of the form maybe? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36751 --- Comment #4 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #3)
Yes, good idea, but I would put everything on the same view. The buttons on top of the form maybe?
Interesting suggestion, my idea was to do exactly the opposite of this, i.e. show the user the least possible UI elements at a time, to 'ease in' creating a new custom field, and show only the UI applicable elements once the type/model choice was done. If we show everything on the same view, we'd then need to hide unapplicable UI elements depending on the selected type through JavaScript (?) which is exactly what I'd like to avoid doing, e.g. if the user picks "Date", then the "Authorized value" input would be hidden by JS, and vice-versa. This is what is happening currently, but disabling/enabling UI elements instead of hiding, through JS. Which, again, is exactly what I'm trying to improve here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36751 --- Comment #5 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- I agree with Pedro, the current form disabling some optoins as you enable others is unclear. I also agree with Joubu - the full intermediate page seems a bit too far. I think if you made the 'New patron attribute type' a split button - so you had a dropdown and could initially select the type before going to the form it would let you skip the extra page, but could also direct you there if you clicked the main button. Does that make sense? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36751 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I like the idea of the split button approach :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36751 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166061|0 |1 is obsolete| | --- Comment #7 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 166457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166457&action=edit Bug 36751: PoC New PoC removing the intermediary screen and adding dropdown choices instead. This also now adds the 'model' column in the UI table. I would prefer to go deeper and update the database schema but I feel that might be too much for now. Test plan, remains the same but dropdown choices instead of new UI screen: Visit patron attribute types at: http://localhost:8081/cgi-bin/koha/admin/patron-attr-types.pl Click "New patron attribute type" Notice you are now presented with choices in regards to the model of the attribute type: "Text", "Date" or "Authorized value category Notice if you pick "Date", you're unable to pick an authorized value category Notice if you pick "Authorised value category", you're unable to pick if its a date or not -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36751 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|36164 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36164 [Bug 36164] Bring more consistency to our module landing pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36751 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166062|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org