[Bug 39782] New: Staff Interface - Register a new account page - field label missing for gender selection
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39782 Bug ID: 39782 Summary: Staff Interface - Register a new account page - field label missing for gender selection Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Accessibility Assignee: Laura.escamilla@bywatersolutions.com Reporter: Laura.escamilla@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: martin.renvoize@openfifth.co.uk, matt.blenkinsop@openfifth.co.uk, oleonard@myacpl.org To reproduce: 1. Visit http://localhost:8081/cgi-bin/koha/opac-memberentry.pl or your test OPAC self registration page. 2. Under Identity scroll down until you see four radio buttons used to choose a gender. Note that there is no label next to the buttons. 3. Apply the patch. 4. The label “Gender” is now visible next to the radio buttons. 5. Sign off and have an amazing day! :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39782 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39782 --- Comment #1 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 181688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181688&action=edit Bug 39782: Added gender label to patron registration form radio buttons To reproduce: 1. Visit http://localhost:8081/cgi-bin/koha/opac-memberentry.pl or your test OPAC self registration page. 2. Under Identity scroll down until you see four radio buttons used to choose a gender. Note that there is no label next to the buttons. 3. Apply the patch. 4. The label “Gender” is now visible next to the radio buttons. 5. Sign off and have an amazing day! :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39782 --- Comment #2 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- The second reproduce should say "To test"... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39782 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39782 --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 181691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181691&action=edit Bug 39782: Add gender label to patron registration form radio buttons This fixes the patron registration form in the staff interface. There is no "Gender" label before the radio buttons. Test plan: 1. Go to Patrons > +New patron > [Select any patron type] (http://localhost:8081/cgi-bin/koha/opac-memberentry.pl). 2. In the patron identity section you will see four radio buttons used to choose a gender. Note that there is no label next to the buttons. 3. Apply the patch and refresh the page.. 4. The label "Gender" is now visible next to the radio buttons. 5. Sign off and have an amazing day! :D Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39782 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Staff Interface - Register |Staff interface patron |a new account page - field |registration form - field |label missing for gender |label missing for gender |selection |selection See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=39661 CC| |david@davidnind.com Text to go in the| |This fixes the patron release notes| |registration form in the | |staff interface. It adds a | |label ("Gender") before the | |gender selection options in | |the patron identity | |section. --- Comment #4 from David Nind <david@davidnind.com> --- I've amended the commit message (see the commit message guidelines https://wiki.koha-community.org/wiki/Commit_messages) I've also linked it to the bug that fixes the same issue for the OPAC. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39782 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181688|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39782 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com --- Comment #5 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Fine for me, not blocking but would you have time to also align it with the rest of the fields ? It is way better but still a bit weird. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39782 --- Comment #6 from David Nind <david@davidnind.com> --- (In reply to Baptiste Wojtkowski (bwoj) from comment #5)
Fine for me, not blocking but would you have time to also align it with the rest of the fields ? It is way better but still a bit weird.
I think this may be a general style, as other radio button groups are shown the same way (for example, the "Allow auto-renewal of items" yes/no selection). It uses the class="radio", and has padding-left of 7.5 em (I originally thought it was centred). It is used in a lot of places, not just the patron entry form. For that reason, I think it is outside the scope of this bug - we should create a separate bug for it. If you agree, I'll create the bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39782 --- Comment #7 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- I agree that the styling is outside the scope of this bug and can be opened as a new bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39782 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Baptiste Wojtkowski (bwoj) from comment #5)
Fine for me, not blocking but would you have time to also align it with the rest of the fields ? It is way better but still a bit weird.
My hope is that my work on converting forms to use a grid layout is going to make this kind of display better. See Bug 39483. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39782 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The alignment could be a little nicer, but I believe we can fix later or with Owen's grid work. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39782 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39782 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181691|0 |1 is obsolete| | --- Comment #10 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 181846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181846&action=edit Bug 39782: Add gender label to patron registration form radio buttons This fixes the patron registration form in the staff interface. There is no "Gender" label before the radio buttons. Test plan: 1. Go to Patrons > +New patron > [Select any patron type] (http://localhost:8081/cgi-bin/koha/opac-memberentry.pl). 2. In the patron identity section you will see four radio buttons used to choose a gender. Note that there is no label next to the buttons. 3. Apply the patch and refresh the page.. 4. The label "Gender" is now visible next to the radio buttons. 5. Sign off and have an amazing day! :D Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39782 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not pushed to 24.11.x LTS for UI stability -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org