[Bug 18243] New: Bug 16034 follow-up: better handling of absence of WebService::ILS::OverDrive:: Patron at testing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18243 Bug ID: 18243 Summary: Bug 16034 follow-up: better handling of absence of WebService::ILS::OverDrive::Patron at testing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: srdjan@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18243 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18243 --- Comment #1 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 60974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60974&action=edit Bug 18243: 16034 follow-up: better handling of absence of WebService::ILS::OverDrive::Patron at testing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18243 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16034 CC| |jonathan.druart@bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 [Bug 16034] Integration with OverDrive Patron API -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18243 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18243 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60974|0 |1 is obsolete| | --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 61017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61017&action=edit Bug 18243: 16034 follow-up: better handling of absence of WebService::ILS::OverDrive::Patron at testing To test: 1 - Make sure you don't have WebService::ILS::OverDrive::Patron installed 2 - prove t/Koha_ExternalContent_OverDrive.t 3 - You should get a failure to load module and tests are skipped 4 - Apply patch 5 - prove t/Koha_ExternalContent_OverDrive.t 6 - Module is not loaded, test are skipped Fixed small typo 'cannot filnd' -> 'cannot find' Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18243 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18243 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61017|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 61039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61039&action=edit Bug 18243: 16034 follow-up: better handling of absence of WebService::ILS::OverDrive::Patron at testing To test: 1 - Make sure you don't have WebService::ILS::OverDrive::Patron installed 2 - prove t/Koha_ExternalContent_OverDrive.t 3 - You should get a failure to load module and tests are skipped 4 - Apply patch 5 - prove t/Koha_ExternalContent_OverDrive.t 6 - Module is not loaded, test are skipped Fixed small typo 'cannot filnd' -> 'cannot find' Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18243 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Component|OPAC |Test Suite Assignee|oleonard@myacpl.org |srdjan@catalyst.net.nz QA Contact|testopia@bugs.koha-communit |gmcharlt@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18243 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18243 --- Comment #4 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 61055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61055&action=edit Bug 18243: 16034 follow-up: Conditionally test Koha::ExternalContent::* modules loading To test: 1 - Make sure you don't have WebService::ILS installed 2 - prove t/00-load.t 3 - You should get a failure to load module and tests are skipped 4 - Apply patch 5 - prove t/00-load.t 6 - Module is not loaded, test are skipped Optional: 7 - Install WebService::ILS 5 - prove t/00-load.t 6 - Module is loaded, test passes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18243 --- Comment #5 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Apologies for the late submission. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18243 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18243 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61039|0 |1 is obsolete| | Attachment #61055|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 61063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61063&action=edit Bug 18243: 16034 follow-up: better handling of absence of WebService::ILS::OverDrive::Patron at testing To test: 1 - Make sure you don't have WebService::ILS::OverDrive::Patron installed 2 - prove t/Koha_ExternalContent_OverDrive.t 3 - You should get a failure to load module and tests are skipped 4 - Apply patch 5 - prove t/Koha_ExternalContent_OverDrive.t 6 - Module is not loaded, test are skipped Fixed small typo 'cannot filnd' -> 'cannot find' Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18243 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 61064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61064&action=edit Bug 18243: 16034 follow-up: Conditionally test Koha::ExternalContent::* modules loading To test: 1 - Make sure you don't have WebService::ILS installed 2 - prove t/00-load.t 3 - You should get a failure to load module and tests are skipped 4 - Apply patch 5 - prove t/00-load.t 6 - Module is not loaded, test are skipped Optional: 7 - Install WebService::ILS 5 - prove t/00-load.t 6 - Module is loaded, test passes Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18243 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Ok thanks, skipping QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18243 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|gmcharlt@gmail.com |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18243 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko@abunchofthings.net --- Comment #9 from Mirko Tietgen <mirko@abunchofthings.net> --- Fixes the problem for the nightly builds too, please push. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18243 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Srdjan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18243 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Depends on bug 16034 which is not in 16.11.x. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org