https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28605 Bug ID: 28605 Summary: Code to calculate item's holdability must be moved to Koha::Item Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 28422 Code is duplicated in opac/opac-ISBDdetail.pl, opac/opac-MARCdetail.pl and opac/opac-detail.pl (at least). It must be moved to a Koha::Item method 721 $norequests = 0 722 if $norequests 723 && !$itm->{'withdrawn'} 724 && !$itm->{'itemlost'} 725 && ($itm->{'itemnotforloan'}<0 || not $itm->{'itemnotforloan'}) 726 && !$itemtypes->{$itm->{'itype'}}->{notforloan} 727 && $itm->{'itemnumber'}; search for '$norequests' in those 3 files. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28422 [Bug 28422] OPAC MARC detail view doesn't correctly evaluate holdability -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.