[Bug 41552] New: Holds are not removed from holds queue when hold is suspended
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41552 Bug ID: 41552 Summary: Holds are not removed from holds queue when hold is suspended Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, lisette@bywatersolutions.com, tomascohen@gmail.com If one is not using the real time holds queue, holds are not removed from the queue when suspended. Instead, they remain listed until the next time the cron is run. We should remove holds from the queue immediately when suspended, as we do when a hold is filled. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41552 --- Comment #1 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 192914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192914&action=edit Bug 41552: Remove hold from holds queue when suspended Patch from commit b3d73c5 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41552 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41552 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192914|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41552 --- Comment #2 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 192915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192915&action=edit Bug 41552: Remove hold from holds queue when suspended If one is not using the real time holds queue, holds are not removed from the queue when suspended. Instead, they remain listed until the next time the cron is run. We should remove holds from the queue immediately when suspended, as we do when a hold is filled. Test Plan: 1) Apply this patch 2) prove t/db_dependent/HoldsQueue.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41552 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192915|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41552 --- Comment #3 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 192916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192916&action=edit Bug 41552: Add unit tests Patch from commit 35dc09a -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41552 --- Comment #4 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 192917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192917&action=edit Bug 41552: Remove hold from holds queue when suspended If one is not using the real time holds queue, holds are not removed from the queue when suspended. Instead, they remain listed until the next time the cron is run. We should remove holds from the queue immediately when suspended, as we do when a hold is filled. Test Plan: 1) Apply this patch 2) prove t/db_dependent/HoldsQueue.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41552 Chris Mathevet <chris.mathevet@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |chris.mathevet@inLibro.com --- Comment #5 from Chris Mathevet <chris.mathevet@inLibro.com> --- Result failed for prove t/db_dependent/HoldsQueue.t t/db_dependent/HoldsQueue.t .. 35/66 # Failed test 'Hold queue contains one hold' # at t/db_dependent/HoldsQueue.t line 1076. # got: '0' # expected: '1' # Looks like you planned 3 tests but ran 1. # Looks like you failed 1 test of 1 run. # Failed test 'Test Local Holds Priority - Bib level' # at t/db_dependent/HoldsQueue.t line 1086. Can't call method "borrowernumber" on an undefined value at t/db_dependent/HoldsQueue.t line 1080. t/db_dependent/HoldsQueue.t .. 49/66 # Looks like your test exited with 95 just after 49. t/db_dependent/HoldsQueue.t .. Dubious, test returned 95 (wstat 24320, 0x5f00) Failed 18/66 subtests Test Summary Report ------------------- t/db_dependent/HoldsQueue.t (Wstat: 24320 (exited 95) Tests: 49 Failed: 1) Failed test: 48 Non-zero exit status: 95 Parse errors: Bad plan. You planned 66 tests but ran 49. Files=1, Tests=49, 4 wallclock secs ( 0.02 usr 0.01 sys + 2.73 cusr 0.31 csys = 3.07 CPU) Result: FAIL -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org